fix: close the tail items from the targeted re-audit

Resolves the 13 rows still partial in docs/rewrite/notes/review-rv4-
codex.md (details in final-Z5.md):
- Escaped config strings are decoded to raw bytes at every OS boundary:
  Flatpak cwd/argv to D-Bus, screen-file paths, the default config
  template, GHOSTTY_RESOURCES_DIR/TERMINFO/shell integration/
  bindtextdomain consumers, custom shader loading, list-themes hyperlinks.
- osbytes escapes literal U+FDD0 on non-Unix too (bijective everywhere);
  the GTK paste dialog only decodes text that was actually encoded.
- shadertoy: whole-array uses of iChannelTime rebuild a plain float[4]
  from the std140-padded members (naga-validated, MSL offsets checked).
- libghostty-vt: the OSC parser holds caller-allocated storage inline
  and command payloads borrow from it, so ghostty_osc_end performs no
  global allocations (verified from Rust and C).
- crash: aarch64 Linux minidump context fixed; macOS fatal signals record
  siginfo, registers and a fault-safe stack walk.
- tripwire: selectionString map allocation-failure cleanup test ported.
- libghostty-vt emits the versioned soname libghostty-vt.so.0 at build
  time (no patchelf needed at install).

Test Plan:
- cargo test --workspace (3342 passed)
- just check-macos; just check-macos x86_64-apple-darwin;
  just check-windows; just check-wasm
- cargo check --target aarch64-unknown-linux-gnu -p ghostty-crash
This commit is contained in:
ddidderr committed 2026-10-12 08:45:21 +02:00
1 parent bc297c823b
commit 184cdd5c62
49 files changed
+1785 -557

No files matched your search

+15
View File
@@ -34,6 +34,8 @@ struct Scratch {
event: [u8; EVENT_CAP],
head: [u8; HEAD_CAP],
path: [u8; PATH_CAP],
#[cfg(target_vendor = "apple")]
native: crate::native::Native,
}
struct ScratchCell(UnsafeCell<Scratch>);
@@ -44,6 +46,8 @@ static SCRATCH: ScratchCell = ScratchCell(UnsafeCell::new(Scratch {
event: [0; EVENT_CAP],
head: [0; HEAD_CAP],
path: [0; PATH_CAP],
#[cfg(target_vendor = "apple")]
native: crate::native::Native::new(),
}));
static BUSY: AtomicBool = AtomicBool::new(false);
@@ -150,6 +154,16 @@ fn write_signal_report(name: &str, desc: &str, info: *mut libc::siginfo_t, uc: *
return;
};
let (secs, micros) = sentry::now();
// Darwin: record the faulting thread's registers and stack in the event
// (no minidump there; see `native.rs`).
#[cfg(target_vendor = "apple")]
let native_ctx = {
// SAFETY: `info`/`uc` are the pointers the kernel gave the handler.
unsafe { crate::darwin::capture(&mut sc.native, info, uc) };
Some(&sc.native)
};
#[cfg(not(target_vendor = "apple"))]
let native_ctx = None;
let crash = Crash {
uuid,
secs,
@@ -157,6 +171,7 @@ fn write_signal_report(name: &str, desc: &str, info: *mut libc::siginfo_t, uc: *
kind: name,
value: desc,
mechanism: "signalhandler",
native: native_ctx,
};
let mut ev = SliceWriter {