fix: close the tail items from the targeted re-audit

Resolves the 13 rows still partial in docs/rewrite/notes/review-rv4-
codex.md (details in final-Z5.md):
- Escaped config strings are decoded to raw bytes at every OS boundary:
  Flatpak cwd/argv to D-Bus, screen-file paths, the default config
  template, GHOSTTY_RESOURCES_DIR/TERMINFO/shell integration/
  bindtextdomain consumers, custom shader loading, list-themes hyperlinks.
- osbytes escapes literal U+FDD0 on non-Unix too (bijective everywhere);
  the GTK paste dialog only decodes text that was actually encoded.
- shadertoy: whole-array uses of iChannelTime rebuild a plain float[4]
  from the std140-padded members (naga-validated, MSL offsets checked).
- libghostty-vt: the OSC parser holds caller-allocated storage inline
  and command payloads borrow from it, so ghostty_osc_end performs no
  global allocations (verified from Rust and C).
- crash: aarch64 Linux minidump context fixed; macOS fatal signals record
  siginfo, registers and a fault-safe stack walk.
- tripwire: selectionString map allocation-failure cleanup test ported.
- libghostty-vt emits the versioned soname libghostty-vt.so.0 at build
  time (no patchelf needed at install).

Test Plan:
- cargo test --workspace (3342 passed)
- just check-macos; just check-macos x86_64-apple-darwin;
  just check-windows; just check-wasm
- cargo check --target aarch64-unknown-linux-gnu -p ghostty-crash
This commit is contained in:
ddidderr committed 2026-10-12 08:45:21 +02:00
1 parent bc297c823b
commit 184cdd5c62
49 files changed
+1785 -557

No files matched your search

+28 -9
View File
@@ -296,6 +296,14 @@ impl FlatpakSignalHandle {
}
}
/// Decode a reversible config string to the original bytes plus NUL, the
/// D-Bus `ay` form of a path/argument.
fn nul_terminated_bytes(s: &str) -> Vec<u8> {
let mut v = crate::osbytes::config_str_to_bytes(s);
v.push(0);
v
}
struct Request {
argv: Vec<String>,
cwd: Option<String>,
@@ -346,22 +354,26 @@ fn start(
.argv
.iter()
.map(|a| {
let mut v = a.as_bytes().to_vec();
let mut v = crate::osbytes::config_str_to_bytes(a);
v.push(0);
v
})
.collect();
// Get the cwd in case we don't have ours set.
let cwd = match request.cwd {
Some(c) => c,
None => std::env::current_dir()
.map_err(|_| Error::FlatpakSetupFail)?
.to_string_lossy()
.into_owned(),
// D-Bus `ay`: the original bytes (request.cwd carries the reversible
// config-string encoding).
let cwd = if let Some(c) = request.cwd {
nul_terminated_bytes(&c)
} else {
let mut v = crate::osbytes::os_bytes(
std::env::current_dir()
.map_err(|_| Error::FlatpakSetupFail)?
.as_os_str(),
);
v.push(0);
v
};
let mut cwd = cwd.into_bytes();
cwd.push(0);
// Subscribe to exit notifications (before the call so we can't miss it).
let rule = MatchRule::builder()
@@ -429,6 +441,13 @@ fn wait_for_exit(shared: &Shared, iter: MessageIterator, pid: u32) {
#[cfg(test)]
mod tests {
#[test]
fn dbus_bytes_are_decoded() {
let enc = crate::osbytes::bytes_to_config_string(b"/tmp/\xff\xfe");
assert_ne!(enc.as_bytes(), b"/tmp/\xff\xfe");
assert_eq!(super::nul_terminated_bytes(&enc), b"/tmp/\xff\xfe\0");
}
use super::*;
#[test]