fix: close the tail items from the targeted re-audit
Resolves the 13 rows still partial in docs/rewrite/notes/review-rv4- codex.md (details in final-Z5.md): - Escaped config strings are decoded to raw bytes at every OS boundary: Flatpak cwd/argv to D-Bus, screen-file paths, the default config template, GHOSTTY_RESOURCES_DIR/TERMINFO/shell integration/ bindtextdomain consumers, custom shader loading, list-themes hyperlinks. - osbytes escapes literal U+FDD0 on non-Unix too (bijective everywhere); the GTK paste dialog only decodes text that was actually encoded. - shadertoy: whole-array uses of iChannelTime rebuild a plain float[4] from the std140-padded members (naga-validated, MSL offsets checked). - libghostty-vt: the OSC parser holds caller-allocated storage inline and command payloads borrow from it, so ghostty_osc_end performs no global allocations (verified from Rust and C). - crash: aarch64 Linux minidump context fixed; macOS fatal signals record siginfo, registers and a fault-safe stack walk. - tripwire: selectionString map allocation-failure cleanup test ported. - libghostty-vt emits the versioned soname libghostty-vt.so.0 at build time (no patchelf needed at install). Test Plan: - cargo test --workspace (3342 passed) - just check-macos; just check-macos x86_64-apple-darwin; just check-windows; just check-wasm - cargo check --target aarch64-unknown-linux-gnu -p ghostty-crash
This commit is contained in:
1 parent
bc297c823b
commit
184cdd5c62
49 files changed
+1785
-557
No files matched your search
@@ -685,9 +685,31 @@ fn screen_set_attribute_splits_page_on_out_of_space_at_max_styles() {
|
||||
assert!(page_was_split);
|
||||
}
|
||||
|
||||
// "selectionString map allocation failure cleanup" is skipped: it relies on
|
||||
// Zig tripwire allocation-failure injection (selectionString_tw), which has
|
||||
// no Rust counterpart.
|
||||
#[test]
|
||||
fn screen_selection_string_map_allocation_failure_cleanup() {
|
||||
use crate::tripwire::ResetMode;
|
||||
|
||||
// If building the StringMap fails, the already-built string must be
|
||||
// dropped and the error returned (Zig: errdefer free(map_string)).
|
||||
let mut s = init(10, 5, 0);
|
||||
s.test_write_string("hello").unwrap();
|
||||
let sel = sel_active(&s, (0, 0), (4, 0), false);
|
||||
|
||||
selection_string_tw::error_always(
|
||||
SelectionStringPoint::CopyMap,
|
||||
SelectionStringError::OutOfMemory,
|
||||
);
|
||||
let result = s.try_selection_string_map(SelectionString { sel, trim: true });
|
||||
assert!(matches!(result, Err(SelectionStringError::OutOfMemory)));
|
||||
selection_string_tw::end(ResetMode::Reset).unwrap();
|
||||
|
||||
// And it works again once the tripwire is reset.
|
||||
let map = s
|
||||
.try_selection_string_map(SelectionString { sel, trim: true })
|
||||
.unwrap();
|
||||
assert_eq!(map.string, "hello");
|
||||
assert_eq!(map.map.len(), 5);
|
||||
}
|
||||
|
||||
fn setup_prompt(cols: u16, click: Click) -> Screen {
|
||||
let mut s = init(cols, 5, 0);
|
||||
|
||||
Reference in new issue
Block a user