fix: close the tail items from the targeted re-audit
Resolves the 13 rows still partial in docs/rewrite/notes/review-rv4- codex.md (details in final-Z5.md): - Escaped config strings are decoded to raw bytes at every OS boundary: Flatpak cwd/argv to D-Bus, screen-file paths, the default config template, GHOSTTY_RESOURCES_DIR/TERMINFO/shell integration/ bindtextdomain consumers, custom shader loading, list-themes hyperlinks. - osbytes escapes literal U+FDD0 on non-Unix too (bijective everywhere); the GTK paste dialog only decodes text that was actually encoded. - shadertoy: whole-array uses of iChannelTime rebuild a plain float[4] from the std140-padded members (naga-validated, MSL offsets checked). - libghostty-vt: the OSC parser holds caller-allocated storage inline and command payloads borrow from it, so ghostty_osc_end performs no global allocations (verified from Rust and C). - crash: aarch64 Linux minidump context fixed; macOS fatal signals record siginfo, registers and a fault-safe stack walk. - tripwire: selectionString map allocation-failure cleanup test ported. - libghostty-vt emits the versioned soname libghostty-vt.so.0 at build time (no patchelf needed at install). Test Plan: - cargo test --workspace (3342 passed) - just check-macos; just check-macos x86_64-apple-darwin; just check-windows; just check-wasm - cargo check --target aarch64-unknown-linux-gnu -p ghostty-crash
This commit is contained in:
1 parent
bc297c823b
commit
184cdd5c62
49 files changed
+1785
-557
No files matched your search
@@ -29,6 +29,9 @@ fn cargo() -> Command {
|
||||
Command::new(std::env::var_os("CARGO").unwrap_or_else(|| "cargo".into()))
|
||||
}
|
||||
|
||||
/// Major version of libghostty-vt (the soname suffix set by build.rs).
|
||||
pub const VT_MAJOR: u32 = 0;
|
||||
|
||||
static INSTALLED: OnceLock<PathBuf> = OnceLock::new();
|
||||
|
||||
/// Build the cdylib/staticlib for the host and install them as
|
||||
@@ -61,6 +64,19 @@ fn install_native_lib_once() -> PathBuf {
|
||||
std::fs::rename(&tmp, &dst).expect("install library");
|
||||
}
|
||||
}
|
||||
// The cdylib's soname is versioned (`libghostty-vt.so.<major>`, see
|
||||
// build.rs), so executables linked against it need that name at run time
|
||||
// (otherwise the loader would fall back to an unrelated system copy).
|
||||
let so = dir.join("libghostty-vt.so");
|
||||
if so.exists() {
|
||||
let versioned = dir.join(format!("libghostty-vt.so.{VT_MAJOR}"));
|
||||
let tmp = dir.join(format!(
|
||||
"libghostty-vt.so.{VT_MAJOR}.{}.tmp",
|
||||
std::process::id()
|
||||
));
|
||||
std::fs::copy(&so, &tmp).expect("install versioned library");
|
||||
std::fs::rename(&tmp, &versioned).expect("install versioned library");
|
||||
}
|
||||
dir
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user