fix: close the tail items from the targeted re-audit

Resolves the 13 rows still partial in docs/rewrite/notes/review-rv4-
codex.md (details in final-Z5.md):
- Escaped config strings are decoded to raw bytes at every OS boundary:
  Flatpak cwd/argv to D-Bus, screen-file paths, the default config
  template, GHOSTTY_RESOURCES_DIR/TERMINFO/shell integration/
  bindtextdomain consumers, custom shader loading, list-themes hyperlinks.
- osbytes escapes literal U+FDD0 on non-Unix too (bijective everywhere);
  the GTK paste dialog only decodes text that was actually encoded.
- shadertoy: whole-array uses of iChannelTime rebuild a plain float[4]
  from the std140-padded members (naga-validated, MSL offsets checked).
- libghostty-vt: the OSC parser holds caller-allocated storage inline
  and command payloads borrow from it, so ghostty_osc_end performs no
  global allocations (verified from Rust and C).
- crash: aarch64 Linux minidump context fixed; macOS fatal signals record
  siginfo, registers and a fault-safe stack walk.
- tripwire: selectionString map allocation-failure cleanup test ported.
- libghostty-vt emits the versioned soname libghostty-vt.so.0 at build
  time (no patchelf needed at install).

Test Plan:
- cargo test --workspace (3342 passed)
- just check-macos; just check-macos x86_64-apple-darwin;
  just check-windows; just check-wasm
- cargo check --target aarch64-unknown-linux-gnu -p ghostty-crash
This commit is contained in:
ddidderr committed 2026-10-12 08:45:21 +02:00
1 parent 5bfc7bd856
commit 1a13e8b556
49 files changed
+1785 -557

No files matched your search

+11 -1
View File
@@ -242,6 +242,9 @@ pub(crate) struct Crash<'a> {
pub value: &'a str,
/// Sentry mechanism type: `panic` or `signalhandler`.
pub mechanism: &'a str,
/// Signal info, registers and stack of the faulting thread (Darwin
/// signal path; see `native.rs`).
pub native: Option<&'a crate::native::Native>,
}
/// Write the event JSON (single line). Mirrors what Sentry produces after
@@ -281,7 +284,13 @@ pub(crate) fn write_event<W: fmt::Write>(w: &mut W, st: &State, c: &Crash<'_>) -
json_str(w, c.value)?;
w.write_str(",\"mechanism\":{\"type\":")?;
json_str(w, c.mechanism)?;
w.write_str(",\"handled\":false}}]}}")
w.write_str(",\"handled\":false")?;
if let Some(n) = c.native {
crate::native::write_mechanism_rest_and_stacktrace(w, n)?;
w.write_str("}]}}")
} else {
w.write_str("}}]}}")
}
}
/// Write the envelope header line and the event item header line (the event
@@ -362,6 +371,7 @@ fn write_report(
kind,
value,
mechanism,
native: None,
};
let mut event = String::new();