feat: honor async-backend with epoll/io_uring, fix last RV13 items

Resolves the 4 P3 items in docs/rewrite/notes/review-rv13-codex.md
(final-Z16.md):
- async-backend now takes effect like Ghostty: ghostty_os::xev ports
  libxev's backend detection (io_uring, then epoll); global init detects
  and logs it, the GTK startup applies the config with Zig's messages,
  and +version reports the real backend. The termio IO loop runs on a
  new reactor with epoll, io_uring (io-uring crate) and poll(2) (kept
  for macOS, where libxev uses kqueue). The 21 exec integration tests
  run under every backend; io_uring was exercised here.
- auto-update-channel defaults to the build's release channel.
- Windows error names: sharing violation -> AccessDenied, plus
  ERROR_FILE_EXISTS -> PathAlreadyExists and virus errors ->
  AntivirusInterference, mirroring std.os.windows.OpenFile's NTSTATUS
  mapping in Zig 0.15.2 (verified against its source by the
  orchestrator).
- Exact ports of std.fs.path.basenameWindows/basenamePosix for theme
  name validation (drive, UNC and device roots).

Test Plan:
- cargo test --workspace --no-fail-fast (3555 passed, exit 0)
- just check-macos (both), just check-windows, just check-wasm
- +show-config --default --docs vs /usr/bin/ghostty (only the
  build-specific gtk-opengl-debug line differs)
This commit is contained in:
ddidderr committed 2026-10-12 14:49:00 +02:00
1 parent 3ce3225642
commit 1bd918159a
18 files changed
+2012 -742

No files matched your search

+38 -1
View File
@@ -28,6 +28,14 @@ use crate::{
const NS_PER_S: u64 = 1_000_000_000;
const NS_PER_MS: u64 = 1_000_000;
/// `build_config.release_channel` as a config value.
fn build_release_channel() -> ReleaseChannel {
match ghostty_build_info::RELEASE_CHANNEL {
"tip" => ReleaseChannel::Tip,
_ => ReleaseChannel::Stable,
}
}
config_enum! {
/// The release channel of the build (Zig: `build_config.ReleaseChannel`).
pub enum ReleaseChannel {
@@ -4656,7 +4664,7 @@ impl Config {
// We can't set this as a struct default because our config is
// loaded in environments where a build config isn't available.
if self.auto_update_channel.is_none() {
self.auto_update_channel = Some(ReleaseChannel::Stable);
self.auto_update_channel = Some(build_release_channel());
}
self.faint_opacity = cli_args::zig_clamp(self.faint_opacity, 0.0, 1.0);
@@ -5027,6 +5035,35 @@ impl CliTarget for Config {
clippy::assert_is_empty
)]
mod tests {
#[test]
fn auto_update_channel_defaults_to_the_build_channel() {
let mut cfg = Config::default();
assert_eq!(cfg.auto_update_channel, None);
cfg.finalize().unwrap();
let expected = match ghostty_build_info::RELEASE_CHANNEL {
"tip" => ReleaseChannel::Tip,
"stable" => ReleaseChannel::Stable,
other => panic!("unexpected channel {other}"),
};
assert_eq!(cfg.auto_update_channel, Some(expected));
}
#[test]
fn auto_update_channel_explicit_value_is_kept() {
for (text, channel) in [
("stable", ReleaseChannel::Stable),
("tip", ReleaseChannel::Tip),
] {
let mut cfg = Config::default();
let data = format!("auto-update-channel = {text}\n");
let mut reader = std::io::Cursor::new(data.into_bytes());
cfg.load_reader(&mut reader, &EncodedOs::from_encoded("/c/config"))
.unwrap();
cfg.finalize().unwrap();
assert_eq!(cfg.auto_update_channel, Some(channel));
}
}
#[cfg(unix)]
#[test]
fn shell_from_env_round_trips_bytes() {