fix(build): avoid perpetually invalidating build script inputs

Repeated production builds recompiled build-info, GTK and their dependents
because build scripts watched missing optional files and generated outputs.
Watch packed-refs only when present and the prebuilt GTK bundle only when
consumed. Loose refs remain watched so packing them refreshes Git inputs.

Invoke glib-compile-resources directly instead of using a helper that also
watches generated XML and UI files. The existing resources directory watch
covers their source inputs. Remove the unused helper dependency and document
the build input rules.

Test Plan:
- Run cargo build --profile production three times; repeats compile nothing.
- Run cargo clippy, cargo clippy --benches and cargo clippy --tests.
- Run cargo +nightly fmt and repeat all three Clippy checks.

Documentation: docs/rewrite/ARCHITECTURE.md
This commit is contained in:
ddidderr committed 2026-10-12 22:29:05 +02:00
1 parent 7cec74e18b
commit 92f4f521ab
5 files changed
+39 -19

No files matched your search

-3
View File
@@ -46,9 +46,6 @@ dear-imgui-glow = "0.19"
glow = "0.18"
wayland-sys = { version = "0.31.11", features = ["client", "dlopen"] }
[build-dependencies]
glib-build-tools = "0.22"
[dev-dependencies]
env_logger = "0.11"
+22 -5
View File
@@ -73,9 +73,12 @@ fn main() {
// neither blueprint-compiler nor glib-compile-resources (Zig:
// `GhosttyDist.Resource` for `ghostty_resources.{c,h}`). As in Zig, it is
// never used in a git checkout.
println!("cargo:rerun-if-changed=dist/ghostty.gresource");
let prebuilt = manifest.join("dist/ghostty.gresource");
if prebuilt.is_file() && !manifest.join("../../.git").exists() {
// Watch the bundle only when it is an input. In a checkout it is
// normally absent, and watching a missing file forces every build
// to recompile the resources and all dependent crates.
println!("cargo:rerun-if-changed=dist/ghostty.gresource");
std::fs::copy(&prebuilt, out.join("ghostty.gresource")).unwrap();
return;
}
@@ -119,10 +122,24 @@ fn main() {
let xml_path = out.join("ghostty.gresource.xml");
std::fs::write(&xml_path, xml).unwrap();
glib_build_tools::compile_resources(
&[out.as_path(), res.as_path()],
xml_path.to_str().unwrap(),
"ghostty.gresource",
// glib-build-tools also watches the generated XML and UI files. Their
// timestamps change during this script, invalidating the next build.
// All actual inputs are already covered by the `resources` watch above.
let compiled = Command::new("glib-compile-resources")
.arg("--sourcedir")
.arg(&out)
.arg("--sourcedir")
.arg(&res)
.arg("--target")
.arg(out.join("ghostty.gresource"))
.arg(&xml_path)
.output()
.expect("`glib-compile-resources` is required to build ghostty-apprt-gtk");
assert!(
compiled.status.success(),
"glib-compile-resources failed with {}:\n{}",
compiled.status,
String::from_utf8_lossy(&compiled.stderr)
);
}