fix(config): match Zig's numeric grammar, NUL handling and diagnostics
Resolves the 6 differential gap groups in docs/rewrite/notes/review- rv9-codex.md (details in final-Z11.md): - ghostty_os::zig_fmt ports std.fmt.parseInt/parseUnsigned/parseFloat (underscores, 0x/0o/0b prefixes, hex floats, inf/nan) with the Zig std tests and replaces every int/float parse in config, keybind parameters, ssh-cache and desktop detection. - Interior NUL no longer panics in font names and ends C strings like Zig's backing bytes (fontconfig, C config getters, title actions, clipboard callback, relative paths, config-file, shaders, background image, GTK CSS). - GTK new-window arguments are trimmed of ASCII whitespace only. - Command tokenization uses a port of std.process.ArgIteratorGeneral (incl. CR/LF separators) with its std tests. - UTF-8 validation happens where Zig's field parsers do it, so error kinds match (metric modifiers, quick-terminal size, link, ...). A scripted differential run of 202 fields x ~220 hostile/valid values against /usr/bin/ghostty (+validate-config and +show-config: exit code, stdout, stderr) now has zero mismatches besides build-specific defaults (theme resources path, auto-update-channel, gtk-opengl-debug); it also surfaced and fixed background-blur failure state, NaN formatting and NaN/-0 finalize clamps. Regression tests: ghostty-config/tests/ zig_parity.rs. Test Plan: - cargo test --workspace --no-fail-fast (3456 passed, exit 0) - just check-macos (both), just check-windows, just check-wasm
This commit is contained in:
1 parent
61e7a680ac
commit
a57ff41d34
26 files changed
+1835
-228
No files matched your search
@@ -189,8 +189,10 @@ impl Pattern {
|
||||
self.add_string_bytes(prop, v.as_bytes())
|
||||
}
|
||||
|
||||
/// [`Pattern::add_string`] for arbitrary bytes (file names).
|
||||
/// [`Pattern::add_string`] for arbitrary bytes (file names). Like Zig's
|
||||
/// sentinel-terminated C string handoff, the value ends at the first NUL.
|
||||
pub fn add_string_bytes(&mut self, prop: Property, v: &[u8]) -> bool {
|
||||
let v = v.split(|&b| b == 0).next().unwrap_or(v);
|
||||
let Ok(c) = CString::new(v) else {
|
||||
return false;
|
||||
};
|
||||
|
||||
Reference in new issue
Block a user