fix: systematic byte fidelity for config strings and RV7 gaps
Resolves the 9 gap groups in docs/rewrite/notes/review-rv7-codex.md and
audits every string-typed config field against its consumers
(field -> consumers -> decode status table in final-Z9.md):
- Windows EnvMap keys use a port of Zig's nls.zig uppercase table
(upcaseW); Windows locale init follows Zig's chain (setlocale +
_putenv_s); malformed WTF-8 now fails process launch conversions like
Zig instead of substituting U+FFFD; kitty file paths convert WTF-8.
- bash --rcfile/--init-file, configured TERM and inherited GTK LANG
keep their original bytes.
- C API clipboard completion and ghostty_surface_binding_action take
bytes; complete_clipboard_request is byte-typed through the core.
- text:/csi:/esc: bindings, enquiry-response, input = path:, embedded
initial_input, search needles, titles, link regexes, clipboard
codepoint map, command palette text and GTK font/namespace values
decode the escape encoding before use.
Remaining by design: D-Bus a{ss} values and +new-window arguments are
UTF-8 by D-Bus type. C API key/preedit text follows separately.
Test Plan:
- cargo test --workspace
- just check-macos (both), just check-windows, just check-wasm
This commit is contained in:
1 parent
ffc91c31e4
commit
af094276f8
40 files changed
+986
-167
No files matched your search
@@ -87,11 +87,11 @@ pub struct WindowOverrides {
|
||||
|
||||
/// Set an environment variable.
|
||||
#[allow(unsafe_code)]
|
||||
fn set_env(key: &str, value: &str) {
|
||||
fn set_env(key: &str, value: impl AsRef<std::ffi::OsStr>) {
|
||||
// SAFETY: only called during application construction on the main
|
||||
// thread, before GTK is initialized and before we spawn any child
|
||||
// processes; no other thread in this crate reads the environment.
|
||||
unsafe { std::env::set_var(key, value) }
|
||||
unsafe { std::env::set_var(key, value.as_ref()) }
|
||||
}
|
||||
|
||||
/// Funnel GLib/GObject/GTK log messages into the `log` crate rather than
|
||||
@@ -284,7 +284,7 @@ mod imp {
|
||||
pub css: RefCell<Option<CssProviders>>,
|
||||
|
||||
/// Copy of the LANG variable provided by the system, if any.
|
||||
pub saved_language: RefCell<Option<String>>,
|
||||
pub saved_language: RefCell<Option<std::ffi::OsString>>,
|
||||
}
|
||||
|
||||
#[glib::object_subclass]
|
||||
@@ -398,9 +398,13 @@ impl Application {
|
||||
}
|
||||
};
|
||||
|
||||
let saved_language = std::env::var("LANG").ok();
|
||||
// Keep the inherited bytes: LANG need not be UTF-8.
|
||||
let saved_language = std::env::var_os("LANG");
|
||||
if let Some(language) = &config.language {
|
||||
set_env("LANG", language);
|
||||
set_env(
|
||||
"LANG",
|
||||
ghostty_os::osbytes::EncodedOs::from_encoded(language.clone()).to_os(),
|
||||
);
|
||||
}
|
||||
|
||||
// Set gettext global domain to be our app so that our unqualified
|
||||
@@ -560,7 +564,7 @@ impl Application {
|
||||
}
|
||||
|
||||
/// The original `LANG` Ghostty was launched with (None if unset).
|
||||
pub fn saved_language(&self) -> Option<String> {
|
||||
pub fn saved_language(&self) -> Option<std::ffi::OsString> {
|
||||
self.imp().saved_language.borrow().clone()
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user