fix: close remaining gaps found by the completeness audit
Addresses the partial ports listed in docs/rewrite/notes/review-completeness-codex.md (details in docs/rewrite/notes/gaps-X2.md): - Flatpak: the exit watcher no longer consumes the host command; a shared FlatpakSignalHandle lets closing a surface still SIGHUP the host process group. - Child environment is byte-preserving end to end (ghostty_os::EnvMap of OsStrings) and Snap paths are filtered like filterSnapPaths. - argv handling no longer panics on non-UTF-8 arguments. - URI percent-decoding keeps raw bytes; OSC 7 pwd is passed through without lossy conversion. - Keybinding comparison/hashing uses full Unicode case folding from a table generated from CaseFolding.txt (Unicode 17.0.0). - Link regexes set Oniguruma's whole-search retry limit through the new minimal ghostty-onig crate (one SAFETY-commented FFI call). - OSC 9 NUL-capacity check ordering matches Zig. - Wayland registry binds/clears globals advertised after startup. - Custom shaders may pass sampler2D to helper functions (naga adapter). - +list-themes preview renders OSC 8 links, styled underlines and follows color-scheme reports. Also includes the inspector's integration edits in shared files (renderer state hook, termio VT recording, core/apprt-gtk wiring), X1's config/input/cli additions for completion generation, and a fix for a race in the termio backpressure test (it wrote before `stty raw` applied, so the cooked line discipline dropped bytes past MAX_CANON). Test Plan: - cargo test --workspace - cargo clippy --workspace --all-targets -- -D warnings
This commit is contained in:
1 parent
90ad602969
commit
f4c020101c
61 files changed
+4210
-298
No files matched your search
@@ -112,6 +112,37 @@ impl Action {
|
||||
format!("cli/{}.zig", self.name().replace('-', "_"))
|
||||
}
|
||||
|
||||
/// The non-internal option fields of the action's `Options` struct with
|
||||
/// their type classification (Zig: `Action.options()` + `@typeInfo`).
|
||||
/// Used by the build-data generator for shell completions.
|
||||
#[must_use]
|
||||
pub fn option_fields(self) -> Vec<(&'static str, ghostty_config::cli_args::FieldKind)> {
|
||||
use ghostty_config::cli_args::FieldKind;
|
||||
use ghostty_config::macros::ConfigStruct;
|
||||
fn of<T: ConfigStruct>() -> Vec<(&'static str, FieldKind)> {
|
||||
T::FIELDS
|
||||
.iter()
|
||||
.filter(|f| !f.name.starts_with('_'))
|
||||
.map(|f| (f.name, f.kind))
|
||||
.collect()
|
||||
}
|
||||
match self {
|
||||
Action::Version | Action::EditConfig | Action::CrashReport | Action::Boo => Vec::new(),
|
||||
Action::Help => of::<crate::help::Options>(),
|
||||
Action::ListFonts => of::<crate::list_fonts::Options>(),
|
||||
Action::ListKeybinds => of::<crate::list_keybinds::Options>(),
|
||||
Action::ListThemes => of::<crate::list_themes::Options>(),
|
||||
Action::ListColors => of::<crate::list_colors::Options>(),
|
||||
Action::ListActions => of::<crate::list_actions::Options>(),
|
||||
Action::SshCache => of::<crate::ssh_cache::Options>(),
|
||||
Action::ShowConfig => of::<crate::show_config::Options>(),
|
||||
Action::ValidateConfig => of::<crate::validate_config::Options>(),
|
||||
Action::ShowFace => of::<crate::show_face::Options>(),
|
||||
// `class: ?[:0]const u8` (the other fields are internal).
|
||||
Action::NewWindow => vec![("class", FieldKind::OptionalOther)],
|
||||
}
|
||||
}
|
||||
|
||||
/// The help text of the action (the doc comment of the Zig `run`
|
||||
/// function, i.e. `help_strings.Action.<name>`), without trailing newline.
|
||||
#[must_use]
|
||||
|
||||
Reference in new issue
Block a user