Escaped config strings (ghostty_os::osbytes) kept reaching OS boundaries undecoded, and decoding was occasionally applied to plain text. The root cause was that both were plain `String`s. Now: - `EncodedOs` is a newtype (no Display/AsRef<Path>) that decodes only via to_os/to_path/to_bytes/to_wide; plain text enters via from_plain_text. OS helpers (env, home, xdg, passwd, resources dir, path expansion), config::Path, WorkingDirectory, theme/file_load/edit paths, terminal pwd, OpenUrl/Pwd actions and termio cwd use it, so the compiler forces decoding at every boundary. os::open takes &OsStr. Config output is unchanged. Fixes all rows of docs/rewrite/notes/review-rv5-codex.md (final-Z7.md): screen-file copy; regex/OSC 8 URLs no longer decoded (regression); lossless Windows WTF-8/WTF-16 for args, env and CreateProcessW; Windows resources dir/TERMINFO; color OSC request lists and X11 color lookup no longer allocate globally (C zero-allocation test extended); macOS Mach handler resumes all threads before KERN_FAILURE (hang regression) and SIGABRT minidumps go through the exception thread; plus open-config, background images, crash dir, ssh cache, exe dir/PATH, fontconfig filenames, file links, kitty TMPDIR, .hushlogin and benchmark paths. The typing also surfaced and fixed gtk-custom-css, bell audio, bash HISTFILE, OSC 52 writes and the C config getters. Test Plan: - cargo test --workspace (3376 passed) - just check-macos (both), just check-windows, just check-wasm - diff <(ghostty-rs +show-config --default --docs) \ <(ghostty +show-config --default --docs)
51 lines
1.5 KiB
Rust
51 lines
1.5 KiB
Rust
//! `ghostty-bench +<action> [--option=value ...]` (port of `main_bench.zig`).
|
|
use std::process::ExitCode;
|
|
|
|
use ghostty_bench::{args::Args, benches};
|
|
|
|
fn main() -> ExitCode {
|
|
let argv: Vec<std::ffi::OsString> = std::env::args_os().skip(1).collect();
|
|
let mut action = None;
|
|
for a in &argv {
|
|
if let Some(name) = ghostty_bench::args::action_name(a) {
|
|
if action.is_some() {
|
|
eprintln!("error: multiple actions specified");
|
|
return ExitCode::FAILURE;
|
|
}
|
|
action = Some(name);
|
|
}
|
|
}
|
|
let Some(action) = action else {
|
|
eprintln!(
|
|
"error: no action specified; available: {}",
|
|
benches::ACTIONS.join(", ")
|
|
);
|
|
return ExitCode::FAILURE;
|
|
};
|
|
let mut args = match Args::parse(argv) {
|
|
Ok(a) => a,
|
|
Err(e) => {
|
|
eprintln!("error: {e}");
|
|
return ExitCode::FAILURE;
|
|
}
|
|
};
|
|
// Rust-only convenience: print the measured step time to stderr.
|
|
let time = args.take_flag("time").unwrap_or(false);
|
|
match benches::main_action(&action, args) {
|
|
Ok(r) => {
|
|
if time {
|
|
eprintln!(
|
|
"iterations={} duration_ns={}",
|
|
r.iterations,
|
|
r.duration.as_nanos()
|
|
);
|
|
}
|
|
ExitCode::SUCCESS
|
|
}
|
|
Err(e) => {
|
|
eprintln!("error: {e}");
|
|
ExitCode::FAILURE
|
|
}
|
|
}
|
|
}
|