Files
ghostty-rs/crates/ghostty-crash/src/lib.rs
T
ddidderr 8f3e206d9f refactor: type escaped OS strings and fix the final audit findings
Escaped config strings (ghostty_os::osbytes) kept reaching OS
boundaries undecoded, and decoding was occasionally applied to plain
text. The root cause was that both were plain `String`s. Now:
- `EncodedOs` is a newtype (no Display/AsRef<Path>) that decodes only
  via to_os/to_path/to_bytes/to_wide; plain text enters via
  from_plain_text. OS helpers (env, home, xdg, passwd, resources dir,
  path expansion), config::Path, WorkingDirectory, theme/file_load/edit
  paths, terminal pwd, OpenUrl/Pwd actions and termio cwd use it, so the
  compiler forces decoding at every boundary. os::open takes &OsStr.
  Config output is unchanged.

Fixes all rows of docs/rewrite/notes/review-rv5-codex.md (final-Z7.md):
screen-file copy; regex/OSC 8 URLs no longer decoded (regression);
lossless Windows WTF-8/WTF-16 for args, env and CreateProcessW; Windows
resources dir/TERMINFO; color OSC request lists and X11 color lookup no
longer allocate globally (C zero-allocation test extended); macOS Mach
handler resumes all threads before KERN_FAILURE (hang regression) and
SIGABRT minidumps go through the exception thread; plus open-config,
background images, crash dir, ssh cache, exe dir/PATH, fontconfig
filenames, file links, kitty TMPDIR, .hushlogin and benchmark paths.
The typing also surfaced and fixed gtk-custom-css, bell audio, bash
HISTFILE, OSC 52 writes and the C config getters.

Test Plan:
- cargo test --workspace (3376 passed)
- just check-macos (both), just check-windows, just check-wasm
- diff <(ghostty-rs +show-config --default --docs) \
  <(ghostty +show-config --default --docs)
2026-10-12 10:06:07 +02:00

37 lines
1.1 KiB
Rust

//! Local crash handling (port of `ghostty/src/crash`).
//!
//! This covers setting up the process to catch crashes, writing crash
//! reports (Sentry envelopes) to disk, and introspecting them. Nothing is
//! ever sent over the network.
// The Windows exception filter does not use the signal-safe report writer,
// so parts of it are unused there.
#![cfg_attr(windows, allow(dead_code))]
pub mod context;
#[cfg(target_vendor = "apple")]
mod darwin;
pub mod dir;
pub mod envelope;
mod exception;
#[cfg(target_os = "macos")]
mod mach_handler;
#[cfg(target_os = "linux")]
mod minidump;
// Pure (platform independent) event-context formatting; only used by the
// Darwin signal path but unit-tested everywhere.
#[cfg_attr(not(target_vendor = "apple"), allow(dead_code))]
mod native;
pub mod sentry;
#[cfg(unix)]
mod signal;
#[cfg(windows)]
#[path = "signal_windows.rs"]
mod signal;
mod suspend;
pub use context::{DimsSnapshot, SurfaceDims, ThreadGuard, ThreadType, current_dims};
pub use dir::{Dir, Report, ReportIterator, default_dir};
pub use envelope::Envelope;
pub use sentry::{Options, deinit, init, install};