ddidderr
c5d2cf4a64
Completes the font engine port: - shaper/run.rs ports run.zig: the RunIterator over terminal rows that splits text runs at style/face boundaries, selection and cursor, handles graphemes and ligatures; Shaper::shape_run shapes a run. - shared_grid_set.rs ports SharedGridSet.zig: grids keyed by a config derived key, handed out as Arc<SharedGrid>. - Font-related types now have one canonical definition in ghostty-config (Variation, Descriptor, CodepointMap, metric modifiers, freetype load flags, synthetic style, shaping break) which the font crate re-exports. MetricModifier::apply_i32 now saturates to -i32::MAX like Zig. - The 23 terminal-driven harfbuzz shaper tests are ported, printing via Screen until Terminal lands. Test Plan: - cargo test -p ghostty-font (157 passed, 3 ignored - also skipped in Zig); Devanagari/Chakma/Bengali tests return early without system fonts - cargo test -p ghostty-config (255 passed)
1.8 KiB
1.8 KiB
Cross-crate integration TODOs
Collected from agent reports; resolve during integration phases.
- vt
osc/parsers/semantic_prompt.rs: local printf-q / percent decoders → share withghostty-os::string_encoding(vt can't depend on os; maybe move into vt and have os re-export). - os
locale::ensure_localeno-op → call setlocale from apprt-gtk (unsafe allowed) at startup, as Ghostty's global.zig does. - os
passwdFlatpak branch needs termio Pty. - os
open::OpenUrlKind→ replace with core apprt action type. - terminal crate: re-add deps on unicode/datastruct once those land.
- input: key_encode::Options / paste::Options from terminal modes (Zig
fromTerminal) — in terminal or core. - input:
binding::set::EntryFormattermust be implemented by config formatter. - config: clipboard_codepoint_map::Entry and CursorStyle are local copies → unify with terminal/formatter (font types are unified: canonical in ghostty-config, re-exported by ghostty-font).
- config: url::REGEX needs onig (lookbehind) in renderer/core link matching.
- config: theme::open needs resources dir from ghostty_os.
- NOTE: Ghostty 1.3.1 is installed at /usr/bin/ghostty — use it as reference oracle (e.g. +show-config, +list-actions, terminfo).
- termio: Pty closes slave on drop (Zig didn't) — verify Exec semantics; cgroup/rlimit/D-Bus scope wiring; local option stand-ins → config types.
- cli: wire list-fonts/show-face (font discovery) and new-window (GTK IPC); call build_info::set from root/apprt.
- input: ActionKey::docs() has extra trailing blank line for 4 actions (cli works around locally).
- vt: x11_color lacks name listing with original case (cli re-parses rgb.txt).
- apprt: Scrollbar/RendererHealth stand-ins → terminal/renderer types; core implements AppMailbox
.