diff --git a/FINDINGS.md b/FINDINGS.md index 1d2eb8b..6a22365 100644 --- a/FINDINGS.md +++ b/FINDINGS.md @@ -1,6 +1,20 @@ # Findings -No open pre-merge findings are currently tracked here. +## Open + +### `handleErrorEvent` still writes status fields directly + +`crates/lanspread-tauri-deno-ts/src/hooks/useGames.ts:80-89` — the error +handler writes `install_status`, `status_message`, `status_level`, and +`download_progress` from a lifecycle event, which is the same "two sources of +truth" pattern that commit `5df82aa` ("fix(ui): derive operation status from +snapshots") removed everywhere else. That commit explicitly carved out error +messages as a preserved side effect, so this is a documented exception rather +than a regression — but if we want strict snapshot-is-truth, the error handler +should stop writing status fields and let the next snapshot reconcile the card, +keeping only the error message overlay (which the snapshot does not carry). + +Not blocking. Captured here for a future cleanup pass. ## Claude Review Scope Triage