From 3f10f6885142624d574228dd613a4d475aa9f7e4 Mon Sep 17 00:00:00 2001
From: ddidderr <ddidderr@paul.network>
Date: Sun, 21 Dec 2025 13:17:50 +0100
Subject: [PATCH] fix: avoid 10s client dally delay by default

---
 crates/pfs-tftp-sync/src/client.rs | 5 ++++-
 src/bin/pfs-tftp-client.rs         | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/crates/pfs-tftp-sync/src/client.rs b/crates/pfs-tftp-sync/src/client.rs
index d9df3f4..cdd0baa 100644
--- a/crates/pfs-tftp-sync/src/client.rs
+++ b/crates/pfs-tftp-sync/src/client.rs
@@ -32,7 +32,10 @@ impl Default for ClientConfig {
             timeout,
             retries: 5,
             dally_timeout: timeout,
-            dally_retries: 2,
+            // RFC 1350, Section 6: The final ACK sender *may* terminate immediately, but
+            // "dallying is encouraged". For CLI UX, default to no dallying and allow
+            // opt-in via flags.
+            dally_retries: 0,
         }
     }
 }
diff --git a/src/bin/pfs-tftp-client.rs b/src/bin/pfs-tftp-client.rs
index 03cb3ed..125e120 100644
--- a/src/bin/pfs-tftp-client.rs
+++ b/src/bin/pfs-tftp-client.rs
@@ -138,7 +138,7 @@ OPTIONS:
     --timeout-ms <MILLIS>       Packet timeout (default: 5000)
     --retries <N>               Retransmit attempts (default: 5)
     --dally-timeout-ms <MILLIS> Wait time for duplicate final DATA (default: timeout)
-    --dally-retries <N>         Dally attempts (default: 2)
+    --dally-retries <N>         Dally attempts (default: 0)
     --help, -h                  Show this help
 "
     );