From 161fa6ae4a58b89945f428034849d04d6b3404d3 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Fri, 3 Apr 2020 12:23:57 +1100 Subject: [PATCH] Ban continue in a double-curly while loop --- lang/parse/parse.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lang/parse/parse.go b/lang/parse/parse.go index 994dd22d..4bf02fb9 100644 --- a/lang/parse/parse.go +++ b/lang/parse/parse.go @@ -816,7 +816,12 @@ func (p *parser) parseStatement1() (*a.Node, error) { return nil, fmt.Errorf(`parse: expected endwhile%s at %s:%d`, dotLabel, p.filename, p.line()) } - if doubleCurly && !a.Terminates(body) { + if !doubleCurly { + // No-op. + } else if n.HasContinue() { + return nil, fmt.Errorf(`parse: double {{ }} while loop has explicit continue at %s:%d`, + p.filename, p.line()) + } else if !a.Terminates(body) { return nil, fmt.Errorf(`parse: double {{ }} while loop doesn't terminate at %s:%d`, p.filename, p.line()) }