From 1765863601bfe4e180dfb9610d218c5f9c8a5750 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Thu, 18 Feb 2021 22:43:13 +1100 Subject: [PATCH] Optimize make_m128i_slice128 pointer arg --- internal/cgen/builtin.go | 33 ++++++++++++++++++++++---- release/c/wuffs-unsupported-snapshot.c | 4 ++-- 2 files changed, 31 insertions(+), 6 deletions(-) diff --git a/internal/cgen/builtin.go b/internal/cgen/builtin.go index dd8a322e..39c2f7fd 100644 --- a/internal/cgen/builtin.go +++ b/internal/cgen/builtin.go @@ -845,11 +845,14 @@ func (g *gen) writeBuiltinCPUArchX86(b *buffer, recv *a.Expr, method t.ID, args b.writes(", ") } b.printf("(%s)(", tName) - if err := g.writeExpr(b, o.Value(), false, depth); err != nil { - return err - } if ptr { - b.writes(".ptr") + if err := g.writeExprDotPtr(b, o.Value(), false, depth); err != nil { + return err + } + } else { + if err := g.writeExpr(b, o.Value(), false, depth); err != nil { + return err + } } b.writes(")") } @@ -859,6 +862,28 @@ func (g *gen) writeBuiltinCPUArchX86(b *buffer, recv *a.Expr, method t.ID, args return nil } +func (g *gen) writeExprDotPtr(b *buffer, n *a.Expr, sideEffectsOnly bool, depth uint32) error { + if n.Operator() == t.IDDotDot { + if err := g.writeExpr(b, n.LHS().AsExpr(), sideEffectsOnly, depth); err != nil { + return err + } + b.writes(".ptr") + if n.MHS() != nil { + b.writes(" + ") + if err := g.writeExpr(b, n.MHS().AsExpr(), sideEffectsOnly, depth); err != nil { + return err + } + } + return nil + } + + if err := g.writeExpr(b, n, sideEffectsOnly, depth); err != nil { + return err + } + b.writes(".ptr") + return nil +} + func (g *gen) writeBuiltinNumType(b *buffer, recv *a.Expr, method t.ID, args []*a.Node, depth uint32) error { switch method { case t.IDLowBits: diff --git a/release/c/wuffs-unsupported-snapshot.c b/release/c/wuffs-unsupported-snapshot.c index 98b42636..6c60a224 100644 --- a/release/c/wuffs-unsupported-snapshot.c +++ b/release/c/wuffs-unsupported-snapshot.c @@ -17976,8 +17976,8 @@ wuffs_adler32__hasher__up_x86_sse42( v_p.len = 32; uint8_t* i_end0_p = v_p.ptr + (((i_slice_p.len - (size_t)(v_p.ptr - i_slice_p.ptr)) / 32) * 32); while (v_p.ptr < i_end0_p) { - v_p__left = _mm_lddqu_si128((const __m128i*)(const void*)(wuffs_base__slice_u8__subslice_j(v_p, 16).ptr)); - v_p_right = _mm_lddqu_si128((const __m128i*)(const void*)(wuffs_base__slice_u8__subslice_ij(v_p, 16, 32).ptr)); + v_p__left = _mm_lddqu_si128((const __m128i*)(const void*)(v_p.ptr)); + v_p_right = _mm_lddqu_si128((const __m128i*)(const void*)(v_p.ptr + 16)); v_v2j = _mm_add_epi32(v_v2j, v_v1); v_v1 = _mm_add_epi32(v_v1, _mm_sad_epu8(v_p__left, v_zeroes)); v_v1 = _mm_add_epi32(v_v1, _mm_sad_epu8(v_p_right, v_zeroes));