From 176cdf752774b90f1d59475983e1e9973ff43e10 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Wed, 12 Apr 2023 13:24:11 +1000 Subject: [PATCH] test: fix gcc -Wmaybe-uninitialized false positive When running "gcc -O3 -Wall test/c/std/adler32.c", gcc 12.2.0 (but not gcc 10.2.1) would warn that adler32's "checksum.private_impl.f_started" may be used uninitialized. There is no warning without the "-O3". That warning is a false positive. f_started is always zero-initialized by wuffs_adler32__hasher__initialize (unless opted in to WUFFS_INITIALIZE__ALREADY_ZEROED, which the benchmarks do not). Also update test/c/std/crc32.c so that all of the base.hasher_u32 wuffs_bench_etc functions are consistent, even though gcc on crc32.c does not produce that same false positive warning. --- test/c/std/adler32.c | 2 +- test/c/std/crc32.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/c/std/adler32.c b/test/c/std/adler32.c index 663cc911..ba6e6e64 100644 --- a/test/c/std/adler32.c +++ b/test/c/std/adler32.c @@ -239,7 +239,7 @@ wuffs_bench_adler32(wuffs_base__io_buffer* dst, if (rlimit) { len = wuffs_base__u64__min(len, rlimit); } - wuffs_adler32__hasher checksum; + wuffs_adler32__hasher checksum = {0}; CHECK_STATUS("initialize", wuffs_adler32__hasher__initialize( &checksum, sizeof checksum, WUFFS_VERSION, wuffs_initialize_flags)); diff --git a/test/c/std/crc32.c b/test/c/std/crc32.c index d2fab749..65601a3c 100644 --- a/test/c/std/crc32.c +++ b/test/c/std/crc32.c @@ -276,7 +276,7 @@ wuffs_bench_crc32_ieee(wuffs_base__io_buffer* dst, if (rlimit) { len = wuffs_base__u64__min(len, rlimit); } - wuffs_crc32__ieee_hasher checksum; + wuffs_crc32__ieee_hasher checksum = {0}; CHECK_STATUS("initialize", wuffs_crc32__ieee_hasher__initialize( &checksum, sizeof checksum, WUFFS_VERSION, wuffs_initialize_flags));