Mark deflate's init_huff as merely !? not !??

This commit is contained in:
Nigel Tao committed 2018-11-24 16:41:45 +11:00
1 parent 88236105c9
commit 312cdc8a0a
4 files changed
+74 -139

No files matched your search

+2 -2
View File
@@ -346,9 +346,9 @@ func (g *gen) writeFuncImplEpilogue(b *buffer) error {
b.writes("if (wuffs_base__status__is_error(status)) { " +
"self->private_impl.magic = WUFFS_BASE__DISABLED; }\n")
}
b.writes("return status;\n\n")
b.writes("return status;\n")
} else if effect.Optional() {
// TODO.
b.writes("return NULL;\n")
} else if g.currFunk.astFunc.Out() == nil {
b.writes("return ((wuffs_base__empty_struct){});\n")
}
+12 -3
View File
@@ -158,13 +158,22 @@ func (g *gen) writeStatementExpr(b *buffer, n *a.Expr, depth uint32) error {
if err := g.writeSuspendibles(b, n, depth); err != nil {
return err
}
if n.Effect().RootCause() && n.Effect().Coroutine() {
return nil
checkStatus := false
if n.Effect().RootCause() {
if n.Effect().Coroutine() {
return nil
} else if n.Effect().Optional() {
b.writes("status = ")
checkStatus = true
}
}
if err := g.writeExpr(b, n, replaceCallSuspendibles, depth); err != nil {
return err
}
b.writes(";\n")
if checkStatus {
b.writes("if (status) { goto exit; }\n")
}
return nil
}
@@ -364,7 +373,7 @@ func (g *gen) writeStatementRet(b *buffer, n *a.Ret, depth uint32) error {
}
b.writes("return ")
if g.currFunk.astFunc.Out() == nil { // TODO: Out() can be nil if the func has ? effect.
if g.currFunk.astFunc.Out() == nil && !g.currFunk.astFunc.Effect().Optional() {
return fmt.Errorf("TODO: allow empty return type (when not suspendible)")
} else if err := g.writeExpr(b, retExpr, replaceCallSuspendibles, depth); err != nil {
return err