From 3d34f6abf1081c6e4b4daefccd16d209e3a900a9 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sat, 13 May 2017 10:48:10 +1000 Subject: [PATCH] Check the assert condition has boolean type. --- lang/check/type.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lang/check/type.go b/lang/check/type.go index b47bb346..27961917 100644 --- a/lang/check/type.go +++ b/lang/check/type.go @@ -47,10 +47,14 @@ func (c *typeChecker) checkStatement(n *a.Node) error { switch n.Kind() { case a.KAssert: o := n.Assert() - if err := c.checkExpr(o.Condition()); err != nil { + cond := o.Condition() + if err := c.checkExpr(cond); err != nil { return err } - // TODO: check that o.Condition() has type bool. + if !cond.MType().Eq(TypeExprBoolean) { + return fmt.Errorf("check: assert condition %q, of type %q, does not have a boolean type", + cond.String(c.idMap), cond.MType().String(c.idMap)) + } // TODO: check the actual assertion. return nil