diff --git a/lib/litonlylzma/litonlylzma.go b/lib/litonlylzma/litonlylzma.go index 5d3b40f9..d41badf2 100644 --- a/lib/litonlylzma/litonlylzma.go +++ b/lib/litonlylzma/litonlylzma.go @@ -26,7 +26,8 @@ // back-references. // // The main benefit, compared to full LZMA/Xz, is that this implementation is -// much simpler and hence easier to study. It is around 800 lines of code. +// much simpler and hence easier to study. It is around 800 lines of code, +// about a third of which are comments. // // Example compression numbers on a small English text file (at // https://github.com/google/wuffs/blob/main/test/data/romeo.txt): @@ -55,6 +56,9 @@ // linux-5.0.1.tar.xz file size above differs from what cdn.kernel.org served. package litonlylzma +// When editing this file, consider setting "allowTestsToExecOtherPrograms = +// true" in the test code. + import ( "errors" "hash/crc32" diff --git a/lib/litonlylzma/litonlylzma_test.go b/lib/litonlylzma/litonlylzma_test.go index ebca4ccc..cda64fdf 100644 --- a/lib/litonlylzma/litonlylzma_test.go +++ b/lib/litonlylzma/litonlylzma_test.go @@ -68,6 +68,14 @@ func TestRoundTripPiTxt(tt *testing.T) { testRoundTrip(tt, "pi.txt") func TestRoundTripRomeoTxt(tt *testing.T) { testRoundTrip(tt, "romeo.txt") } func TestUsrBinFoocatCompat(tt *testing.T) { + // Set "allowTestsToExecOtherPrograms = true" for more test coverage, + // checking compatibility with third-party decompression tools that are + // often available (at a well known location) on Linux. + const allowTestsToExecOtherPrograms = false + if !allowTestsToExecOtherPrograms { + tt.Skip("not configured to exec third-party programs") + } + testCases := [...]struct { fileFormat FileFormat command string