Add std/png decoder.filter_1_distance_4_arm_neon

On a Raspberry Pi 4 (32-bit armv7l) with -march=native and -mfpu=neon
("native" means "armv8-a+crc+simd"):

wuffs_png_decode_filt_1_dist_4/clang9                     1.09GB/s ± 1%  1.42GB/s ± 0%  +30.50%  (p=0.008 n=5+5)
wuffs_png_decode_filt_1_dist_4/gcc8                        859MB/s ± 0%   891MB/s ± 0%   +3.66%  (p=0.008 n=5+5)
This commit is contained in:
Nigel Tao committed 2021-02-14 21:43:56 +11:00
1 parent 84f3592dbe
commit 435330494e
10 files changed
+187 -3

No files matched your search

+48 -3
View File
@@ -523,13 +523,43 @@ func (g *gen) writeBuiltinCPUArch(b *buffer, recv *a.Expr, method t.ID, args []*
return nil
}
armCRC32U32 := recv.MType().Eq(typeExprARMCRC32U32)
armNeon := recv.MType().Eq(typeExprARMNeon64) || recv.MType().Eq(typeExprARMNeon128)
methodStr := method.Str(g.tm)
vreinterpretU8Uxx, vreinterpretUxxU8, vreinterpretClose := "", "", ""
if armNeon {
switch {
case strings.HasSuffix(methodStr, "_u16"):
vreinterpretU8Uxx = "vreinterpret_u8_u16("
vreinterpretUxxU8 = "vreinterpret_u16_u8("
vreinterpretClose = ")"
case strings.HasSuffix(methodStr, "_u32"):
vreinterpretU8Uxx = "vreinterpret_u8_u32("
vreinterpretUxxU8 = "vreinterpret_u32_u8("
vreinterpretClose = ")"
case strings.HasSuffix(methodStr, "_u64"):
vreinterpretU8Uxx = "vreinterpret_u8_u64("
vreinterpretUxxU8 = "vreinterpret_u64_u8("
vreinterpretClose = ")"
}
}
const create = "create"
if methodStr := method.Str(g.tm); methodStr == "value" {
if methodStr == "value" {
return g.writeExpr(b, recv, false, depth)
} else if methodStr == create {
return g.writeExpr(b, args[0].AsArg().Value(), false, depth)
} else if strings.HasPrefix(methodStr, create) {
b.printf("%s(", methodStr[len(create):])
methodStr = methodStr[len(create):]
if armNeon && (methodStr != "") && (methodStr[0] == '_') {
methodStr = methodStr[1:]
}
b.writes(vreinterpretU8Uxx)
b.printf("%s(", methodStr)
for i, o := range args {
if i > 0 {
b.writes(", ")
@@ -554,21 +584,35 @@ func (g *gen) writeBuiltinCPUArch(b *buffer, recv *a.Expr, method t.ID, args []*
}
b.writes(after)
}
b.writes(vreinterpretClose)
} else {
armCRC32U32 := recv.MType().Eq(typeExprARMCRC32U32)
if armCRC32U32 {
b.writeb('_')
}
b.printf("%s(", methodStr)
if armNeon && recv.MType().IsCPUArchType() {
b.writes(vreinterpretUxxU8)
}
if err := g.writeExpr(b, recv, false, depth); err != nil {
return err
}
if armNeon && recv.MType().IsCPUArchType() {
b.writes(vreinterpretClose)
}
for _, o := range args {
b.writes(", ")
after := ""
v := o.AsArg().Value()
if armCRC32U32 {
// No-op.
} else if armNeon {
if v.MType().IsCPUArchType() {
b.writes(vreinterpretUxxU8)
after = vreinterpretClose
}
} else if !v.MType().IsCPUArchType() {
b.writes("(int32_t)(")
after = ")"
@@ -579,6 +623,7 @@ func (g *gen) writeBuiltinCPUArch(b *buffer, recv *a.Expr, method t.ID, args []*
b.writes(after)
}
}
b.writes(")")
return nil
}
+2
View File
@@ -44,6 +44,8 @@ var (
maxInt64 = big.NewInt((1 << 63) - 1)
typeExprARMCRC32U32 = a.NewTypeExpr(0, t.IDBase, t.IDARMCRC32U32, nil, nil, nil)
typeExprARMNeon64 = a.NewTypeExpr(0, t.IDBase, t.IDARMNeon64, nil, nil, nil)
typeExprARMNeon128 = a.NewTypeExpr(0, t.IDBase, t.IDARMNeon128, nil, nil, nil)
typeExprPixelSwizzler = a.NewTypeExpr(0, t.IDBase, t.IDPixelSwizzler, nil, nil, nil)
typeExprUtility = a.NewTypeExpr(0, t.IDBase, t.IDUtility, nil, nil, nil)
)
+2
View File
@@ -578,6 +578,8 @@ var cTypeNames = [...]string{
t.IDTokenWriter: "wuffs_base__token_buffer*",
t.IDARMCRC32U32: "uint32_t",
t.IDARMNeon64: "uint8x8_t",
t.IDARMNeon128: "uint8x16_t",
t.IDX86M128I: "__m128i",
}