From 4615d0d670a898732c314eea2d0cedbe74d00dce Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sat, 6 May 2017 18:16:49 +1000 Subject: [PATCH] Test that Check assigns a type to every KExpr. --- lang/check/check_test.go | 42 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/lang/check/check_test.go b/lang/check/check_test.go index 0fb4f278..4955c7df 100644 --- a/lang/check/check_test.go +++ b/lang/check/check_test.go @@ -8,6 +8,7 @@ import ( "sort" "testing" + "github.com/google/puffs/lang/ast" "github.com/google/puffs/lang/parse" "github.com/google/puffs/lang/token" ) @@ -70,4 +71,45 @@ func TestCheck(t *testing.T) { if !reflect.DeepEqual(got, want) { t.Fatalf("\ngot %v\nwant %v", got, want) } + + walk(node, func(n *ast.Node) error { + if n.Kind == ast.KExpr && n.Type == nil { + t.Errorf("expression node has no type: n=%v", n) + } + return nil + }) +} + +func walk(n *ast.Node, f func(*ast.Node) error) error { + if n == nil { + return nil + } + if err := f(n); err != nil { + return err + } + if err := walk(n.LHS, f); err != nil { + return err + } + if err := walk(n.MHS, f); err != nil { + return err + } + if err := walk(n.RHS, f); err != nil { + return err + } + for _, c := range n.List0 { + if err := walk(c, f); err != nil { + return err + } + } + for _, c := range n.List1 { + if err := walk(c, f); err != nil { + return err + } + } + for _, c := range n.List2 { + if err := walk(c, f); err != nil { + return err + } + } + return nil }