From 56c27ed3c3d732cb14a62a131691d17c77dd178e Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sun, 13 May 2018 10:57:15 +1000 Subject: [PATCH] Always zero-init pointery-typed vars on resume --- cmd/wuffs-c/internal/cgen/var.go | 3 +-- gen/c/std/deflate.c | 1 + gen/c/std/gif.c | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/wuffs-c/internal/cgen/var.go b/cmd/wuffs-c/internal/cgen/var.go index 6bc0224a..f5ee025d 100644 --- a/cmd/wuffs-c/internal/cgen/var.go +++ b/cmd/wuffs-c/internal/cgen/var.go @@ -282,8 +282,7 @@ func (g *gen) writeResumeSuspend1(b *buffer, n *a.Var, suspend bool, initBoolTyp local := fmt.Sprintf("%s%s", vPrefix, n.Name().Str(g.tm)) if typ := n.XType(); typ.HasPointers() { - // TODO: drop the initBoolTypedVars. - if suspend || initBoolTypedVars { + if suspend { return nil } rhs := "" diff --git a/gen/c/std/deflate.c b/gen/c/std/deflate.c index 47c785b6..1e3e24a2 100644 --- a/gen/c/std/deflate.c +++ b/gen/c/std/deflate.c @@ -1839,6 +1839,7 @@ wuffs_deflate__status wuffs_deflate__decoder__decode( v_n_copied = self->private_impl.c_decode[0].v_n_copied; v_already_full = self->private_impl.c_decode[0].v_already_full; } else { + v_written = ((wuffs_base__slice_u8){}); } switch (coro_susp_point) { WUFFS_BASE__COROUTINE_SUSPENSION_POINT_0; diff --git a/gen/c/std/gif.c b/gen/c/std/gif.c index 152c570d..bc58a3d6 100644 --- a/gen/c/std/gif.c +++ b/gen/c/std/gif.c @@ -2686,6 +2686,7 @@ static wuffs_gif__status wuffs_gif__decoder__decode_id( v_w = ((wuffs_base__io_writer){}); v_z = self->private_impl.c_decode_id[0].v_z; } else { + v_w = ((wuffs_base__io_writer){}); } switch (coro_susp_point) { WUFFS_BASE__COROUTINE_SUSPENSION_POINT_0; @@ -3029,6 +3030,7 @@ static wuffs_gif__status wuffs_gif__lzw_decoder__decode( v_expansion = ((wuffs_base__slice_u8){}); v_n_copied = self->private_impl.c_decode[0].v_n_copied; } else { + v_expansion = ((wuffs_base__slice_u8){}); } switch (coro_susp_point) { WUFFS_BASE__COROUTINE_SUSPENSION_POINT_0;