From 57598bee4181d8212f31763f624446e4bb40854d Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sat, 13 May 2017 11:33:31 +1000 Subject: [PATCH] Check the if condition has boolean type. --- lang/check/type.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lang/check/type.go b/lang/check/type.go index 39db4ba6..153172ec 100644 --- a/lang/check/type.go +++ b/lang/check/type.go @@ -91,10 +91,14 @@ func (c *typeChecker) checkStatement(n *a.Node) error { case a.KIf: for o := n.If(); o != nil; o = o.ElseIf() { - if err := c.checkExpr(o.Condition()); err != nil { + cond := o.Condition() + if err := c.checkExpr(cond); err != nil { return err } - // TODO: check o.Condition() has type bool. + if !cond.MType().Eq(TypeExprBoolean) { + return fmt.Errorf("check: if condition %q, of type %q, does not have a boolean type", + cond.String(c.idMap), cond.MType().String(c.idMap)) + } for _, m := range o.BodyIfTrue() { if err := c.checkStatement(m); err != nil { return err