mirror of
https://github.com/ddidderr/wuffs.git
synced 2026-11-21 16:47:28 +01:00
cgen: generate 123u instead of 123 (for std/jpeg)
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59018
This commit is contained in:
1 parent
85b244aa49
commit
5ab65d0923
2 files changed
+80
-65
No files matched your search
+16
-1
@@ -31,8 +31,23 @@ func (g *gen) writeExpr(b *buffer, n *a.Expr, sideEffectsOnly bool, depth uint32
|
||||
if cv := n.ConstValue(); cv != nil {
|
||||
if typ := n.MType(); typ.IsNumTypeOrIdeal() {
|
||||
b.writes(cv.String())
|
||||
if cv.Cmp(maxInt64) > 0 {
|
||||
if cv.Sign() < 0 {
|
||||
// No-op.
|
||||
} else if cv.Cmp(maxInt64) > 0 {
|
||||
b.writeb('u')
|
||||
} else {
|
||||
// Appending a 'u' is currently targeted to only those
|
||||
// constants used by std/jpeg/decode_idct_default.wuffs
|
||||
//
|
||||
// TODO: don't be so shy about it. It's narrow for now, to make
|
||||
// only the smallest generated-code change that fixes
|
||||
// https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59018
|
||||
// but we should generate 123u instead of 123 more broadly.
|
||||
const minIncl = 0xFFFFADFD
|
||||
const maxIncl = 0xFFFFF384
|
||||
if i := cv.Int64(); (minIncl <= i) && (i <= maxIncl) {
|
||||
b.writeb('u')
|
||||
}
|
||||
}
|
||||
} else if typ.IsNullptr() {
|
||||
b.writes("NULL")
|
||||
|
||||
Reference in new issue
Block a user