From 5d51c6c42cbfbb7126c66c75c7ed09ead2eaa8ce Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Fri, 12 May 2017 15:32:49 +1000 Subject: [PATCH] Check "y = -y". --- lang/check/check_test.go | 3 +++ lang/check/type.go | 23 ++++++++++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lang/check/check_test.go b/lang/check/check_test.go index ee0240fa..12a4f850 100644 --- a/lang/check/check_test.go +++ b/lang/check/check_test.go @@ -21,7 +21,10 @@ func TestCheck(t *testing.T) { var y i32 = 2 var z u64[:123] var a [4]u8 + x = 0 + y = -y + y = x as i32 } ` diff --git a/lang/check/type.go b/lang/check/type.go index 0a4e37fd..e22daa2b 100644 --- a/lang/check/type.go +++ b/lang/check/type.go @@ -197,7 +197,28 @@ func (c *typeChecker) checkExprOther(n *a.Expr) error { } func (c *typeChecker) checkExprUnaryOp(n *a.Expr) error { - // TODO. + rhs := n.RHS().Expr() + if err := c.checkExpr(rhs); err != nil { + return err + } + rTyp := rhs.MType() + + switch n.ID0() { + case t.IDXUnaryPlus, t.IDXUnaryMinus: + if rTyp != DummyTypeIdealNumber && !rTyp.IsNumType() { + op := '+' + if n.ID0() == t.IDXUnaryMinus { + op = '-' + } + return fmt.Errorf("check: unary '%c': %q, of type %q, does not have a numeric type", + op, rhs.String(c.idMap), rTyp.String(c.idMap)) + } + n.SetMType(rTyp) + return nil + + case t.IDXUnaryNot: + // TODO: check for bool. + } return fmt.Errorf("check: unrecognized token.Key (0x%X) for checkExprUnaryOp", n.ID0().Key()) }