From 68acf24515e450359d622624fb7da9b536109312 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sun, 3 Oct 2021 13:59:09 +1100 Subject: [PATCH] Remove Makefiles They don't work for me (on Debian bullseye). For example, from the example/sdl-imageviewer directory: $ make g++ -lSDL2 -lSDL2_image sdl-imageviewer.cc -o sdl-imageviewer /usr/bin/ld: /tmp/cciX1mj2.o: in function `draw(SDL_Window*)': sdl-imageviewer.cc:(.text+0x36e44): undefined reference to `SDL_GetWindowSurface' /usr/bin/ld: sdl-imageviewer.cc:(.text+0x36e69): undefined reference to `SDL_CreateRenderer' /usr/bin/ld: sdl-imageviewer.cc:(.text+0x36e79): undefined reference to `SDL_RenderClear' etc collect2: error: ld returned 1 exit status make: *** [: sdl-imageviewer] Error 1 Swapping the g++ args around to g++ sdl-imageviewer.cc -lSDL2 -lSDL2_image -o sdl-imageviewer works, but the recommended approach is to use the existing top-level build-example.sh script instead. --- build-example.sh | 11 ++++++++--- example/imageviewer/Makefile | 8 -------- example/sdl-imageviewer/Makefile | 8 -------- 3 files changed, 8 insertions(+), 19 deletions(-) delete mode 100644 example/imageviewer/Makefile delete mode 100644 example/sdl-imageviewer/Makefile diff --git a/build-example.sh b/build-example.sh index 96c4a620..781e411b 100755 --- a/build-example.sh +++ b/build-example.sh @@ -42,18 +42,23 @@ for f in $sources; do if [ $f = imageviewer ]; then # example/imageviewer is unusual in that needs additional libraries. echo "Building gen/bin/example-$f" - $CXX -O3 example/$f/*.cc -lxcb -lxcb-image -o gen/bin/example-$f + $CXX -O3 example/$f/*.cc \ + -lxcb -lxcb-image -lxcb-render -lxcb-render-util \ + -o gen/bin/example-$f elif [ $f = "sdl-imageviewer" ]; then # example/sdl-imageviewer is unusual in that needs additional libraries. echo "Building gen/bin/example-$f" - $CXX -O3 example/$f/*.cc -lSDL2 -lSDL2_image -o gen/bin/example-$f + $CXX -O3 example/$f/*.cc \ + -lSDL2 -lSDL2_image \ + -o gen/bin/example-$f elif [ $f = "toy-genlib" ]; then # example/toy-genlib is unusual in that it uses separately compiled # libraries (built by "wuffs genlib", e.g. by running build-all.sh) instead # of directly #include'ing Wuffs' .c files. if [ -e gen/lib/c/$CC-static/libwuffs.a ]; then echo "Building gen/bin/example-$f" - $CC -O3 -static -I.. example/$f/*.c gen/lib/c/$CC-static/libwuffs.a -o gen/bin/example-$f + $CC -O3 -static -I.. example/$f/*.c gen/lib/c/$CC-static/libwuffs.a \ + -o gen/bin/example-$f else echo "Skipping gen/bin/example-$f; run \"wuffs genlib\" first" fi diff --git a/example/imageviewer/Makefile b/example/imageviewer/Makefile deleted file mode 100644 index ac9bb899..00000000 --- a/example/imageviewer/Makefile +++ /dev/null @@ -1,8 +0,0 @@ -SHELL = /bin/sh -LDFLAGS = -lxcb -lxcb-image -lxcb-render -lxcb-render-util - -all: imageviewer -clean: - rm -f imageviewer - -.PHONY: all clean diff --git a/example/sdl-imageviewer/Makefile b/example/sdl-imageviewer/Makefile deleted file mode 100644 index 124d5ece..00000000 --- a/example/sdl-imageviewer/Makefile +++ /dev/null @@ -1,8 +0,0 @@ -SHELL = /bin/sh -LDFLAGS = -lSDL2 -lSDL2_image - -all: sdl-imageviewer -clean: - rm -f sdl-imageviewer - -.PHONY: all clean