From 78c363719fcf40618ac70bb04a2e58117436c462 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sat, 11 Aug 2018 16:01:00 +1000 Subject: [PATCH] Simplify writeExprBinaryOp --- cmd/wuffs-c/internal/cgen/expr.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cmd/wuffs-c/internal/cgen/expr.go b/cmd/wuffs-c/internal/cgen/expr.go index 7435525d..303c26a4 100644 --- a/cmd/wuffs-c/internal/cgen/expr.go +++ b/cmd/wuffs-c/internal/cgen/expr.go @@ -237,14 +237,13 @@ func (g *gen) writeExprUnaryOp(b *buffer, n *a.Expr, rp replacementPolicy, depth } func (g *gen) writeExprBinaryOp(b *buffer, n *a.Expr, rp replacementPolicy, depth uint32) error { - opName, lhsExtra, rhsExtra := "", "", "" + opName, extra := "", "" op := n.Operator() switch op { case t.IDXBinaryEqEq, t.IDXBinaryNotEq: if lhs := n.LHS().AsExpr(); lhs.MType().IsStatus() { - lhsExtra = ".code" - rhsExtra = ".code" + extra = ".code" } case t.IDXBinaryTildeSatPlus, t.IDXBinaryTildeSatMinus: @@ -274,12 +273,12 @@ func (g *gen) writeExprBinaryOp(b *buffer, n *a.Expr, rp replacementPolicy, dept if err := g.writeExpr(b, n.LHS().AsExpr(), rp, depth); err != nil { return err } - b.writes(lhsExtra) + b.writes(extra) b.writes(opName) if err := g.writeExpr(b, n.RHS().AsExpr(), rp, depth); err != nil { return err } - b.writes(rhsExtra) + b.writes(extra) b.writeb(')') return nil }