From 7a0a345d41afff0298aaf83a02b1a0097481d609 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Wed, 26 Dec 2018 11:18:04 +1100 Subject: [PATCH] Ensure that assert's and args are effect-free --- lang/parse/parse.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lang/parse/parse.go b/lang/parse/parse.go index 4e3f44d2..12edb08b 100644 --- a/lang/parse/parse.go +++ b/lang/parse/parse.go @@ -523,6 +523,10 @@ func (p *parser) parseAssertNode() (*a.Node, error) { if err != nil { return nil, err } + if condition.Effect() != 0 { + return nil, fmt.Errorf(`parse: assert-condition %q is not effect-free at %s:%d`, + condition.Str(p.tm), p.filename, p.line()) + } reason, args := t.ID(0), []*a.Node(nil) if p.peek1() == t.IDVia { p.src = p.src[1:] @@ -891,6 +895,10 @@ func (p *parser) parseArgNode() (*a.Node, error) { if err != nil { return nil, err } + if value.Effect() != 0 { + return nil, fmt.Errorf(`parse: arg-value %q is not effect-free at %s:%d`, + value.Str(p.tm), p.filename, p.line()) + } return a.NewArg(name, value).AsNode(), nil }