From 7bbd39af69c7a837694c9bd982915c9e3e4be763 Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sun, 2 Jul 2017 16:14:31 +1000 Subject: [PATCH] Have writeCtorSignature return an error. It's redundant, but consistent with all of the other writeXxx methods. --- cmd/puffs-gen-c/main.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cmd/puffs-gen-c/main.go b/cmd/puffs-gen-c/main.go index 3671ee84..b778b161 100644 --- a/cmd/puffs-gen-c/main.go +++ b/cmd/puffs-gen-c/main.go @@ -446,7 +446,7 @@ func (g *gen) writeStruct(n *a.Struct) error { return nil } -func (g *gen) writeCtorSignature(n *a.Struct, public bool, ctor bool) { +func (g *gen) writeCtorSignature(n *a.Struct, public bool, ctor bool) error { structName := n.Name().String(g.tm) ctorName := "destructor" if ctor { @@ -465,6 +465,7 @@ func (g *gen) writeCtorSignature(n *a.Struct, public bool, ctor bool) { g.printf(", uint32_t puffs_version, uint32_t for_internal_use_only") } g.printf(")") + return nil } func (g *gen) writeCtorPrototype(n *a.Struct) error { @@ -472,7 +473,9 @@ func (g *gen) writeCtorPrototype(n *a.Struct) error { return nil } for _, ctor := range []bool{true, false} { - g.writeCtorSignature(n, n.Public(), ctor) + if err := g.writeCtorSignature(n, n.Public(), ctor); err != nil { + return err + } g.writes(";\n\n") } return nil @@ -483,7 +486,9 @@ func (g *gen) writeCtorImpl(n *a.Struct) error { return nil } for _, ctor := range []bool{true, false} { - g.writeCtorSignature(n, false, ctor) + if err := g.writeCtorSignature(n, false, ctor); err != nil { + return err + } g.printf("{\n") g.printf("if (!self) { return; }\n")