From 81eecf29363eef913f4a901cd51dc9c76b4ba89b Mon Sep 17 00:00:00 2001 From: Nigel Tao Date: Sat, 4 Aug 2018 09:01:28 +1000 Subject: [PATCH] Require the assignment LHS to be effect-free --- lang/parse/parse.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lang/parse/parse.go b/lang/parse/parse.go index 922dd7d4..04819bc0 100644 --- a/lang/parse/parse.go +++ b/lang/parse/parse.go @@ -682,6 +682,10 @@ func (p *parser) parseStatement1() (*a.Node, error) { if err != nil { return nil, err } + if lhs.Effect() != 0 { + return nil, fmt.Errorf(`parse: assignment LHS %q is not effect-free at %s:%d`, + lhs.Str(p.tm), p.filename, p.line()) + } return a.NewAssign(op, lhs, rhs).AsNode(), nil }