mirror of
https://github.com/ddidderr/wuffs.git
synced 2026-11-22 16:47:28 +01:00
Re-order some switch cases for consistency.
This commit is contained in:
1 parent
5d0b664ccf
commit
adf69e114a
2 files changed
+44
-44
No files matched your search
+35
-35
@@ -50,6 +50,41 @@ func (q *checker) tcheckStatement(n *a.Node) error {
|
||||
return err
|
||||
}
|
||||
|
||||
case a.KIf:
|
||||
for n := n.If(); n != nil; n = n.ElseIf() {
|
||||
cond := n.Condition()
|
||||
if err := q.tcheckExpr(cond, 0); err != nil {
|
||||
return err
|
||||
}
|
||||
if !cond.MType().Eq(TypeExprBoolean) {
|
||||
return fmt.Errorf("check: if condition %q, of type %q, does not have a boolean type",
|
||||
cond.String(q.idMap), cond.MType().String(q.idMap))
|
||||
}
|
||||
for _, o := range n.BodyIfTrue() {
|
||||
if err := q.tcheckStatement(o); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
for _, o := range n.BodyIfFalse() {
|
||||
if err := q.tcheckStatement(o); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
case a.KJump:
|
||||
// TODO: check that we're in a for loop.
|
||||
|
||||
case a.KReturn:
|
||||
n := n.Return()
|
||||
if value := n.Value(); value != nil {
|
||||
if err := q.tcheckExpr(value, 0); err != nil {
|
||||
return err
|
||||
}
|
||||
// TODO: type-check that value is assignable to the return value.
|
||||
// This needs the context of what func we're in.
|
||||
}
|
||||
|
||||
case a.KVar:
|
||||
n := n.Var()
|
||||
if !n.XType().Node().TypeChecked() {
|
||||
@@ -84,41 +119,6 @@ func (q *checker) tcheckStatement(n *a.Node) error {
|
||||
}
|
||||
}
|
||||
|
||||
case a.KIf:
|
||||
for n := n.If(); n != nil; n = n.ElseIf() {
|
||||
cond := n.Condition()
|
||||
if err := q.tcheckExpr(cond, 0); err != nil {
|
||||
return err
|
||||
}
|
||||
if !cond.MType().Eq(TypeExprBoolean) {
|
||||
return fmt.Errorf("check: if condition %q, of type %q, does not have a boolean type",
|
||||
cond.String(q.idMap), cond.MType().String(q.idMap))
|
||||
}
|
||||
for _, o := range n.BodyIfTrue() {
|
||||
if err := q.tcheckStatement(o); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
for _, o := range n.BodyIfFalse() {
|
||||
if err := q.tcheckStatement(o); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
case a.KReturn:
|
||||
n := n.Return()
|
||||
if value := n.Value(); value != nil {
|
||||
if err := q.tcheckExpr(value, 0); err != nil {
|
||||
return err
|
||||
}
|
||||
// TODO: type-check that value is assignable to the return value.
|
||||
// This needs the context of what func we're in.
|
||||
}
|
||||
|
||||
case a.KJump:
|
||||
// TODO: check that we're in a for loop.
|
||||
|
||||
default:
|
||||
return fmt.Errorf("check: unrecognized ast.Kind (%s) for checkStatement", n.Kind())
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user