Re-introduce puffs_base__limit1.

It's not immediately obvious why this data structure performs differently, but
on net, the benchmark numbers seem better. It also won't require any
PUFFS_USE_NO_OP_PERFORMANCE_HACKS or "redundant but mysteriously performant"
use_limit fields.

name                             old speed      new speed      delta

puffs_adler32_10k/clang          2.46GB/s ± 0%  2.43GB/s ± 3%     ~     (p=0.513 n=5+10)
puffs_adler32_100k/clang         2.46GB/s ± 0%  2.44GB/s ± 2%     ~     (p=0.241 n=5+10)
puffs_flate_decode_1k/clang       122MB/s ± 1%   119MB/s ± 2%   -1.86%  (p=0.013 n=5+10)
puffs_flate_decode_10k/clang      147MB/s ± 0%   142MB/s ± 2%   -3.47%  (p=0.001 n=5+10)
puffs_flate_decode_100k/clang     161MB/s ± 0%   161MB/s ± 4%     ~     (p=0.635 n=4+10)
puffs_zlib_decode_10k/clang       139MB/s ± 0%   135MB/s ± 1%   -2.69%  (p=0.001 n=5+10)
puffs_zlib_decode_100k/clang      151MB/s ± 0%   152MB/s ± 3%     ~     (p=1.000 n=5+10)

puffs_adler32_10k/gcc            3.21GB/s ± 1%  3.18GB/s ± 2%     ~     (p=0.310 n=5+10)
puffs_adler32_100k/gcc           3.22GB/s ± 0%  3.19GB/s ± 2%     ~     (p=0.075 n=5+10)
puffs_flate_decode_1k/gcc         121MB/s ± 4%   126MB/s ± 1%   +4.54%  (p=0.002 n=5+8)
puffs_flate_decode_10k/gcc        144MB/s ± 1%   141MB/s ± 1%   -2.52%  (p=0.001 n=5+9)
puffs_flate_decode_100k/gcc       154MB/s ± 1%   158MB/s ± 0%   +2.39%  (p=0.001 n=5+9)
puffs_zlib_decode_10k/gcc         137MB/s ± 2%   135MB/s ± 1%     ~     (p=0.055 n=5+10)
puffs_zlib_decode_100k/gcc        146MB/s ± 2%   150MB/s ± 0%   +2.87%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/clang    132MB/s ± 0%   125MB/s ± 0%   -5.24%  (p=0.001 n=5+10)
puffs_gif_lzw_decode_100k/clang   176MB/s ± 0%   164MB/s ± 0%   -6.82%  (p=0.001 n=5+9)
puffs_gif_decode_1k/clang         363MB/s ± 0%   339MB/s ± 1%   -6.58%  (p=0.002 n=4+10)
puffs_gif_decode_10k/clang        138MB/s ± 0%   133MB/s ± 1%   -3.77%  (p=0.001 n=5+10)
puffs_gif_decode_100k/clang       125MB/s ± 0%   119MB/s ± 0%   -4.79%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/clang      127MB/s ± 0%   121MB/s ± 0%   -5.04%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/gcc      141MB/s ± 0%   140MB/s ± 2%     ~     (p=1.000 n=5+10)
puffs_gif_lzw_decode_100k/gcc     182MB/s ± 0%   180MB/s ± 2%   -1.56%  (p=0.001 n=5+10)
puffs_gif_decode_1k/gcc           363MB/s ± 0%   409MB/s ± 3%  +12.71%  (p=0.001 n=5+10)
puffs_gif_decode_10k/gcc          127MB/s ± 0%   161MB/s ± 3%  +26.15%  (p=0.001 n=5+10)
puffs_gif_decode_100k/gcc         112MB/s ± 0%   136MB/s ± 2%  +21.95%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/gcc        114MB/s ± 0%   140MB/s ± 2%  +22.78%  (p=0.001 n=5+10)
This commit is contained in:
Nigel Tao committed 2017-11-03 10:09:57 +11:00
1 parent 4158d7eae7
commit e3822f9951
14 files changed
+444 -258

No files matched your search

+13 -10
View File
@@ -79,6 +79,17 @@ typedef struct {
bool closed; // No further writes are expected.
} puffs_base__buf1;
// puffs_base__limit1 provides a limited view of a 1-dimensional byte stream:
// its first N bytes. That N can be greater than a buffer's current read or
// write capacity. N decreases naturally over time as bytes are read from or
// written to the stream.
//
// A value with all fields NULL or zero is a valid, unlimited view.
typedef struct puffs_base__limit1 {
uint64_t* ptr_to_len; // Pointer to N.
struct puffs_base__limit1* next; // Linked list of limits.
} puffs_base__limit1;
#ifdef PUFFS_USE_NO_OP_PERFORMANCE_HACKS
typedef struct {
void* always_null0;
@@ -94,12 +105,8 @@ typedef struct {
// Do not access the private_impl's fields directly. There is no API/ABI
// compatibility or safety guarantee if you do so.
struct {
uint8_t* limit;
puffs_base__limit1 limit;
uint8_t* mark;
// use_limit is redundant, in that it always equals (limit != NULL), but
// having a separate bool can have a significant performance effect with
// gcc 4.8.4 (e.g. 1.1x on some benchmarks).
bool use_limit;
#ifdef PUFFS_USE_NO_OP_PERFORMANCE_HACKS
struct {
puffs_base__paired_nulls* noph0;
@@ -117,12 +124,8 @@ typedef struct {
// Do not access the private_impl's fields directly. There is no API/ABI
// compatibility or safety guarantee if you do so.
struct {
uint8_t* limit;
puffs_base__limit1 limit;
uint8_t* mark;
// use_limit is redundant, in that it always equals (limit != NULL), but
// having a separate bool can have a significant performance effect with
// gcc 4.8.4 (e.g. 1.1x on some benchmarks).
bool use_limit;
} private_impl;
} puffs_base__writer1;
+13 -10
View File
@@ -79,6 +79,17 @@ typedef struct {
bool closed; // No further writes are expected.
} puffs_base__buf1;
// puffs_base__limit1 provides a limited view of a 1-dimensional byte stream:
// its first N bytes. That N can be greater than a buffer's current read or
// write capacity. N decreases naturally over time as bytes are read from or
// written to the stream.
//
// A value with all fields NULL or zero is a valid, unlimited view.
typedef struct puffs_base__limit1 {
uint64_t* ptr_to_len; // Pointer to N.
struct puffs_base__limit1* next; // Linked list of limits.
} puffs_base__limit1;
#ifdef PUFFS_USE_NO_OP_PERFORMANCE_HACKS
typedef struct {
void* always_null0;
@@ -94,12 +105,8 @@ typedef struct {
// Do not access the private_impl's fields directly. There is no API/ABI
// compatibility or safety guarantee if you do so.
struct {
uint8_t* limit;
puffs_base__limit1 limit;
uint8_t* mark;
// use_limit is redundant, in that it always equals (limit != NULL), but
// having a separate bool can have a significant performance effect with
// gcc 4.8.4 (e.g. 1.1x on some benchmarks).
bool use_limit;
#ifdef PUFFS_USE_NO_OP_PERFORMANCE_HACKS
struct {
puffs_base__paired_nulls* noph0;
@@ -117,12 +124,8 @@ typedef struct {
// Do not access the private_impl's fields directly. There is no API/ABI
// compatibility or safety guarantee if you do so.
struct {
uint8_t* limit;
puffs_base__limit1 limit;
uint8_t* mark;
// use_limit is redundant, in that it always equals (limit != NULL), but
// having a separate bool can have a significant performance effect with
// gcc 4.8.4 (e.g. 1.1x on some benchmarks).
bool use_limit;
} private_impl;
} puffs_base__writer1;