Re-introduce puffs_base__limit1.

It's not immediately obvious why this data structure performs differently, but
on net, the benchmark numbers seem better. It also won't require any
PUFFS_USE_NO_OP_PERFORMANCE_HACKS or "redundant but mysteriously performant"
use_limit fields.

name                             old speed      new speed      delta

puffs_adler32_10k/clang          2.46GB/s ± 0%  2.43GB/s ± 3%     ~     (p=0.513 n=5+10)
puffs_adler32_100k/clang         2.46GB/s ± 0%  2.44GB/s ± 2%     ~     (p=0.241 n=5+10)
puffs_flate_decode_1k/clang       122MB/s ± 1%   119MB/s ± 2%   -1.86%  (p=0.013 n=5+10)
puffs_flate_decode_10k/clang      147MB/s ± 0%   142MB/s ± 2%   -3.47%  (p=0.001 n=5+10)
puffs_flate_decode_100k/clang     161MB/s ± 0%   161MB/s ± 4%     ~     (p=0.635 n=4+10)
puffs_zlib_decode_10k/clang       139MB/s ± 0%   135MB/s ± 1%   -2.69%  (p=0.001 n=5+10)
puffs_zlib_decode_100k/clang      151MB/s ± 0%   152MB/s ± 3%     ~     (p=1.000 n=5+10)

puffs_adler32_10k/gcc            3.21GB/s ± 1%  3.18GB/s ± 2%     ~     (p=0.310 n=5+10)
puffs_adler32_100k/gcc           3.22GB/s ± 0%  3.19GB/s ± 2%     ~     (p=0.075 n=5+10)
puffs_flate_decode_1k/gcc         121MB/s ± 4%   126MB/s ± 1%   +4.54%  (p=0.002 n=5+8)
puffs_flate_decode_10k/gcc        144MB/s ± 1%   141MB/s ± 1%   -2.52%  (p=0.001 n=5+9)
puffs_flate_decode_100k/gcc       154MB/s ± 1%   158MB/s ± 0%   +2.39%  (p=0.001 n=5+9)
puffs_zlib_decode_10k/gcc         137MB/s ± 2%   135MB/s ± 1%     ~     (p=0.055 n=5+10)
puffs_zlib_decode_100k/gcc        146MB/s ± 2%   150MB/s ± 0%   +2.87%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/clang    132MB/s ± 0%   125MB/s ± 0%   -5.24%  (p=0.001 n=5+10)
puffs_gif_lzw_decode_100k/clang   176MB/s ± 0%   164MB/s ± 0%   -6.82%  (p=0.001 n=5+9)
puffs_gif_decode_1k/clang         363MB/s ± 0%   339MB/s ± 1%   -6.58%  (p=0.002 n=4+10)
puffs_gif_decode_10k/clang        138MB/s ± 0%   133MB/s ± 1%   -3.77%  (p=0.001 n=5+10)
puffs_gif_decode_100k/clang       125MB/s ± 0%   119MB/s ± 0%   -4.79%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/clang      127MB/s ± 0%   121MB/s ± 0%   -5.04%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/gcc      141MB/s ± 0%   140MB/s ± 2%     ~     (p=1.000 n=5+10)
puffs_gif_lzw_decode_100k/gcc     182MB/s ± 0%   180MB/s ± 2%   -1.56%  (p=0.001 n=5+10)
puffs_gif_decode_1k/gcc           363MB/s ± 0%   409MB/s ± 3%  +12.71%  (p=0.001 n=5+10)
puffs_gif_decode_10k/gcc          127MB/s ± 0%   161MB/s ± 3%  +26.15%  (p=0.001 n=5+10)
puffs_gif_decode_100k/gcc         112MB/s ± 0%   136MB/s ± 2%  +21.95%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/gcc        114MB/s ± 0%   140MB/s ± 2%  +22.78%  (p=0.001 n=5+10)
This commit is contained in:
Nigel Tao committed 2017-11-03 10:09:57 +11:00
1 parent 4158d7eae7
commit e3822f9951
14 files changed
+444 -258

No files matched your search

+13 -5
View File
@@ -189,14 +189,18 @@ const char* puffs_flate_decode(puffs_base__buf1* dst,
uint64_t rlimit) {
puffs_flate__flate_decoder dec;
puffs_flate__flate_decoder__initialize(&dec, PUFFS_VERSION, 0);
uint64_t wlim = 0;
uint64_t rlim = 0;
while (true) {
puffs_base__writer1 dst_writer = {.buf = dst};
if (wlimit) {
puffs_base__writer1__limit(&dst_writer, dst->ptr + dst->wi, wlimit);
wlim = wlimit;
dst_writer.private_impl.limit.ptr_to_len = &wlim;
}
puffs_base__reader1 src_reader = {.buf = src};
if (rlimit) {
puffs_base__reader1__limit(&src_reader, src->ptr + src->ri, rlimit);
rlim = rlimit;
src_reader.private_impl.limit.ptr_to_len = &rlim;
}
puffs_flate__status s =
@@ -220,14 +224,18 @@ const char* puffs_zlib_decode(puffs_base__buf1* dst,
puffs_flate__zlib_decoder dec;
puffs_flate__zlib_decoder__initialize(&dec, PUFFS_VERSION, 0);
uint64_t wlim = 0;
uint64_t rlim = 0;
while (true) {
puffs_base__writer1 dst_writer = {.buf = dst};
if (wlimit) {
puffs_base__writer1__limit(&dst_writer, dst->ptr + dst->wi, wlimit);
wlim = wlimit;
dst_writer.private_impl.limit.ptr_to_len = &wlim;
}
puffs_base__reader1 src_reader = {.buf = src};
if (rlimit) {
puffs_base__reader1__limit(&src_reader, src->ptr + src->ri, rlimit);
rlim = rlimit;
src_reader.private_impl.limit.ptr_to_len = &rlim;
}
puffs_flate__status s =
@@ -373,7 +381,7 @@ bool do_test_puffs_flate_history(int i,
dec->private_impl.f_history_index = starting_history_index;
puffs_base__writer1__limit(&dst_writer, got->ptr + got->wi, limit);
dst_writer.private_impl.limit.ptr_to_len = &limit;
puffs_flate__status got_s =
puffs_flate__flate_decoder__decode(dec, dst_writer, src_reader);
+12 -4
View File
@@ -230,15 +230,19 @@ bool do_test_puffs_gif_lzw_decode(const char* src_filename,
puffs_gif__lzw_decoder__initialize(&dec, PUFFS_VERSION, 0);
puffs_gif__lzw_decoder__set_literal_width(&dec, literal_width);
int num_iters = 0;
uint64_t wlim = 0;
uint64_t rlim = 0;
while (true) {
num_iters++;
puffs_base__writer1 got_writer = {.buf = &got};
if (wlimit) {
puffs_base__writer1__limit(&got_writer, got.ptr + got.wi, wlimit);
wlim = wlimit;
got_writer.private_impl.limit.ptr_to_len = &wlim;
}
puffs_base__reader1 src_reader = {.buf = &src};
if (rlimit) {
puffs_base__reader1__limit(&src_reader, src.ptr + src.ri, rlimit);
rlim = rlimit;
src_reader.private_impl.limit.ptr_to_len = &rlim;
}
size_t old_wi = got.wi;
size_t old_ri = src.ri;
@@ -409,15 +413,19 @@ bool do_test_puffs_gif_decode(const char* filename,
puffs_gif__decoder dec;
puffs_gif__decoder__initialize(&dec, PUFFS_VERSION, 0);
int num_iters = 0;
uint64_t wlim = 0;
uint64_t rlim = 0;
while (true) {
num_iters++;
puffs_base__writer1 got_writer = {.buf = &got};
if (wlimit) {
puffs_base__writer1__limit(&got_writer, got.ptr + got.wi, wlimit);
wlim = wlimit;
got_writer.private_impl.limit.ptr_to_len = &wlim;
}
puffs_base__reader1 src_reader = {.buf = &src};
if (rlimit) {
puffs_base__reader1__limit(&src_reader, src.ptr + src.ri, rlimit);
rlim = rlimit;
src_reader.private_impl.limit.ptr_to_len = &rlim;
}
size_t old_wi = got.wi;
size_t old_ri = src.ri;