mirror of
https://github.com/ddidderr/wuffs.git
synced 2026-11-21 16:47:28 +01:00
cgen: emit "break/continue" not "goto", part 1
name old speed new speed delta wuffs_jpeg_decode_19k_8bpp/clang11 229MB/s ± 0% 241MB/s ± 0% +5.29% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_progressive/clang11 205MB/s ± 0% 213MB/s ± 0% +3.89% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_sequential/clang11 375MB/s ± 0% 386MB/s ± 0% +3.01% (p=0.008 n=5+5) wuffs_jpeg_decode_77k_24bpp/clang11 326MB/s ± 0% 341MB/s ± 0% +4.80% (p=0.008 n=5+5) wuffs_jpeg_decode_552k_24bpp_420/clang11 339MB/s ± 0% 356MB/s ± 0% +5.14% (p=0.008 n=5+5) wuffs_jpeg_decode_552k_24bpp_444/clang11 475MB/s ± 0% 484MB/s ± 0% +2.04% (p=0.008 n=5+5) wuffs_jpeg_decode_4002k_24bpp/clang11 343MB/s ± 0% 362MB/s ± 0% +5.77% (p=0.008 n=5+5) wuffs_jpeg_decode_19k_8bpp/gcc10 245MB/s ± 0% 245MB/s ± 0% -0.07% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 254MB/s ± 0% 252MB/s ± 0% -0.52% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 514MB/s ± 0% 513MB/s ± 0% ~ (p=0.151 n=5+5) wuffs_jpeg_decode_77k_24bpp/gcc10 434MB/s ± 0% 433MB/s ± 0% -0.35% (p=0.016 n=5+4) wuffs_jpeg_decode_552k_24bpp_420/gcc10 459MB/s ± 0% 458MB/s ± 0% -0.12% (p=0.016 n=5+4) wuffs_jpeg_decode_552k_24bpp_444/gcc10 486MB/s ± 0% 486MB/s ± 0% -0.03% (p=0.008 n=5+5) wuffs_jpeg_decode_4002k_24bpp/gcc10 467MB/s ± 0% 465MB/s ± 0% -0.26% (p=0.016 n=5+4)
This commit is contained in:
1 parent
8d9d6c1292
commit
f155db4d5c
5 files changed
+75
-32
No files matched your search
@@ -39,6 +39,7 @@ type funk struct {
|
||||
varResumables map[t.ID]bool
|
||||
derivedVars map[t.ID]struct{}
|
||||
jumpTargets map[a.Loop]string
|
||||
activeLoops a.LoopStack
|
||||
coroSuspPoint uint32
|
||||
ioManips uint32
|
||||
tempW uint32
|
||||
|
||||
@@ -473,6 +473,7 @@ func (g *gen) writeStatementIterate(b *buffer, n *a.Iterate, depth uint32) error
|
||||
return nil
|
||||
}
|
||||
name0 := assigns[0].AsAssign().LHS().Ident().Str(g.tm)
|
||||
g.currFunk.activeLoops.Push(n)
|
||||
b.writes("{\n")
|
||||
|
||||
// TODO: don't assume that the slice is a slice of base.u8. In
|
||||
@@ -526,6 +527,7 @@ func (g *gen) writeStatementIterate(b *buffer, n *a.Iterate, depth uint32) error
|
||||
}
|
||||
|
||||
b.writes("}\n")
|
||||
g.currFunk.activeLoops.Pop()
|
||||
return nil
|
||||
}
|
||||
|
||||
@@ -538,6 +540,13 @@ func (g *gen) writeStatementJump(b *buffer, n *a.Jump, depth uint32) error {
|
||||
if n.Keyword() == t.IDBreak {
|
||||
keyword = "break"
|
||||
}
|
||||
// TODO: apply to all generated code, not just
|
||||
// wuffs_jpeg__decoder__fill_bitstream.
|
||||
if (n.JumpTarget() == g.currFunk.activeLoops.Top()) &&
|
||||
(g.currFunk.cName == "wuffs_jpeg__decoder__fill_bitstream") {
|
||||
b.printf("%s;\n", keyword)
|
||||
return nil
|
||||
}
|
||||
b.printf("goto label__%s__%s;\n", jt, keyword)
|
||||
return nil
|
||||
}
|
||||
@@ -624,13 +633,19 @@ func (g *gen) writeStatementRet(b *buffer, n *a.Ret, depth uint32) error {
|
||||
}
|
||||
|
||||
func (g *gen) writeStatementWhile(b *buffer, n *a.While, depth uint32) error {
|
||||
if n.HasContinue() {
|
||||
// TODO: apply to all generated code, not just
|
||||
// wuffs_jpeg__decoder__fill_bitstream.
|
||||
stagedRollout := g.currFunk.cName != "wuffs_jpeg__decoder__fill_bitstream"
|
||||
|
||||
if n.HasDeepContinue() || (stagedRollout && n.HasContinue()) {
|
||||
jt, err := g.currFunk.jumpTarget(g.tm, n)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
b.printf("label__%s__continue:;\n", jt)
|
||||
}
|
||||
g.currFunk.activeLoops.Push(n)
|
||||
|
||||
condition := buffer(nil)
|
||||
if err := g.writeExpr(&condition, n.Condition(), false, 0); err != nil {
|
||||
return err
|
||||
@@ -643,7 +658,9 @@ func (g *gen) writeStatementWhile(b *buffer, n *a.While, depth uint32) error {
|
||||
}
|
||||
}
|
||||
b.writes("}\n")
|
||||
if n.HasBreak() {
|
||||
|
||||
g.currFunk.activeLoops.Pop()
|
||||
if n.HasDeepBreak() || (stagedRollout && n.HasBreak()) {
|
||||
jt, err := g.currFunk.jumpTarget(g.tm, n)
|
||||
if err != nil {
|
||||
return err
|
||||
|
||||
Reference in new issue
Block a user