diff --git a/internal/cgen/func.go b/internal/cgen/func.go index 1996e78b..3f8daf54 100644 --- a/internal/cgen/func.go +++ b/internal/cgen/func.go @@ -420,13 +420,10 @@ func (g *gen) writeFuncImplArgChecks(b *buffer, n *a.Func) error { for _, o := range n.In().Fields() { o := o.AsField() oTyp := o.XType() - if oTyp.Decorator() != t.IDPtr && !oTyp.IsRefined() { - // TODO: Also check elements, for array-typed arguments. - continue - } + // TODO: Also check elements, for array-typed arguments. switch { - case oTyp.Decorator() == t.IDPtr: + case oTyp.IsIOType() || (oTyp.Decorator() == t.IDPtr): checks = append(checks, fmt.Sprintf("!%s%s", aPrefix, o.Name().Str(g.tm))) case oTyp.IsRefined(): diff --git a/release/c/wuffs-unsupported-snapshot.c b/release/c/wuffs-unsupported-snapshot.c index 99ed30c6..ebe11549 100644 --- a/release/c/wuffs-unsupported-snapshot.c +++ b/release/c/wuffs-unsupported-snapshot.c @@ -6384,6 +6384,10 @@ wuffs_deflate__decoder__decode_io_writer(wuffs_deflate__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_dst || !a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 1)) { self->private_impl.magic = WUFFS_BASE__DISABLED; @@ -8135,6 +8139,10 @@ wuffs_lzw__decoder__decode_io_writer(wuffs_lzw__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_dst || !a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 1)) { self->private_impl.magic = WUFFS_BASE__DISABLED; @@ -8730,6 +8738,10 @@ wuffs_gif__decoder__decode_image_config(wuffs_gif__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 1)) { self->private_impl.magic = WUFFS_BASE__DISABLED; @@ -8843,6 +8855,10 @@ wuffs_gif__decoder__ack_metadata_chunk(wuffs_gif__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 2)) { self->private_impl.magic = WUFFS_BASE__DISABLED; @@ -9097,6 +9113,10 @@ wuffs_gif__decoder__decode_frame_config(wuffs_gif__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 3)) { self->private_impl.magic = WUFFS_BASE__DISABLED; @@ -9362,7 +9382,7 @@ wuffs_gif__decoder__decode_frame(wuffs_gif__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } - if (!a_dst) { + if (!a_dst || !a_src) { self->private_impl.magic = WUFFS_BASE__DISABLED; return wuffs_base__error__bad_argument; } @@ -11263,6 +11283,10 @@ wuffs_gzip__decoder__decode_io_writer(wuffs_gzip__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_dst || !a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 1)) { self->private_impl.magic = WUFFS_BASE__DISABLED; @@ -11740,6 +11764,10 @@ wuffs_zlib__decoder__decode_io_writer(wuffs_zlib__decoder* self, ? wuffs_base__error__disabled_by_previous_error : wuffs_base__error__initialize_not_called; } + if (!a_dst || !a_src) { + self->private_impl.magic = WUFFS_BASE__DISABLED; + return wuffs_base__error__bad_argument; + } if ((self->private_impl.active_coroutine != 0) && (self->private_impl.active_coroutine != 1)) { self->private_impl.magic = WUFFS_BASE__DISABLED;