Commit Graph
88 Commits
Author SHA1 Message Date
Nigel Tao 0fe5509f1b base: avoid (NULL + 0) in slice functions
Fixes #178
2026-08-06 12:09:47 +10:00
Nigel Tao 85af5a4bed std/tga: rename to std/targa 2024-09-08 09:00:10 +10:00
Nigel Tao c9fff5b207 std/jpeg: add and use WUFFS_BASE__QUIRK_QUALITY 2024-08-04 23:15:58 +10:00
Nigel Tao fb769ff82f base: disable SIMD on MSVC x86_64 by default
This recreates the case as of commit f1698226 (tag v0.4.0-alpha.4), in
that, by default (without #define'ing a macro or passing an /arch:ETC
compiler flag), Wuffs does not use SIMD on MSVC x86_64.

Commit b64a7610 (after tag v0.4.0-alpha.4, before tag v0.4.0-alpha.5)
changed the default so that x86_64_v2 (roughly equivalent to SSE4.2) was
enabled by default, since the user from issue #148 was enabling that
anyway (in an unsupported way, by #define'ing a macro that was a private
implementation detail) with no problems (and better performance).

However, another user later reported (in issue #151) that enabling SIMD
on MSVC x86_64 somehow lead to ICEs (Internal Compiler Errors).

This commit restores the default to "no SIMD" and it is up to the MSVC
user to opt in to the SIMD code paths. Clang and GCC are unaffected:
SIMD remains enabled by default.

Updates #148
Updates #151
2024-07-31 17:12:55 +10:00
Nigel Tao 495f0280a8 base: add ETC__I_KNOW_THAT_ETC_BEST_WITH_ARCH_AVX2
Updates #148
2024-07-09 10:34:35 +10:00
Nigel Tao b64a761067 base: enable ETC__CPU_ARCH__X86_64_V2 on MSVC
If I understand the https://github.com/google/wuffs/issues/148
discussion correctly, a user overrode WUFFS_BASE__CPU_ARCH__X86_FAMILY
(without also providing /arch:AVX) to enable SSE4.2 code (even though,
technically, x86_64 doesn't guarantee SSE4.2, only SSE2). This seemed to
work fine in practice, but was unsupported by Wuffs and 'broke' by
fixing #145, now looking for WUFFS_BASE__CPU_ARCH__X86_64 instead of
WUFFS_BASE__CPU_ARCH__X86_FAMILY.

WUFFS_BASE__CPU_ARCH__X86_FAMILY has since been renamed to
WUFFS_PRIVATE_IMPL__CPU_ARCH__X86_FAMILY and then removed entirely.

As SSE4.2 (roughly equivalent to x86-64-v2) seems to work fine at
compile time (with the existing cpuid detection at runtime), enable it
by default for MSVC, without need /arch.

Enabling x86-64-v3 too, by default, is held back for now, pending
further confirmation from MSVC users. The #148 user was exercising
Wuffs' PNG codec, which uses SSE4.2 but not AVX or AVX2. Currently, only
Wuffs' JPEG codec (and YCbCr conversion) uses AVX or AVX2.

GCC and Clang don't need this fiddliness, because they support
"__attribute__((target(arg)))".

Updates #148
2024-07-09 10:25:42 +10:00
Nigel Tao 7a57e2b600 base: remove ETC__CPU_ARCH__X86_FAMILY
Updates #148
2024-07-09 09:33:34 +10:00
Nigel Tao 4111785304 base: have MSVC detect AVX2 not AVX
The x86-64-v3 micro-architecture level requires AVX2.

Updates #148
2024-07-09 09:22:23 +10:00
Nigel Tao affa1e02d4 base: add WUFFS_PRIVATE_IMPL__CPU_ARCH__X86_64_V2
Updates #148
2024-07-09 09:17:09 +10:00
Nigel Tao 97b727a1ae base: warn defining private implementation macros
Updates #148
2024-07-08 21:08:05 +10:00
Nigel Tao 37a3c3ce9b base: rename WUFFS_BASE__CPU_ARCH__ETC
See
https://github.com/google/wuffs/issues/148#issuecomment-2130535812

Updates #148
2024-07-08 18:14:59 +10:00
Nigel Tao a27a7598f0 base: disable SIMD on 32-bit (not 64-bit) x86
Fixes #145
2024-04-06 15:30:25 +11:00
Nigel Tao 00a01abc4e base: avoid some (ptr + len) when ptr is NULL
Updates #135
2024-04-05 15:52:40 +11:00
Nigel Tao d7f6b81d31 base: have empty_foo() functions use NULL ptr
This largely reverts commit f81deb6b6e.

Updates #135
2024-04-05 15:29:51 +11:00
Nigel Tao b2c7c69227 base: add WUFFS_BASE__FORCE_INLINE 2024-03-29 15:49:41 +11:00
Nigel Tao 992fd9622a base: rename bitvec256.get to bitvec256.get_u64 2023-12-27 17:05:54 +11:00
Nigel Tao 79af52bb24 std/xz: add SHA-256 checksum support 2023-12-26 17:04:16 +11:00
Nigel Tao 82ea1985b4 base: add optional_u63 type 2023-11-19 12:02:24 +11:00
Nigel Tao 5407f39386 base: use wuffs_base__empty_slice_u8 more often 2023-11-02 22:43:01 +11:00
Nigel Tao 9a68ec70c6 base: use wuffs_private_impl__etc names 2023-11-02 22:30:10 +11:00
Nigel Tao dd75f3215a base: tweak etc_with_non_null_address var names 2023-10-24 20:47:23 +11:00
Nigel Tao f81deb6b6e base: have empty_foo() functions use non-NULL ptr
Fixes #135
2023-10-19 19:31:59 +11:00
Nigel Tao e0636e3255 base: add bitvec256 type 2023-10-12 21:26:53 +11:00
Nigel Tao ae8531f7f8 cgen: generate "foo(void)" instead of "foo()"
This was discovered by "gcc -Wstrict-prototypes".

Updates #132
2023-10-07 11:36:53 +11:00
Patrick Georgi f563f32f82 Add SPDX identifier to license headers
SPDX is an ISO standard for describing licenses in a computer readable
format, which is useful when applying license compliance tools and the
like to source code.

In addition to ensuring that the Wuffs C distribution is properly
annotated to the benefit of projects using Wuffs and SPDX-supporting
tools, add it everywhere else where there's a license in this repo for
consistency, too.
2023-10-06 20:52:36 +02:00
Nigel Tao 74a6ea2fcd all: relicense from Apache2 to dual Apache2/MIT
The LICENSE has changed from a single license (Apache2) to a dual
license (Apache2 or MIT, at your option).

If you've previously used Wuffs under the Apache2 license, you are able
to keep doing so. No further action required by you.

The two files listed below (previous releases) are exceptions, as they
are older snapshots, frozen in time. Their license has not changed:
release/c/wuffs-v0.2.c
release/c/wuffs-v0.3.c

Every name in the AUTHORS file, other than Google Inc., has signed
Google's CLA (Contributor License Agreement).
2023-10-06 10:00:59 +11:00
Nigel Tao bffbad69a4 cgen: halve the sizeof wuffs_foo__bar::unique_ptr 2023-09-24 21:22:22 +10:00
Nigel Tao eca57ef5b3 base: add status.is_truncated_input_error
This just adds a C/C++ function/method. We may or may not add the
corresponding Wuffs method in a future commit.
2023-08-24 16:11:15 +10:00
Nigel Tao 5dfc913cb0 base: let cpu_arch__have_x86_etc return true 2023-07-23 21:48:33 +10:00
Nigel Tao e2b9566fc5 base: restrict x86_avx2 to 64-bit (not 32-bit) x86
32-bit C/C++ compilers don't always compile the AVX intrinsics. Per the
60773 bug below,
> clang++ -m32 etc etc fuzz/c/std/jpeg_fuzzer.c
> undefined reference to `_mm_cvtsi128_si64'
> undefined reference to `_mm256_extract_epi64'

See also the "#ifdef __x86_64__" guards in
https://github.com/gcc-mirror/gcc/blob/4a3895903c29ed85da6fcb886f31ff23d4c6e935/gcc/config/i386/emmintrin.h#L228-L231
https://github.com/llvm/llvm-project/blob/08fab9ebecf72a682279d75489dc2460121cbeed/clang/lib/Headers/emmintrin.h#L3502-L3515

Note that -m32 is not the same as -mx32
> $ touch empty.c
> $ gcc       -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __x86_64__ 1
> $ gcc -m32  -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __i386__ 1
> $ gcc -mx32 -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __x86_64__ 1

Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60773
2023-07-23 21:20:35 +10:00
Nigel Tao e7df7cafac cgen: add WUFFS_BASE__GENERATED_C_CODE macro
This disables UBSan's "unsigned-integer-overflow" runtime checks.

Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59966
2023-06-20 17:04:35 +10:00
Nigel Tao 6e8349129c base: remove deprecated names 2023-04-09 16:12:49 +10:00
Nigel Tao c226ed60f5 Use memcpy-based peeks and pokes on Microsoft C
I don't have a Windows machine readily available, but according to
https://godbolt.org/z/q4MfjzTPh and the https://imgur.com/UD5a7MF
profile mentioned in #72, this could improve inner loop performance.

Updates #72
2022-06-12 17:18:49 +10:00
Nigel Tao be047533e1 Add bounds check to wuffs_base__make_slice_uNN_ij 2022-05-23 11:07:31 +10:00
Nigel Tao 84ef91dda8 Tweak cgen for an_array[i .. j] 2022-05-17 00:00:25 +10:00
Nigel Tao f0412122be Add magic_number_guess_fourcc prefix_closed arg 2022-01-14 15:12:14 +11:00
Nigel Tao 161e4730d8 Tweak default WUFFS_VERSION_PRE_RELEASE_LABEL 2021-11-18 19:18:34 +11:00
Nigel Tao 962a515dd2 Add wuffs_base__table_u8__subtable_ij 2021-11-15 09:58:02 +11:00
Nigel Tao 0460bfcd7a Add FourCC comment 2021-10-17 23:18:58 +11:00
Nigel Tao e317f04bfd Add defined(__clang__) to defined(__GNUC__) checks 2021-10-17 12:14:54 +11:00
Nigel Tao 7f9f37ce5a Have examples use WUFFS_CONFIG__STATIC_FUNCTIONS
Compile time:
$ time ./build-example.sh
Before: user 1m15.750s
After:  user 0m50.343s

Binary size (excluding the statically linked example-toy-genlib):
$ ls -l gen/bin/example-* | awk '{print $5 " " $9}'

Before:
212624 gen/bin/example-cbor-to-json
284192 gen/bin/example-convert-to-nia
344744 gen/bin/example-crc32
184304 gen/bin/example-gifplayer
324952 gen/bin/example-imageviewer
209632 gen/bin/example-json-to-cbor
241432 gen/bin/example-jsonfindptrs
196320 gen/bin/example-jsonptr
309768 gen/bin/example-sdl-imageviewer
200704 gen/bin/example-zcat

After:
 85280 gen/bin/example-cbor-to-json
242216 gen/bin/example-convert-to-nia
344744 gen/bin/example-crc32
 53328 gen/bin/example-gifplayer
282840 gen/bin/example-imageviewer
 95152 gen/bin/example-json-to-cbor
122720 gen/bin/example-jsonfindptrs
 60448 gen/bin/example-jsonptr
267672 gen/bin/example-sdl-imageviewer
 64792 gen/bin/example-zcat

Before total: 2508672
After  total: 1619192
2021-10-04 12:35:32 +11:00
Nigel Tao a66a083e82 Have X86_FAMILY allow 32-bit x86, not just x86_64
Fixes #53
2021-08-22 22:37:48 +10:00
Nigel Tao cb2e49ab09 Rename CPU arch macro s/X86_64/X86_FAMILY/ 2021-08-22 22:23:49 +10:00
Nigel Tao 1d19157668 Remove After editing... run "go generate" lines 2021-08-22 12:57:39 +10:00
Nigel Tao b9a10d051a Fix -Werror=conversion in fundamental-public.h 2021-06-28 10:10:13 +10:00
Nigel Tao d8796aa6d9 Add wuffs_base__uxx__rotate_etc functions 2021-06-28 09:59:32 +10:00
Nigel Tao 91857f4c4b Disable cpu_arch specific code for Native Client 2021-06-24 22:40:54 +10:00
Nigel Tao 08797bc713 Have "x86_avx2" require PCLMUL, POPCNT and SSE4.2
The std/crc32 benchmark numbers get worse. The benches still run AVX2
code, but it runs slower for an unknown reason. The std/gzip and std/png
benchmark numbers are mixed.

Still, it's cleaner for Wuffs' "x86_avx2" to be a superset of
"x86_sse42" (and apart from PCLMUL, they're now similar to Clang 12 and
GCC 11's "x86-64-v3" and "x86-64-v2" micro-architecture feature levels).
Maybe future compiler versions can claw back the std/crc32 performance.

On a mid-range x86_64 laptop (2016, Skylake):

name                                                               old speed      new speed      delta

wuffs_crc32_ieee_10k/clang9                                        8.07GB/s ± 0%  7.61GB/s ± 1%   -5.72%  (p=0.000 n=8+8)
wuffs_crc32_ieee_100k/clang9                                       11.0GB/s ± 1%   9.7GB/s ± 3%  -11.45%  (p=0.000 n=7+8)

wuffs_crc32_ieee_10k/gcc10                                         9.77GB/s ± 1%  7.72GB/s ± 1%  -21.00%  (p=0.000 n=10+9)
wuffs_crc32_ieee_100k/gcc10                                        12.7GB/s ± 2%  11.9GB/s ± 2%   -5.84%  (p=0.000 n=9+9)

wuffs_gzip_decode_10k/clang9                                        217MB/s ± 2%   221MB/s ± 0%   +1.80%  (p=0.000 n=10+8)
wuffs_gzip_decode_100k/clang9                                       280MB/s ± 1%   283MB/s ± 0%   +1.38%  (p=0.000 n=9+8)

wuffs_gzip_decode_10k/gcc10                                         215MB/s ± 1%   220MB/s ± 1%   +2.52%  (p=0.000 n=10+9)
wuffs_gzip_decode_100k/gcc10                                        272MB/s ± 0%   274MB/s ± 1%   +0.74%  (p=0.000 n=9+10)

wuffs_png_decode_image_19k_8bpp/clang9                              136MB/s ± 0%   142MB/s ± 0%   +3.95%  (p=0.000 n=8+8)
wuffs_png_decode_image_40k_24bpp/clang9                             171MB/s ± 1%   172MB/s ± 0%   +0.84%  (p=0.000 n=10+8)
wuffs_png_decode_image_77k_8bpp/clang9                              492MB/s ± 3%   501MB/s ± 2%   +1.88%  (p=0.009 n=10+10)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang9            456MB/s ± 1%   461MB/s ± 1%   +1.04%  (p=0.000 n=9+9)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang9            439MB/s ± 1%   440MB/s ± 3%     ~     (p=0.173 n=8+10)
wuffs_png_decode_image_4002k_24bpp/clang9                           172MB/s ± 1%   174MB/s ± 1%   +1.29%  (p=0.005 n=10+10)

wuffs_png_decode_image_19k_8bpp/gcc10                               152MB/s ± 0%   149MB/s ± 1%   -1.92%  (p=0.000 n=9+9)
wuffs_png_decode_image_40k_24bpp/gcc10                              184MB/s ± 0%   186MB/s ± 1%   +1.37%  (p=0.000 n=8+9)
wuffs_png_decode_image_77k_8bpp/gcc10                               550MB/s ± 1%   542MB/s ± 2%   -1.46%  (p=0.000 n=10+10)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10             473MB/s ± 1%   478MB/s ± 1%   +1.23%  (p=0.000 n=9+10)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10             453MB/s ± 1%   458MB/s ± 1%   +0.91%  (p=0.000 n=9+10)
wuffs_png_decode_image_4002k_24bpp/gcc10                            185MB/s ± 2%   188MB/s ± 0%   +1.82%  (p=0.000 n=9+8)
2021-06-22 13:27:25 +10:00
Nigel Tao b8f87debe3 Tweak wuffs_base__cpu_arch__have_foo_bar impl 2021-04-29 17:52:10 +10:00
Nigel Tao 8ccaf81e96 Fix s/bit_BMI2/bit_AVX2/ typo 2021-04-26 22:52:27 +10:00