Nigel Tao
38b101d170
Push std/png decoder.tell_me_more goto_done later
2021-11-26 19:46:36 +11:00
Nigel Tao
5d1473a2ca
Refactor std/png decoder.tell_me_more
2021-11-26 19:45:42 +11:00
Nigel Tao
72d4a9e769
Have std/png pass through EXIF data
...
Fixes #59
2021-11-26 19:14:30 +11:00
Nigel Tao
5f6a522563
Add a "while.goto_done" no-op to std/png
2021-11-26 17:26:12 +11:00
Nigel Tao
4dedbedbbc
Remove unnecessary std/nie struct parentheses
2021-11-26 17:24:57 +11:00
Nigel Tao
ac4d3e6420
Use 0 (not 1) num_animation_loops for still GIFs
...
For example, the crc32 checksums in test/nia-checksums-of-data.txt for
test/data/pjw-thumbnail.{bmp,gif,png} now all match.
2021-11-23 15:06:55 +11:00
Nigel Tao
f5c68a13cb
Fix std/png for depth-16 grayscale interlaced
2021-11-20 22:54:21 +11:00
Nigel Tao
5e8b448c12
Drop std/deflate's "Re-purpose the hdist variable"
2021-11-20 22:03:29 +11:00
Nigel Tao
49a431f98d
Fix std/deflate decode_huffman_slow suspends
...
Unlike the other decode_huffman_etc! methods, decode_huffman_slow? (with
a ?) can suspend. The (hlen, hdist) and the remainder (length, distance)
pairs might not be stable across a suspension, as the args.dst io_writer
might change its history length. We have to re-calculate those pairs
after a short write.
The test/3pdata/nia-checksums-of-pngsuite.txt for interlaced and
non-interlaced flavors of the same image now match.
2021-11-20 21:31:40 +11:00
Nigel Tao
ede0590ead
Add while label to std/deflate decode_huffman_slow
2021-11-20 20:14:37 +11:00
Nigel Tao
bb8623b472
Have deflate slow-Huffman use extended ringbuffer
...
This is the same optimization as commit e65c8612 "Extend std/deflate
ringbuffer to simplify copies", applied to decoder.decode_huffman_slow.
2021-11-20 20:10:10 +11:00
Nigel Tao
a684928240
Let std/png allow PLTE for RGB, RGBA color types
2021-11-20 15:39:07 +11:00
Nigel Tao
e44920d382
Let gif "ignore too much" quirk skip lzw errors
...
The modified test/data/*/*.gif files differ by only one byte:
00000000 47 49 46 38 39 61 02 00 02 00 81 00 00 00 00 ff |GIF89a..........|
00000010 11 00 ff 22 00 ff 33 00 ff 2c 00 00 00 00 02 00 |..."..3..,......|
-00000020 02 00 00 02 02 84 f1 00 3b |........;|
+00000020 02 00 00 02 02 84 5d 00 3b |......].;|
The etc-good-lzw.gif bits have changed, even though the
etc-good-lzw.etc.txt file only had comments added, due to a Go standard
library change: "compress/lzw: output a Clear code first, per GIF spec"
https://github.com/golang/go/commit/9c1dbdf60edbffeff10f58af21fa055eb0fdd29f
Updates PR #57
Updates https://crbug.com/1270631
2021-11-19 13:30:23 +11:00
Nigel Tao
29560a336b
Convert std/png text from Latin-1 to UTF-8
...
Fixes #55
2021-11-17 23:04:49 +11:00
Nigel Tao
e0cdaeb54f
Fix std/png tell_me_more minfo with suspensions
2021-11-17 13:04:04 +11:00
Nigel Tao
e7ed1dd43e
Add std/png tell_me_more while.loop name
2021-11-17 13:01:05 +11:00
Nigel Tao
417b03a0ad
Add std/png "#unsupported PNG compression method"
2021-11-17 12:07:44 +11:00
Nigel Tao
7dd0dd264b
Delete superfluous "// --------" comment
2021-11-17 12:03:43 +11:00
Nigel Tao
0d37acd6f6
Factor out std/png/common_consts.wuffs
2021-11-17 12:01:37 +11:00
Nigel Tao
6737565c20
Let std/png decode iTXt, tEXt and zTXt chunks
...
Updates #55
2021-11-17 11:56:49 +11:00
Nigel Tao
f0c2a40d66
Resize std/png chunk_length field from u64 to u32
2021-11-16 13:06:30 +11:00
Nigel Tao
ce9ab13ecd
Let std/png decode first fcTL after the last IDAT
2021-11-16 12:55:43 +11:00
Nigel Tao
0045ce49f3
Rename table.row as table.row_u32
2021-11-15 10:49:42 +11:00
Nigel Tao
fa56d92410
Clip std/png frame_dirty_rect to frame rect
2021-11-15 10:46:28 +11:00
Nigel Tao
8f1adea523
Hoist subslice out of std/png filter_and_swizzle
...
On an Intel NUC (Comet Lake, BXNUC10i5FNKPA):
name old speed new speed delta
wuffs_png_decode_image_19k_8bpp/clang9 274MB/s ± 0% 273MB/s ± 0% -0.25% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/clang9 309MB/s ± 0% 308MB/s ± 0% -0.22% (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/clang9 985MB/s ± 0% 982MB/s ± 0% -0.29% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang9 846MB/s ± 0% 841MB/s ± 0% -0.56% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang9 812MB/s ± 0% 808MB/s ± 0% -0.55% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/clang9 320MB/s ± 0% 320MB/s ± 0% -0.15% (p=0.008 n=5+5)
wuffs_png_decode_image_19k_8bpp/gcc10 263MB/s ± 0% 276MB/s ± 0% +5.00% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/gcc10 328MB/s ± 0% 333MB/s ± 0% +1.49% (p=0.016 n=5+4)
wuffs_png_decode_image_77k_8bpp/gcc10 950MB/s ± 0% 976MB/s ± 0% +2.78% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10 865MB/s ± 0% 912MB/s ± 0% +5.45% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10 825MB/s ± 0% 868MB/s ± 0% +5.19% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/gcc10 336MB/s ± 0% 341MB/s ± 0% +1.37% (p=0.008 n=5+5)
2021-11-15 10:43:55 +11:00
Nigel Tao
4d64aff554
Rename std/png/decode_swizzle_fallback.wuffs
2021-11-14 19:58:23 +11:00
Nigel Tao
a4fa6a2554
Let std/png decode (animated) APNG
...
The test/nia-checksums-of-data.txt checksums for the *.apng files now
match the (multiple frame) *.gif files. Previously, they matched the
(single frame) *.000000.nie files.
Fixes #41
2021-11-14 18:20:15 +11:00
Nigel Tao
9af2666aec
Move std/png first_frame_io_position earlier
2021-11-10 16:52:59 +11:00
Nigel Tao
9c3d27fb43
Fix std/png decode_other_chunk skipping chunks
2021-11-09 22:10:00 +11:00
Nigel Tao
2373340f83
Add base.ANIMATION_DISPOSAL__ETC constants
2021-11-09 09:53:29 +11:00
Nigel Tao
e847766b02
Tweak std/png decode_other_chunk if-else chain
2021-11-09 09:05:11 +11:00
Nigel Tao
74c1dfce96
Rename std/gif num_loops field
2021-11-09 08:55:15 +11:00
Nigel Tao
ca76a01ac2
Have std/png support remapped transparency
2021-11-07 09:51:04 +11:00
Nigel Tao
00b329872a
Tighten png.INTERLACING type refinement
2021-11-06 09:54:56 +11:00
Nigel Tao
744fbdd732
Have std/png decode iCCP chunks
...
Updates #39
2021-11-05 16:29:11 +11:00
Nigel Tao
8f9a4f40c2
Rename METADATA_RAW as METADATA_RAW_PASSTHROUGH
2021-10-31 15:17:46 +11:00
Nigel Tao
db5a407bab
Have std/png decode sRGB chunks
...
Updates #39
2021-10-16 09:27:30 +11:00
Nigel Tao
911049e9f9
Have std/png decode cHRM and gAMA chunks
...
Updates #39
2021-10-15 15:08:47 +11:00
Nigel Tao
d8ad363ef5
Tweak png.decoder.decode_image_config indentation
2021-10-15 13:35:15 +11:00
Nigel Tao
ad1d983698
Add ETC__MORE_INFORMATION__FLAVOR__METADATA_PARSED
2021-10-14 17:17:11 +11:00
Nigel Tao
f9c029c788
Fix std/png history_position for interlacing
2021-10-07 13:52:40 +11:00
Nigel Tao
592bc14ed1
Have std/deflate allow non-compact dst history
...
Fixes #52
On a mid-range x86_64 laptop (2016, Skylake):
name old speed new speed delta
wuffs_deflate_decode_1k_full_init/clang9 101MB/s ± 1% 100MB/s ± 1% -1.22% (p=0.000 n=9+9)
wuffs_deflate_decode_1k_part_init/clang9 119MB/s ± 1% 119MB/s ± 1% ~ (p=0.139 n=8+9)
wuffs_deflate_decode_10k_full_init/clang9 221MB/s ± 1% 210MB/s ± 1% -4.94% (p=0.000 n=9+9)
wuffs_deflate_decode_10k_part_init/clang9 225MB/s ± 3% 215MB/s ± 1% -4.33% (p=0.000 n=10+8)
wuffs_deflate_decode_100k_just_one_read/clang9 290MB/s ± 0% 284MB/s ± 1% -2.26% (p=0.000 n=8+9)
wuffs_deflate_decode_100k_many_big_reads/clang9 188MB/s ± 3% 177MB/s ± 1% -5.78% (p=0.000 n=9+10)
wuffs_deflate_decode_1k_full_init/gcc10 101MB/s ± 0% 97MB/s ± 1% -3.65% (p=0.000 n=8+9)
wuffs_deflate_decode_1k_part_init/gcc10 119MB/s ± 1% 113MB/s ± 2% -4.65% (p=0.000 n=9+9)
wuffs_deflate_decode_10k_full_init/gcc10 214MB/s ± 3% 224MB/s ± 1% +4.83% (p=0.000 n=10+10)
wuffs_deflate_decode_10k_part_init/gcc10 222MB/s ± 1% 231MB/s ± 1% +4.03% (p=0.000 n=9+10)
wuffs_deflate_decode_100k_just_one_read/gcc10 281MB/s ± 2% 297MB/s ± 0% +5.78% (p=0.000 n=9+9)
wuffs_deflate_decode_100k_many_big_reads/gcc10 184MB/s ± 0% 194MB/s ± 0% +5.85% (p=0.000 n=10+8)
mimic_deflate_decode_1k_full_init 138MB/s ± 1% 138MB/s ± 0% ~ (p=0.546 n=9+9)
mimic_deflate_decode_10k_full_init 156MB/s ± 2% 156MB/s ± 0% ~ (p=0.387 n=9+9)
mimic_deflate_decode_100k_just_one_read 191MB/s ± 1% 190MB/s ± 2% -0.94% (p=0.004 n=9+10)
mimic_deflate_decode_100k_many_big_reads 147MB/s ± 1% 147MB/s ± 1% ~ (p=0.356 n=9+10)
wuffs_gzip_decode_10k/clang9 220MB/s ± 1% 209MB/s ± 1% -5.29% (p=0.000 n=10+9)
wuffs_gzip_decode_100k/clang9 283MB/s ± 2% 279MB/s ± 1% -1.47% (p=0.002 n=10+10)
wuffs_gzip_decode_10k/gcc10 218MB/s ± 1% 214MB/s ± 2% -1.76% (p=0.000 n=9+10)
wuffs_gzip_decode_100k/gcc10 274MB/s ± 0% 264MB/s ± 2% -3.61% (p=0.000 n=7+10)
mimic_gzip_decode_10k 131MB/s ± 2% 132MB/s ± 0% +0.81% (p=0.000 n=10+8)
mimic_gzip_decode_100k 156MB/s ± 0% 156MB/s ± 1% ~ (p=0.423 n=8+9)
wuffs_zlib_decode_10k/clang9 223MB/s ± 2% 209MB/s ± 2% -6.41% (p=0.000 n=10+10)
wuffs_zlib_decode_100k/clang9 285MB/s ± 0% 280MB/s ± 0% -1.87% (p=0.000 n=8+9)
wuffs_zlib_decode_10k/gcc10 235MB/s ± 0% 215MB/s ± 1% -8.22% (p=0.000 n=10+9)
wuffs_zlib_decode_100k/gcc10 293MB/s ± 0% 268MB/s ± 1% -8.38% (p=0.000 n=8+10)
mimic_zlib_decode_10k 145MB/s ± 1% 145MB/s ± 1% -0.45% (p=0.004 n=9+9)
mimic_zlib_decode_100k 175MB/s ± 1% 174MB/s ± 0% ~ (p=0.055 n=10+8)
wuffs_png_decode_image_19k_8bpp/clang9 142MB/s ± 1% 152MB/s ± 1% +6.98% (p=0.000 n=9+9)
wuffs_png_decode_image_40k_24bpp/clang9 172MB/s ± 0% 170MB/s ± 0% -1.63% (p=0.000 n=8+9)
wuffs_png_decode_image_77k_8bpp/clang9 504MB/s ± 2% 540MB/s ± 1% +7.28% (p=0.000 n=9+10)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang9 462MB/s ± 1% 470MB/s ± 0% +1.57% (p=0.000 n=9+10)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang9 445MB/s ± 1% 451MB/s ± 0% +1.49% (p=0.000 n=8+10)
wuffs_png_decode_image_4002k_24bpp/clang9 175MB/s ± 3% 175MB/s ± 1% ~ (p=0.356 n=9+10)
wuffs_png_decode_image_19k_8bpp/gcc10 150MB/s ± 0% 153MB/s ± 1% +2.03% (p=0.000 n=10+10)
wuffs_png_decode_image_40k_24bpp/gcc10 186MB/s ± 0% 186MB/s ± 0% ~ (p=0.408 n=10+8)
wuffs_png_decode_image_77k_8bpp/gcc10 543MB/s ± 0% 542MB/s ± 0% -0.23% (p=0.019 n=9+9)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10 478MB/s ± 1% 498MB/s ± 0% +4.12% (p=0.000 n=10+9)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10 451MB/s ± 4% 476MB/s ± 0% +5.37% (p=0.000 n=10+9)
wuffs_png_decode_image_4002k_24bpp/gcc10 185MB/s ± 2% 190MB/s ± 1% +2.78% (p=0.000 n=10+9)
mimic_png_decode_image_19k_8bpp 63.0MB/s ± 0% 62.9MB/s ± 1% ~ (p=0.673 n=8+9)
mimic_png_decode_image_40k_24bpp 78.7MB/s ± 0% 78.9MB/s ± 0% ~ (p=0.059 n=9+8)
mimic_png_decode_image_77k_8bpp 192MB/s ± 1% 193MB/s ± 3% +0.44% (p=0.028 n=10+9)
mimic_png_decode_image_552k_32bpp_verify_checksum 157MB/s ± 0% 158MB/s ± 1% ~ (p=0.053 n=10+9)
mimic_png_decode_image_4002k_24bpp 113MB/s ± 1% 113MB/s ± 1% ~ (p=0.053 n=10+9)
2021-08-15 10:50:41 +10:00
Nigel Tao
28a54baa19
Add io_bind history_position arg
2021-08-15 08:36:14 +10:00
Nigel Tao
77f855206d
Have JSON line-comment tokens exclude the "\n"
...
Before this commit, line-comment token chains included the final "\n"
the way block-comments included the final "*/". The "\n" was mandatory.
However, when parsing with both QUIRK_ALLOW_COMMENT_LINE and
QUIRK_ALLOW_TRAILING_FILLER, input like "123//xyz" (without a "\n"
before the EOF) was rejected before and accepted after this commit.
So that line-comments are consistent, in that they either always or
never include the final "\n", they now never include the final "\n".
An input fragment (parsed with QUIRK_ALLOW_COMMENT_LINE) like
"//abc\n\t\t" was, before this commit, parsed as a 6 byte comment token
and a 2 byte other-filler token. That split is now 5+3.
2021-07-20 14:17:09 +10:00
Nigel Tao
3358730f6f
Have std/png reject zero width or height
2021-05-11 12:34:19 +10:00
Nigel Tao
e77d73e3ce
Add std/adler32 bench comment for the roll back
2021-04-28 22:38:10 +10:00
Nigel Tao
0a6cce5e0e
Tweak some adler32 hasher.up_x86_sse42 var names
2021-04-28 00:32:32 +10:00
Nigel Tao
abd37fa3f8
Roll back 'Add std/adler32 hasher.up_x86_avx2'
...
See the previous commit for the rationale.
2021-04-28 00:26:54 +10:00
Nigel Tao
baec831fc8
Add std/adler32 hasher.up_x86_avx2
...
While the std/adler32 benchmarks got better, the std/zlib and std/png
benchmarks got worse.
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.
Binary size, before:
4056 gen/lib/c/clang-9-dynamic/wuffs-std-adler32.lo
4104 gen/lib/c/clang-9-static/wuffs-std-adler32.o
4624 gen/lib/c/gcc-dynamic/wuffs-std-adler32.lo
4680 gen/lib/c/gcc-static/wuffs-std-adler32.o
After:
4952 gen/lib/c/clang-9-dynamic/wuffs-std-adler32.lo
5016 gen/lib/c/clang-9-static/wuffs-std-adler32.o
5512 gen/lib/c/gcc-dynamic/wuffs-std-adler32.lo
5576 gen/lib/c/gcc-static/wuffs-std-adler32.o
name old speed new speed delta
wuffs_adler32_10k/clang9 11.5GB/s ± 1% 15.0GB/s ± 5% +30.73% (p=0.000 n=9+10)
wuffs_adler32_100k/clang9 13.5GB/s ± 1% 15.6GB/s ±14% +16.06% (p=0.001 n=9+10)
wuffs_adler32_10k/gcc10 11.3GB/s ± 2% 15.6GB/s ± 1% +38.27% (p=0.000 n=9+9)
wuffs_adler32_100k/gcc10 11.3GB/s ± 1% 19.4GB/s ± 1% +71.20% (p=0.000 n=7+9)
wuffs_zlib_decode_10k/clang9 223MB/s ± 1% 216MB/s ± 2% -3.45% (p=0.000 n=10+10)
wuffs_zlib_decode_100k/clang9 285MB/s ± 1% 284MB/s ± 1% ~ (p=0.243 n=9+10)
wuffs_zlib_decode_10k/gcc10 232MB/s ± 1% 216MB/s ± 1% -6.70% (p=0.000 n=10+9)
wuffs_zlib_decode_100k/gcc10 291MB/s ± 1% 280MB/s ± 1% -3.70% (p=0.000 n=9+8)
wuffs_png_decode_image_19k_8bpp/clang9 152MB/s ± 1% 143MB/s ± 3% -5.89% (p=0.000 n=8+9)
wuffs_png_decode_image_40k_24bpp/clang9 171MB/s ± 1% 173MB/s ± 1% ~ (p=0.094 n=9+9)
wuffs_png_decode_image_77k_8bpp/clang9 541MB/s ± 1% 509MB/s ± 1% -5.77% (p=0.000 n=8+9)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang9 479MB/s ± 1% 464MB/s ± 3% -3.20% (p=0.000 n=8+10)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang9 461MB/s ± 1% 452MB/s ± 1% -2.02% (p=0.000 n=8+10)
wuffs_png_decode_image_4002k_24bpp/clang9 177MB/s ± 1% 175MB/s ± 2% -1.14% (p=0.004 n=10+10)
wuffs_png_decode_image_19k_8bpp/gcc10 159MB/s ± 1% 153MB/s ± 1% -3.54% (p=0.000 n=8+10)
wuffs_png_decode_image_40k_24bpp/gcc10 188MB/s ± 1% 187MB/s ± 1% -0.47% (p=0.021 n=10+9)
wuffs_png_decode_image_77k_8bpp/gcc10 557MB/s ± 0% 546MB/s ± 4% -1.94% (p=0.000 n=8+10)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10 510MB/s ± 0% 493MB/s ± 0% -3.33% (p=0.000 n=10+9)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10 486MB/s ± 1% 478MB/s ± 0% -1.77% (p=0.000 n=8+9)
wuffs_png_decode_image_4002k_24bpp/gcc10 189MB/s ± 1% 187MB/s ± 1% -1.26% (p=0.000 n=10+10)
2021-04-28 00:18:20 +10:00
Nigel Tao
5764f77913
Have std/png produce PIXEL_FORMAT__Y_16LE
...
Updates #46
2021-04-16 14:34:48 +10:00