Commit Graph
616 Commits
Author SHA1 Message Date
Nigel Tao 093268e179 Rename the !?? effect to ? 2018-12-29 13:57:57 +11:00
Nigel Tao 1ea32b3745 Remove the !? effect, leaving only ! and !?? 2018-12-29 13:36:38 +11:00
Nigel Tao a954e9ad81 Insert implicit semi-colons after keywords 2018-12-29 13:17:21 +11:00
Nigel Tao 3ba450ba55 Make gif's decoder.copy_to_image_buffer ! not !? 2018-12-28 17:32:48 +11:00
Nigel Tao 489fec4437 Remove parse's Options.AllowBuiltIns 2018-12-28 15:50:18 +11:00
Nigel Tao 5cddd4894f Fix lang/check tests for language changes 2018-12-27 21:06:50 +11:00
Nigel Tao c9e6ee6fb3 Fold Expr statements into Assign statements 2018-12-27 17:36:08 +11:00
Nigel Tao d26fa09d07 Have wuffsfmt align the "T"s in "x T" fields 2018-12-27 15:09:52 +11:00
Nigel Tao 1ceb304ad9 Have wuffsfmt align the "T"s in "var x T" blocks 2018-12-27 14:19:20 +11:00
Nigel Tao 6dc68950c0 Drop the "= RHS" out of "var x T = RHS" 2018-12-27 11:29:47 +11:00
Nigel Tao cbe19f50e0 Restrict var statements to the top of functions 2018-12-27 11:19:22 +11:00
Nigel Tao 84f9d3a915 Prohibit "this.etc = etc" inside pure functions 2018-12-27 11:01:55 +11:00
Nigel Tao d552f88738 Make Iterate contain Assign's not Var's 2018-12-27 10:35:27 +11:00
Nigel Tao bac74a830d Place some vars at the top of functions 2018-12-26 18:34:52 +11:00
Nigel Tao 7405307173 Propagate tighter bounds checks after assignments 2018-12-26 16:52:55 +11:00
Nigel Tao 231389ee26 Have bounds checks use interval.IntRange methods 2018-12-26 15:13:56 +11:00
Nigel Tao 20e82ba97b Use interval.IntRange instead of ast.Bounds 2018-12-26 14:02:34 +11:00
Nigel Tao ef51d032ba Prohibit weak-effect funcs calling strong-effects 2018-12-26 11:43:15 +11:00
Nigel Tao 7a0a345d41 Ensure that assert's and args are effect-free 2018-12-26 11:20:19 +11:00
Nigel Tao eb0cbd802a Make SubExprHasEffect an ast.Flags not ast.Effect 2018-12-16 11:09:23 +11:00
Nigel Tao dd28f3c0f9 Remove the "? but not !?" effect 2018-12-16 11:03:31 +11:00
Nigel Tao 247232091d Delete an obsolete io_bind in std/gif 2018-12-16 10:12:43 +11:00
Nigel Tao 622a76d4c0 Avoid buffer copies from LZW to GIF
name                                    old speed     new speed      delta

wuffs_lzw_decode_20k/clang              213MB/s ± 0%   224MB/s ± 1%   +4.89%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang             359MB/s ± 1%   393MB/s ± 2%   +9.36%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc                188MB/s ± 0%   187MB/s ± 0%   -0.70%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc               223MB/s ± 2%   224MB/s ± 0%     ~     (p=0.690 n=5+5)

wuffs_gif_decode_1k_bw/clang            227MB/s ± 1%   240MB/s ± 0%   +5.89%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang         117MB/s ± 0%   125MB/s ± 0%   +6.16%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang         567MB/s ± 1%   599MB/s ± 0%   +5.56%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang      152MB/s ± 0%   159MB/s ± 1%   +4.76%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang  455MB/s ± 1%   504MB/s ± 0%  +10.93%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang   178MB/s ± 2%   194MB/s ± 0%   +9.00%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang            179MB/s ± 1%   197MB/s ± 0%   +9.81%  (p=0.016 n=5+4)
wuffs_gif_decode_anim_screencap/clang   952MB/s ± 0%  1050MB/s ± 1%  +10.29%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc              243MB/s ± 1%   252MB/s ± 0%   +3.71%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc           130MB/s ± 0%   133MB/s ± 1%   +2.69%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc           537MB/s ± 0%   547MB/s ± 1%   +1.93%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc        163MB/s ± 0%   167MB/s ± 1%   +2.40%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc    458MB/s ± 0%   471MB/s ± 0%   +2.90%  (p=0.016 n=5+4)
wuffs_gif_decode_100k_realistic/gcc     186MB/s ± 0%   191MB/s ± 0%   +3.08%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc              189MB/s ± 0%   194MB/s ± 0%   +2.70%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc     976MB/s ± 0%  1010MB/s ± 0%   +3.49%  (p=0.008 n=5+5)
2018-12-16 09:57:15 +11:00
Nigel Tao 33a4557d98 Collect GIF's LZW data into larger batches
name                                    old speed     new speed     delta

wuffs_gif_decode_1k_bw/clang            224MB/s ± 1%  227MB/s ± 0%  +0.98%  (p=0.000 n=10+9)
wuffs_gif_decode_1k_color/clang         116MB/s ± 1%  118MB/s ± 1%  +2.26%  (p=0.000 n=10+10)
wuffs_gif_decode_10k_bgra/clang         541MB/s ± 0%  568MB/s ± 1%  +4.97%  (p=0.000 n=9+10)
wuffs_gif_decode_10k_indexed/clang      144MB/s ± 0%  152MB/s ± 0%  +5.61%  (p=0.000 n=9+10)
wuffs_gif_decode_100k_artificial/clang  438MB/s ± 1%  454MB/s ± 1%  +3.56%  (p=0.000 n=9+10)
wuffs_gif_decode_100k_realistic/clang   171MB/s ± 0%  179MB/s ± 0%  +4.64%  (p=0.000 n=8+10)
wuffs_gif_decode_1000k/clang            174MB/s ± 0%  180MB/s ± 0%  +3.90%  (p=0.000 n=9+10)
wuffs_gif_decode_anim_screencap/clang   897MB/s ± 1%  943MB/s ± 0%  +5.10%  (p=0.000 n=9+9)

wuffs_gif_decode_1k_bw/gcc              250MB/s ± 1%  241MB/s ± 1%  -3.26%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color/gcc           132MB/s ± 1%  130MB/s ± 1%  -2.15%  (p=0.000 n=10+10)
wuffs_gif_decode_10k_bgra/gcc           534MB/s ± 1%  535MB/s ± 1%    ~     (p=0.211 n=9+10)
wuffs_gif_decode_10k_indexed/gcc        162MB/s ± 1%  163MB/s ± 0%    ~     (p=0.105 n=10+10)
wuffs_gif_decode_100k_artificial/gcc    460MB/s ± 0%  456MB/s ± 0%  -0.80%  (p=0.000 n=10+10)
wuffs_gif_decode_100k_realistic/gcc     186MB/s ± 0%  186MB/s ± 1%  -0.33%  (p=0.001 n=9+10)
wuffs_gif_decode_1000k/gcc              189MB/s ± 1%  188MB/s ± 1%    ~     (p=0.053 n=9+10)
wuffs_gif_decode_anim_screencap/gcc     981MB/s ± 1%  971MB/s ± 1%  -0.95%  (p=0.000 n=10+10)
2018-12-15 14:10:10 +11:00
Nigel Tao 6fe313a72c Allow an io_limit limit to be a refined base.u64 2018-12-15 10:45:36 +11:00
Nigel Tao fad2ddce68 Generate less code for foo.since_mark().length() 2018-12-09 11:15:10 +11:00
Nigel Tao 6d2bb77bb7 Add a data:etc argument to io_bind 2018-12-09 09:53:46 +11:00
Nigel Tao badbdfc487 Tweak io_bind syntax 2018-12-09 09:13:29 +11:00
Nigel Tao e992921dce Add an io_limit keyword 2018-12-09 09:03:21 +11:00
Nigel Tao 90193cb6e2 Add palette arguments to the pixel swizzler 2018-12-08 13:58:52 +11:00
Nigel Tao 6c9dca47ee Add a base.pixel_swizzler type 2018-12-08 13:25:53 +11:00
Nigel Tao 5cae1f8c82 Remove the obsolete Effect.RootCause concept 2018-12-01 13:37:33 +11:00
Nigel Tao 9741eada02 Replace "= try foo" with "=? foo" 2018-12-01 13:11:47 +11:00
Nigel Tao ad9851ea75 Prohibit effect-ful subexpressions 2018-12-01 11:33:26 +11:00
Nigel Tao c986536230 Rename some read_uxx methods as read_uxx_as_uyy 2018-11-25 12:15:05 +11:00
Nigel Tao c72f7a158d Re-order some token.ID numbers 2018-11-25 11:24:30 +11:00
Nigel Tao 0482fadf41 Generate implicit wuffs_base__status for !? funcs 2018-11-24 15:41:56 +11:00
Nigel Tao 762b320b5e Make the return value mandatory; add ok 2018-11-24 15:09:28 +11:00
Nigel Tao 24ace1c144 Type and bounds check the "x" in "return x" 2018-11-24 14:46:52 +11:00
Nigel Tao c84732f3d3 Quote built-in statuses 2018-11-24 13:42:18 +11:00
Nigel Tao 9e5aec5d25 Change "$foo" to base."$foo" 2018-11-24 13:36:09 +11:00
Nigel Tao 875362ea07 Change status "?foo" to just "?foo" 2018-11-24 12:36:42 +11:00
Nigel Tao 5f9d007b1c Make a struct's implicit reset method impure 2018-11-24 11:05:39 +11:00
Nigel Tao e84a716313 Add comment to consider status.is_complete 2018-11-24 10:10:39 +11:00
Nigel Tao 4023294ba2 Add a gif.decoder.frame_dirty_rect method 2018-11-17 21:26:53 +11:00
Nigel Tao 3854ce3e89 Let test binaries run from any dir in the repo
Also spin out generate.WuffsRoot into its own package.
2018-11-03 08:46:31 +11:00
Nigel Tao c3ef038c79 Fix missing operator for ast.Expr.Str 2018-10-21 18:12:26 +11:00
Nigel Tao 3338d6d1bc Write LZW output 8 bytes at a time, not 1
The benchmarks are mixed, but I think it's still a net win.

----
name                                    old speed     new speed     delta

wuffs_gif_decode_1k_bw/clang            258MB/s ± 0%  253MB/s ± 1%    -2.04%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang         159MB/s ± 0%  116MB/s ± 0%   -26.76%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/clang              167MB/s ± 0%  138MB/s ± 0%   -17.42%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang  205MB/s ± 0%  439MB/s ± 0%  +114.53%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang   151MB/s ± 0%  164MB/s ± 0%    +8.41%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang            155MB/s ± 0%  165MB/s ± 0%    +6.50%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang   255MB/s ± 0%  921MB/s ± 0%  +261.50%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc              316MB/s ± 2%  267MB/s ± 1%   -15.78%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc           184MB/s ± 1%  134MB/s ± 0%   -27.57%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/gcc                196MB/s ± 0%  161MB/s ± 0%   -17.50%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc    287MB/s ± 0%  449MB/s ± 1%   +56.22%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc     182MB/s ± 0%  182MB/s ± 1%      ~     (p=0.690 n=5+5)
wuffs_gif_decode_1000k/gcc              187MB/s ± 1%  185MB/s ± 1%      ~     (p=0.056 n=5+5)
wuffs_gif_decode_anim_screencap/gcc     397MB/s ± 0%  973MB/s ± 0%  +145.42%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/clang              170MB/s ± 0%  191MB/s ± 1%   +12.52%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang             242MB/s ± 0%  312MB/s ± 2%   +29.00%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc                220MB/s ± 0%  227MB/s ± 0%    +3.31%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc               317MB/s ± 0%  369MB/s ± 1%   +16.53%  (p=0.008 n=5+5)
----

LZW is the compression method used by GIF images. Roughly speaking, LZW
is a sequence of codes, and each code emits either 1 byte (a literal
code) or multiple bytes (a copy code). The speed gain in this commit
comes from, when emitting an N-byte copy code, this now requires N/8
iterations instead of N iterations, as each iteration now writes 8 bytes
instead of 1. Literal codes, both before and after this commit, requires
a single iteration.

Decoding should therefore get faster or slower depending on whether it's
copy-code-heavy or literal-code-heavy respectively. For what it's worth,
copy-code-heavy GIF images also usually compress better.

Running script/extract-giflzw.go (or examining the cached output at
test/data/analysis/giflzw-emission-lengths.txt) on the anim_screencap
(which got faster) and 1k_color (which got slower) cases (also known as
gifplayer-muybridge.gif and hippopotamus.regular.gif) shows that the
proportion of literal codes agrees with that explanation.

----
gifplayer-muybridge.gif (all frames)
 Percent   Count  Emission_Length_Bucket
   12.78   34658           1 (Literal Code)
   14.05   38106           2
   13.25   35937           3
   10.59   28707           4
    7.85   21286           5
    6.08   16481           6
    4.85   13156           7
    3.60    9764           8
    9.34   25318    9 ..  16
    4.89   13257   17 ..  32
    4.78   12954   33 ..  64
    4.72   12806   65 .. 128
    3.02    8190  127 .. 256
    0.20     550  256+

hippopotamus.regular.gif (all frames)
 Percent   Count  Emission_Length_Bucket
   82.66     672           1 (Literal Code)
   13.04     106           2
    2.83      23           3
    0.86       7           4
    0.37       3           5
    0.25       2           6
    0.00       0           7
    0.00       0           8
    0.00       0    9 ..  16
    0.00       0   17 ..  32
    0.00       0   33 ..  64
    0.00       0   65 .. 128
    0.00       0  127 .. 256
    0.00       0  256+
----

The new algorithm also adds more CPU and RAM overhead, regardless of
whether the input GIF image's LZW data is copy-code-heavy or
literal-code-heavy. For example, the suffix table grows by 8x, from 4KiB
to 32 KiB.

The gifplayer-muybridge.gif image is also larger (472 x 298) and the
hippopotamus.regular.gif image is also smaller (36 x 28). Higher fixed
costs may have larger (negative) relative effects on decoding smaller
images.

To repeat, I think it's still a net win.

An upcoming commit will update the std/lzw/README.md file to provide
more detail on the algorithm.

Thanks to Tushar Khandelwal for the idea.
2018-10-21 14:48:40 +11:00
Nigel Tao ff92d22ea6 Read LZW input bits 4 bytes at a time, not 1
name                             old speed     new speed     delta

wuffs_gif_decode_1k_bw/clang     306MB/s ± 0%  295MB/s ± 0%   -3.62%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang  156MB/s ± 0%  163MB/s ± 0%   +4.64%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/clang       153MB/s ± 0%  179MB/s ± 0%  +17.34%  (p=0.008 n=5+5)
wuffs_gif_decode_100k/clang      147MB/s ± 0%  155MB/s ± 0%   +5.13%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang     151MB/s ± 1%  159MB/s ± 0%   +5.34%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc       319MB/s ± 0%  313MB/s ± 0%   -1.79%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc    165MB/s ± 0%  173MB/s ± 0%   +4.82%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/gcc         171MB/s ± 1%  184MB/s ± 1%   +7.48%  (p=0.008 n=5+5)
wuffs_gif_decode_100k/gcc        161MB/s ± 1%  173MB/s ± 1%   +7.32%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc       166MB/s ± 0%  179MB/s ± 1%   +7.53%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/clang       167MB/s ± 0%  185MB/s ± 0%  +10.85%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang      239MB/s ± 0%  260MB/s ± 0%   +8.96%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc         192MB/s ± 0%  211MB/s ± 0%   +9.47%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc        295MB/s ± 0%  300MB/s ± 0%   +1.65%  (p=0.008 n=5+5)
2018-10-14 22:14:02 +11:00
Nigel Tao 9573b88a02 Remove unused appendFact code path 2018-10-14 13:11:58 +11:00