Nigel Tao
3338d6d1bc
Write LZW output 8 bytes at a time, not 1
...
The benchmarks are mixed, but I think it's still a net win.
----
name old speed new speed delta
wuffs_gif_decode_1k_bw/clang 258MB/s ± 0% 253MB/s ± 1% -2.04% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang 159MB/s ± 0% 116MB/s ± 0% -26.76% (p=0.008 n=5+5)
wuffs_gif_decode_10k/clang 167MB/s ± 0% 138MB/s ± 0% -17.42% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang 205MB/s ± 0% 439MB/s ± 0% +114.53% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang 151MB/s ± 0% 164MB/s ± 0% +8.41% (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang 155MB/s ± 0% 165MB/s ± 0% +6.50% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang 255MB/s ± 0% 921MB/s ± 0% +261.50% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/gcc 316MB/s ± 2% 267MB/s ± 1% -15.78% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc 184MB/s ± 1% 134MB/s ± 0% -27.57% (p=0.008 n=5+5)
wuffs_gif_decode_10k/gcc 196MB/s ± 0% 161MB/s ± 0% -17.50% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc 287MB/s ± 0% 449MB/s ± 1% +56.22% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc 182MB/s ± 0% 182MB/s ± 1% ~ (p=0.690 n=5+5)
wuffs_gif_decode_1000k/gcc 187MB/s ± 1% 185MB/s ± 1% ~ (p=0.056 n=5+5)
wuffs_gif_decode_anim_screencap/gcc 397MB/s ± 0% 973MB/s ± 0% +145.42% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/clang 170MB/s ± 0% 191MB/s ± 1% +12.52% (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang 242MB/s ± 0% 312MB/s ± 2% +29.00% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/gcc 220MB/s ± 0% 227MB/s ± 0% +3.31% (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc 317MB/s ± 0% 369MB/s ± 1% +16.53% (p=0.008 n=5+5)
----
LZW is the compression method used by GIF images. Roughly speaking, LZW
is a sequence of codes, and each code emits either 1 byte (a literal
code) or multiple bytes (a copy code). The speed gain in this commit
comes from, when emitting an N-byte copy code, this now requires N/8
iterations instead of N iterations, as each iteration now writes 8 bytes
instead of 1. Literal codes, both before and after this commit, requires
a single iteration.
Decoding should therefore get faster or slower depending on whether it's
copy-code-heavy or literal-code-heavy respectively. For what it's worth,
copy-code-heavy GIF images also usually compress better.
Running script/extract-giflzw.go (or examining the cached output at
test/data/analysis/giflzw-emission-lengths.txt) on the anim_screencap
(which got faster) and 1k_color (which got slower) cases (also known as
gifplayer-muybridge.gif and hippopotamus.regular.gif) shows that the
proportion of literal codes agrees with that explanation.
----
gifplayer-muybridge.gif (all frames)
Percent Count Emission_Length_Bucket
12.78 34658 1 (Literal Code)
14.05 38106 2
13.25 35937 3
10.59 28707 4
7.85 21286 5
6.08 16481 6
4.85 13156 7
3.60 9764 8
9.34 25318 9 .. 16
4.89 13257 17 .. 32
4.78 12954 33 .. 64
4.72 12806 65 .. 128
3.02 8190 127 .. 256
0.20 550 256+
hippopotamus.regular.gif (all frames)
Percent Count Emission_Length_Bucket
82.66 672 1 (Literal Code)
13.04 106 2
2.83 23 3
0.86 7 4
0.37 3 5
0.25 2 6
0.00 0 7
0.00 0 8
0.00 0 9 .. 16
0.00 0 17 .. 32
0.00 0 33 .. 64
0.00 0 65 .. 128
0.00 0 127 .. 256
0.00 0 256+
----
The new algorithm also adds more CPU and RAM overhead, regardless of
whether the input GIF image's LZW data is copy-code-heavy or
literal-code-heavy. For example, the suffix table grows by 8x, from 4KiB
to 32 KiB.
The gifplayer-muybridge.gif image is also larger (472 x 298) and the
hippopotamus.regular.gif image is also smaller (36 x 28). Higher fixed
costs may have larger (negative) relative effects on decoding smaller
images.
To repeat, I think it's still a net win.
An upcoming commit will update the std/lzw/README.md file to provide
more detail on the algorithm.
Thanks to Tushar Khandelwal for the idea.
2018-10-21 14:48:40 +11:00
Nigel Tao
97f2570977
Fix codegen for skip_fast
...
args[0] is actual, args[1] is worst_case.
2018-10-14 12:52:52 +11:00
Nigel Tao
7be9c39283
Move num_loops out of the image_config
...
For the GIF format, it isn't necessarily before the first frame.
2018-10-13 17:00:45 +11:00
Nigel Tao
8b1ffec576
Make struct impls private (opaque pointers)
...
This gives us flexibility to change sizeof(wuffs_foo__bar__struct)
across Wuffs versions, while retaining ABI / API compatibility.
In particular, this lets us add and remove fields.
2018-10-06 10:33:47 +10:00
Nigel Tao
26a448450e
Move C++ method impls inside struct definitions
2018-10-06 10:06:07 +10:00
Nigel Tao
5b82dd905a
Separate C struct declaration and definition
2018-10-06 09:45:03 +10:00
Nigel Tao
e26ba24fbf
Add wuffs_foo__bar__struct names
2018-10-06 09:41:50 +10:00
Nigel Tao
dc17398d64
Generate "WUFFS C HEADER ENDS HERE"
...
Future commits will mean more than one "#ifdef WUFFS_IMPLEMENTATION".
2018-10-06 09:12:04 +10:00
Nigel Tao
c4edf6ac25
Add sizeof__wuffs_foo__bar functions
2018-09-23 09:26:08 +10:00
Nigel Tao
ad02f2ea62
Have pixbuf_len return uint64_t not size_t
2018-09-15 12:50:39 +10:00
Nigel Tao
a12c45bb7f
Rename io_position_reader to reader_io_position
2018-09-15 09:19:34 +10:00
Nigel Tao
8c6cc80b57
Add wuffs_base__status__is_complete
2018-09-15 09:18:53 +10:00
Nigel Tao
6fa3d5a9f5
have io_writer.set also reset meta.pos
2018-09-15 08:47:30 +10:00
Nigel Tao
6fed251b40
Split an io_buffer's fields into data and meta
2018-09-15 08:45:50 +10:00
Nigel Tao
990463bdac
Move u8 subslice methods from private to public
2018-09-09 21:43:34 +10:00
Nigel Tao
180ce5e481
Add wuffs_base__malloc_slice_uxx functions
2018-09-09 21:31:37 +10:00
Nigel Tao
399a7af6ef
Fix comment about palette pointer alignment
2018-09-08 11:21:40 +10:00
Nigel Tao
68e553f305
Tweak wuffs_base__slice_u8 formatting
2018-09-08 11:12:34 +10:00
Nigel Tao
724b136bf8
Remove the obsolete set_palette method
2018-09-08 11:11:36 +10:00
Nigel Tao
2c7fd8058a
Repurpose a pixbuf's plane 3 for the palette
2018-09-08 11:03:22 +10:00
Nigel Tao
fbbdc412d1
Rename work_buffer_size to workbuf_len
2018-09-08 09:06:56 +10:00
Nigel Tao
ca940b0c56
Rename pixbuf_size to pixbuf_len
2018-09-08 08:47:34 +10:00
Nigel Tao
5bf7c5c051
Add image_config.first_frame_io_position
...
Also fix a type typo for image_config.first_frame_is_opaque.
2018-09-08 08:40:45 +10:00
Nigel Tao
91451e8095
Add io_buffer.io_position_{read,writ}er methods
2018-09-08 08:27:19 +10:00
Nigel Tao
555a72d7a9
Add a decode_frame_options type
2018-09-02 15:08:00 +10:00
Nigel Tao
8b1e023e6a
Add image_config.work_buffer_size
2018-09-02 14:56:53 +10:00
Nigel Tao
a34cc5311e
Place the frame_config's pos before it not after
2018-08-26 23:58:03 +10:00
Nigel Tao
9c04249bfe
Add warnings as another status code category
2018-08-26 23:22:45 +10:00
Nigel Tao
814507e848
First sketch of reset_for_decode_frame
2018-08-26 21:18:08 +10:00
Nigel Tao
132b54378c
Remove frame_config.palette_changed
2018-08-26 17:22:29 +10:00
Nigel Tao
7798beaa8c
Add I/O positions
2018-08-26 16:31:19 +10:00
Nigel Tao
d47bf4e4e5
Fix wuffs_base__frame_config__blend
2018-08-19 18:06:44 +10:00
Nigel Tao
babd6e667d
Have "wuffs genlib -skipgen" still build base libs
2018-08-19 17:36:27 +10:00
Nigel Tao
f836d3b743
Rename "check_wuffs_version called twice"
2018-08-19 17:08:36 +10:00
Nigel Tao
fbb8bd44b8
Make blend an enum, not just a bool
2018-08-19 17:00:00 +10:00
Nigel Tao
9367cd800b
Remove the (pointer-typed) private_impl.status
2018-08-19 11:32:31 +10:00
Nigel Tao
5e8801d866
Promote pixcfg field out of private_impl
2018-08-18 12:29:28 +10:00
Nigel Tao
c1af1e2c82
Rename $(etc) to [etc]
2018-08-18 10:11:43 +10:00
Nigel Tao
4e7ef5fb88
Rename I/O bounds fields to mark and limit
2018-08-18 09:38:02 +10:00
Nigel Tao
6236e7205f
Remove packageid
2018-08-12 21:44:49 +10:00
Nigel Tao
eec0fce647
Change error "?foo" to status "?foo"
2018-08-12 21:31:56 +10:00
Nigel Tao
203b45e869
Remove status values
2018-08-12 19:36:29 +10:00
Nigel Tao
44e99d79cf
Add comment about comparing status strings
2018-08-12 19:11:45 +10:00
Nigel Tao
c499f03bc7
Delete obsolete wuffs_foo__status__string funcs
2018-08-12 19:10:24 +10:00
Nigel Tao
b840c80040
Make the status type a const char*, not a struct
2018-08-12 16:05:14 +10:00
Nigel Tao
e0311e3bb2
Don't generate header defs for private statuses
2018-08-12 14:08:04 +10:00
Nigel Tao
b385c30b4f
Add a "?" prefix to non-built-in status messages
2018-08-12 14:07:40 +10:00
Nigel Tao
0ed0ead057
Generate named strings for status messages
2018-08-12 11:28:13 +10:00
Nigel Tao
1462084531
Add a "?" or "$" prefix to status messages
2018-08-12 10:50:22 +10:00
Nigel Tao
1e8438f43b
Have cgen code call wuffs_base__status methods
2018-08-12 09:44:58 +10:00