Commit Graph
631 Commits
Author SHA1 Message Date
Nigel Tao 53da68fe4b Refine parse_number_f64's powers_of_10 table
Refine means changing the base-10 exponents from "-348 ..= +340 stepping
by 8" to "-326 ..= +310 stepping by 1".

Binary size, before:
15992 gen/lib/c/clang-5.0-dynamic/wuffs-base-f64conv.lo
16232 gen/lib/c/clang-5.0-static/wuffs-base-f64conv.o
17384 gen/lib/c/gcc-dynamic/wuffs-base-f64conv.lo
17384 gen/lib/c/gcc-static/wuffs-base-f64conv.o

After:
22232 gen/lib/c/clang-5.0-dynamic/wuffs-base-f64conv.lo
22408 gen/lib/c/clang-5.0-static/wuffs-base-f64conv.o
23816 gen/lib/c/gcc-dynamic/wuffs-base-f64conv.lo
23816 gen/lib/c/gcc-static/wuffs-base-f64conv.o

$ g++ -O3 script/process-json-numbers.c
$ time ./a.out -parse-number-f64 < citylots.json
Before/After:
real	0m1.455s
real	0m1.432s

citylots.json is from github.com/zemirco/sf-city-lots-json
2020-07-05 13:58:49 +10:00
Nigel Tao fc1b33a0ff Remove redundant if in MPB__parse_number_f64 2020-07-03 23:47:51 +10:00
Nigel Tao 19b3ce24a3 Optimize high_prec_dec__round_just_enough
name                                                               old time/op  new time/op  delta
wuffs_strconv_render_number_f64_just_enough_fractions/clang5       56.4µs ± 1%  56.3µs ± 1%     ~     (p=1.000 n=5+5)
wuffs_strconv_render_number_f64_just_enough_small_integers/clang5  4.12µs ± 2%  1.00µs ± 1%  -75.65%  (p=0.008 n=5+5)
wuffs_strconv_render_number_f64_just_enough_fractions/gcc7         54.3µs ± 0%  54.2µs ± 0%     ~     (p=0.151 n=5+5)
wuffs_strconv_render_number_f64_just_enough_small_integers/gcc7    4.16µs ± 0%  1.01µs ± 0%  -75.77%  (p=0.000 n=4+5)
2020-07-03 23:44:37 +10:00
Nigel Tao b9afc26387 Add TOKEN__VBD__STRING__CHAIN_ETC 2020-07-03 13:36:13 +10:00
Nigel Tao a6031b6d2e Add wuffs_base__utf_8__next_from_end 2020-07-02 15:08:54 +10:00
Nigel Tao 991e1b2667 wuffs gen -version=0.3.0-alpha.5 2020-07-01 12:22:17 +10:00
Nigel Tao c94ccef400 Make status and vtable names arrays-of-char
Binary size, before:
176288 gen/lib/c/clang-5.0-dynamic/libwuffs.so
  6216 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
216480 gen/lib/c/clang-5.0-static/libwuffs.a
  6144 gen/lib/c/clang-5.0-static/wuffs-base-core.o
196568 gen/lib/c/gcc-dynamic/libwuffs.so
  6736 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
246432 gen/lib/c/gcc-static/libwuffs.a
  6736 gen/lib/c/gcc-static/wuffs-base-core.o

After:
172192 gen/lib/c/clang-5.0-dynamic/libwuffs.so
  5192 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
214400 gen/lib/c/clang-5.0-static/libwuffs.a
  5192 gen/lib/c/clang-5.0-static/wuffs-base-core.o
192472 gen/lib/c/gcc-dynamic/libwuffs.so
  5656 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
240752 gen/lib/c/gcc-static/libwuffs.a
  5656 gen/lib/c/gcc-static/wuffs-base-core.o
2020-07-01 12:16:14 +10:00
Nigel Tao 89ceb9fabc Add wuffs_base__render_number_f64 2020-07-01 12:03:20 +10:00
Nigel Tao 03f85920be Make render_number_etc conversions explicit 2020-06-22 13:56:57 +10:00
Nigel Tao ec5200cb99 Make status and vtable names const pointers 2020-06-22 13:52:29 +10:00
Nigel Tao 668e92cb81 Spin out base-utf8 sub-module
Before:
8224 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
8200 gen/lib/c/clang-5.0-static/wuffs-base-core.o
8704 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
8920 gen/lib/c/gcc-static/wuffs-base-core.o

After:
6216 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
2736 gen/lib/c/clang-5.0-dynamic/wuffs-base-utf8.lo
6216 gen/lib/c/clang-5.0-static/wuffs-base-core.o
2712 gen/lib/c/clang-5.0-static/wuffs-base-utf8.o
6728 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
3008 gen/lib/c/gcc-dynamic/wuffs-base-utf8.lo
6728 gen/lib/c/gcc-static/wuffs-base-core.o
3224 gen/lib/c/gcc-static/wuffs-base-utf8.o
2020-06-22 13:40:03 +10:00
Nigel Tao 22a09b4133 Spin out base-i64conv sub-module
Before:
12624 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
13032 gen/lib/c/clang-5.0-static/wuffs-base-core.o
12184 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
12408 gen/lib/c/gcc-static/wuffs-base-core.o

After:
 8224 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
 5608 gen/lib/c/clang-5.0-dynamic/wuffs-base-i64conv.lo
 8200 gen/lib/c/clang-5.0-static/wuffs-base-core.o
 6032 gen/lib/c/clang-5.0-static/wuffs-base-i64conv.o
 8704 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
 4952 gen/lib/c/gcc-dynamic/wuffs-base-i64conv.lo
 8920 gen/lib/c/gcc-static/wuffs-base-core.o
 4912 gen/lib/c/gcc-static/wuffs-base-i64conv.o
2020-06-21 22:17:42 +10:00
Nigel Tao f5fbc5d8e7 Rename initialize_flags argument 2020-06-21 22:02:20 +10:00
Nigel Tao d40a386211 Add wuffs_base__render_number_{i,u}64 2020-06-21 21:57:48 +10:00
Nigel Tao 00cc8a50aa wuffs gen -version=0.3.0-alpha.4 2020-06-17 21:27:28 +10:00
Nigel Tao d377dcaea8 Don't use #warning (a GCC notion) with MSVC 2020-06-17 21:24:14 +10:00
Nigel Tao 824b87bb86 Roll back cb198413 re MSVC __cplusplus macro
Commit cb19841358 "Work around MSVC's
__cplusplus regarding C++11" did not fix compiler errors with older MSVC
versions as hoped.
2020-06-17 21:18:36 +10:00
Nigel Tao 025f9c208e Roll back 196920ee unique_ptr constructors
Commit 196920ee91 "Spell out
std::unique_ptr constructor calls" did not fix compiler errors with
older MSVC versions as hoped.
2020-06-17 21:12:07 +10:00
Nigel Tao a7418b76fc wuffs gen -version=0.3.0-alpha.3 2020-06-17 15:57:23 +10:00
Nigel Tao 196920ee91 Spell out std::unique_ptr constructor calls 2020-06-17 15:56:46 +10:00
Nigel Tao c8026c91ff wuffs gen -version=0.3.0-alpha.2 2020-06-17 06:46:00 +10:00
Nigel Tao cb19841358 Work around MSVC's __cplusplus regarding C++11 2020-06-17 06:39:45 +10:00
Nigel Tao 30793928d0 wuffs gen -version=0.3.0-alpha.1 2020-06-11 23:02:02 +10:00
Nigel Tao 533b84b3b1 Simplify WUFFS_VERSION_ETC macros 2020-06-11 23:01:50 +10:00
Nigel Tao b82396a3c6 Stop dumbindent dropping blank lines near braces 2020-06-10 21:06:06 +10:00
Nigel Tao 66b0a12b6c Add json.EXPECT_ETC constants 2020-06-09 23:50:35 +10:00
Nigel Tao 53d5f5155c Have dumbindent break after some '{' and ';'s 2020-06-07 21:52:24 +10:00
Nigel Tao 709e169955 Have cgen line-break some long expressions 2020-06-07 10:12:47 +10:00
Nigel Tao 0ad5f9b617 Have dumbindent no longer treat labels specially 2020-06-06 22:38:29 +10:00
Nigel Tao f45f01f4f3 Update clang-format from v5 to v9 2020-06-05 14:06:56 +10:00
Nigel Tao d0dec081a6 Tweak cgen+dumbindent output 2020-06-05 10:22:14 +10:00
Nigel Tao 12b0f4c0bc Change the default -cformatter to dumbindent
A follow-up commit will remove the -cformatter flag entirely.

Formatting the generated C code is now a small fraction of where "wuffs
gen" spends its time.

----
$ # Before.
$ time wuffs gen > /dev/null
real	0m0.932s
user	0m0.837s
sys	0m0.187s

$ # After.
$ time wuffs gen > /dev/null
real	0m0.186s
user	0m0.170s
sys	0m0.069s

$ time wuffs gen -cformatter= > /dev/null
real	0m0.184s
user	0m0.170s
sys	0m0.059s
----
2020-06-04 23:59:20 +10:00
Nigel Tao b2dc84105a Clean up more wuffs-c output (before clang-format) 2020-06-04 23:26:15 +10:00
Nigel Tao 58a48d5a54 Don't run the base package through the C-formatter
----
$ # Before.
$ time wuffs gen > /dev/null
real	0m1.427s
user	0m1.272s
sys	0m0.245s

$ # After.
$ time wuffs gen > /dev/null
real	0m0.953s
user	0m0.864s
sys	0m0.188s
----
2020-06-03 23:31:54 +10:00
Nigel Tao 71528b33dd Rename frame_config.update to frame_config.set 2020-06-03 11:34:57 +10:00
Nigel Tao 6c83516afa Ensure that you cannot return a suspension 2020-06-03 11:08:23 +10:00
Nigel Tao ed9025c8dd Make swizzle_etc_reader sign conversion explicit 2020-06-02 23:29:42 +10:00
Nigel Tao f73fc7721a Replace wuffs_base__make_status(x).repr with x 2020-06-02 23:25:47 +10:00
Nigel Tao de1e274ad2 Remove io_reader.take 2020-06-02 23:08:24 +10:00
Nigel Tao 8b21a7600a Add swizzle_interleaved_from_reader 2020-06-02 23:04:22 +10:00
Nigel Tao 54196c4e80 Rename pixel_swizzler.swizzle_interleaved 2020-05-29 16:54:05 +10:00
Nigel Tao 6537a817b7 Roll back the two previous "@I/O redirect" commits
See the previous commit for the rationale.
2020-05-29 11:27:51 +10:00
Nigel Tao 49023afd48 Performance mystery: delete unused string constant
This commit deletes the definition of the `const char*
wuffs_base__note__i_o_redirect` global variable. This variable is not
used anywhere (after the previous commit removed references to it).

Deleting this one line of code (two if you count the declaration, not
just the definition) can have a dramatic effect on seemingly unrelated
performance micro-benchmarks. Some numbers get better (e.g. +5%), some
numbers get worse (e.g. -10%). The same micro-benchmark can get faster
on one C compiler but slower on another.

It is a mystery why this happens. This small, self-contained commit (as
well as the previous one, which set it up) will be immediately followed
by a roll back, but it is committed anyway so that we can refer to these
numbers in the git log. To reproduce:

----
$ git clone https://github.com/google/wuffs.git
$ cd wuffs
$ gcc --version | head -n 1
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0

$ # Check out the parent commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT^
$ gcc -O3 -Wall -std=c99 test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1125 ns/op	     756.762 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.652 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.785 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.697 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1132 ns/op	     752.365 MB/s

$ # Check out this commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT
$ gcc -O3 -Wall -std=c99 test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1200 ns/op	     709.617 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1203 ns/op	     707.651 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1203 ns/op	     707.976 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1233 ns/op	     690.663 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1203 ns/op	     708.153 MB/s

$ # Dropping the "-std=c99" also changes the numbers.

$ # Check out the parent commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT^
$ gcc -O3 -Wall          test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1229 ns/op	     693.226 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1230 ns/op	     692.254 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1230 ns/op	     692.486 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1234 ns/op	     689.986 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1232 ns/op	     691.480 MB/s

$ # Check out this commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT
$ gcc -O3 -Wall          test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1129 ns/op	     754.103 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.849 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1135 ns/op	     750.622 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1150 ns/op	     740.731 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1135 ns/op	     750.609 MB/s

$ ldd ./a.out
	linux-vdso.so.1 (0x00007ffd9b1f2000)
	libgtk3-nocsd.so.0 => /usr/lib/x86_64-linux-gnu/libgtk3-nocsd.so.0 (0x00007f9b46f60000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f9b46b6f000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f9b4696b000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f9b4674c000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f9b5b59a000)
$ rm a.out
----

Some more benchmark numbers before/after this commit:

----
name                                                old speed      new speed      delta

wuffs_deflate_decode_1k_full_init/clang5             103MB/s ± 1%   105MB/s ± 1%   +2.25%  (p=0.000 n=9+10)
wuffs_deflate_decode_1k_part_init/clang5             121MB/s ± 0%   122MB/s ± 0%     ~     (p=1.000 n=9+9)
wuffs_deflate_decode_10k_full_init/clang5            148MB/s ± 1%   149MB/s ± 0%     ~     (p=0.059 n=9+8)
wuffs_deflate_decode_10k_part_init/clang5            151MB/s ± 0%   151MB/s ± 0%     ~     (p=0.968 n=9+10)
wuffs_deflate_decode_100k_just_one_read/clang5       172MB/s ± 0%   171MB/s ± 1%   -0.44%  (p=0.001 n=9+9)
wuffs_deflate_decode_100k_many_big_reads/clang5      149MB/s ± 0%   149MB/s ± 1%   -0.56%  (p=0.000 n=10+9)

wuffs_deflate_decode_1k_full_init/gcc7               104MB/s ± 1%   102MB/s ± 1%   -2.45%  (p=0.000 n=9+10)
wuffs_deflate_decode_1k_part_init/gcc7               121MB/s ± 0%   121MB/s ± 0%   +0.46%  (p=0.000 n=9+10)
wuffs_deflate_decode_10k_full_init/gcc7              147MB/s ± 0%   153MB/s ± 0%   +3.75%  (p=0.000 n=8+10)
wuffs_deflate_decode_10k_part_init/gcc7              150MB/s ± 1%   155MB/s ± 0%   +3.98%  (p=0.000 n=9+10)
wuffs_deflate_decode_100k_just_one_read/gcc7         184MB/s ± 0%   194MB/s ± 1%   +5.43%  (p=0.000 n=9+10)
wuffs_deflate_decode_100k_many_big_reads/gcc7        154MB/s ± 0%   158MB/s ± 0%   +2.45%  (p=0.000 n=9+10)

wuffs_gif_decode_1k_bw/clang5                        281MB/s ± 1%   278MB/s ± 1%   -0.92%  (p=0.003 n=10+9)
wuffs_gif_decode_1k_color_full_init/clang5          97.8MB/s ± 1%  93.7MB/s ± 3%   -4.26%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_part_init/clang5           117MB/s ± 1%   115MB/s ± 1%   -1.41%  (p=0.000 n=9+10)
wuffs_gif_decode_10k_bgra/clang5                     463MB/s ± 1%   455MB/s ± 1%   -1.68%  (p=0.000 n=10+10)
wuffs_gif_decode_10k_indexed/clang5                  124MB/s ± 1%   121MB/s ± 1%   -2.31%  (p=0.000 n=9+9)
wuffs_gif_decode_20k/clang5                          149MB/s ± 1%   146MB/s ± 1%   -1.95%  (p=0.000 n=10+10)
wuffs_gif_decode_100k_artificial/clang5              313MB/s ± 1%   307MB/s ± 0%   -1.94%  (p=0.000 n=9+7)
wuffs_gif_decode_100k_realistic/clang5               135MB/s ± 1%   133MB/s ± 1%   -1.18%  (p=0.000 n=10+8)
wuffs_gif_decode_1000k_full_init/clang5              136MB/s ± 1%   132MB/s ± 4%   -2.27%  (p=0.023 n=10+10)
wuffs_gif_decode_1000k_part_init/clang5              136MB/s ± 1%   132MB/s ± 3%   -2.96%  (p=0.000 n=9+10)
wuffs_gif_decode_anim_screencap/clang5               644MB/s ± 1%   621MB/s ± 3%   -3.51%  (p=0.000 n=10+10)

wuffs_gif_decode_1k_bw/gcc7                          290MB/s ± 1%   287MB/s ± 1%   -1.18%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_full_init/gcc7            91.7MB/s ± 1%  88.2MB/s ± 1%   -3.85%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_part_init/gcc7             107MB/s ± 1%   103MB/s ± 1%   -4.12%  (p=0.000 n=9+10)
wuffs_gif_decode_10k_bgra/gcc7                       370MB/s ± 1%   344MB/s ± 1%   -6.98%  (p=0.000 n=10+9)
wuffs_gif_decode_10k_indexed/gcc7                    113MB/s ± 2%   104MB/s ± 1%   -8.31%  (p=0.000 n=10+8)
wuffs_gif_decode_20k/gcc7                            139MB/s ± 1%   127MB/s ± 3%   -8.49%  (p=0.000 n=10+10)
wuffs_gif_decode_100k_artificial/gcc7                299MB/s ± 0%   280MB/s ± 1%   -6.43%  (p=0.000 n=9+8)
wuffs_gif_decode_100k_realistic/gcc7                 123MB/s ± 1%   111MB/s ± 1%  -10.21%  (p=0.000 n=10+8)
wuffs_gif_decode_1000k_full_init/gcc7                124MB/s ± 1%   112MB/s ± 1%   -9.34%  (p=0.000 n=10+8)
wuffs_gif_decode_1000k_part_init/gcc7                125MB/s ± 1%   112MB/s ± 1%  -10.19%  (p=0.000 n=10+9)
wuffs_gif_decode_anim_screencap/gcc7                 622MB/s ± 1%   599MB/s ± 3%   -3.68%  (p=0.000 n=9+10)

wuffs_json_decode_1k/clang5                          628MB/s ± 1%   628MB/s ± 1%     ~     (p=0.842 n=9+10)
wuffs_json_decode_21k_formatted/clang5               331MB/s ± 1%   331MB/s ± 0%     ~     (p=0.720 n=10+9)
wuffs_json_decode_26k_compact/clang5                 521MB/s ± 1%   521MB/s ± 0%     ~     (p=0.549 n=10+9)
wuffs_json_decode_217k_stringy/clang5                432MB/s ± 1%   432MB/s ± 1%     ~     (p=0.780 n=10+9)

wuffs_json_decode_1k/gcc7                            745MB/s ± 0%   703MB/s ± 0%   -5.70%  (p=0.000 n=9+10)
wuffs_json_decode_21k_formatted/gcc7                 418MB/s ± 1%   400MB/s ± 1%   -4.44%  (p=0.000 n=10+8)
wuffs_json_decode_26k_compact/gcc7                   554MB/s ± 1%   511MB/s ± 1%   -7.72%  (p=0.000 n=9+10)
wuffs_json_decode_217k_stringy/gcc7                  452MB/s ± 1%   422MB/s ± 1%   -6.58%  (p=0.000 n=9+10)
----
2020-05-29 11:21:32 +10:00
Nigel Tao 844fc9b5ee Temporarily avoid using base."@I/O redirect"
This commit (and the next) will soon be followed by a rollback.
2020-05-29 09:53:30 +10:00
Nigel Tao 302afb7ce5 Add const to wuffs_base__pixel_swizzler__func arg 2020-05-28 00:07:45 +10:00
Nigel Tao 91dcf8f582 Add io_reader.limited_copy_u32_to_slice 2020-05-27 23:47:10 +10:00
Nigel Tao 1ed0f89948 Rename copy_n32_etc to limited_copy_u32_etc 2020-05-27 19:55:06 +10:00
Nigel Tao e74fd729a7 Re-organize internal/cgen/base/io-private.h 2020-05-27 17:06:47 +10:00
Nigel Tao 055e944584 Make cgen io_reader pointers' elements const 2020-05-27 14:28:31 +10:00
Nigel Tao dcb81a85bb Prepare to decode BMP embedding a JPEG or PNG 2020-05-27 13:37:54 +10:00