Commit Graph
83 Commits
Author SHA1 Message Date
Nigel Tao 30b54616a8 Check copy_from_history32's distance. 2017-11-09 12:53:19 +11:00
Nigel Tao 848d66ffdf Tighten the Huffman n_bits invariant. 2017-11-07 09:30:16 +11:00
Nigel Tao f6e072fe77 Add some more "inconsistent n_bits" checks.
This uncovered a bug in the decode_huffman_fast function. A follow up commit
will actually fix the bug.

For what it's worth, some benchmark numbers are below, but they're
possibly bogus, as we might be decoding incorrect (and truncated) output
for some inputs. Everything since "f968950 Read bits up front in
decode_huffman_fast" landed possibly has bogus numbers too.

name                           old speed     new speed     delta
puffs_flate_decode_100k/clang  194MB/s ± 0%  204MB/s ± 1%   +5.02%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc    180MB/s ± 3%  202MB/s ± 1%  +12.09%  (p=0.008 n=5+5)
2017-11-05 09:23:49 +11:00
Nigel Tao 8fafcbcb31 Tweak the flate end_of_block check. 2017-11-04 14:54:56 +11:00
Nigel Tao aa1f0078db Add decode_huffman_fast.
It's not fast yet, and the immediate impact is indeed a significant
performance loss, but follow-up commits should make it faster.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.41GB/s ± 0%  2.40GB/s ± 1%     ~     (p=0.222 n=5+5)
puffs_adler32_100k/clang       2.41GB/s ± 1%  2.39GB/s ± 1%   -0.97%  (p=0.016 n=5+5)
puffs_flate_decode_1k/clang     116MB/s ± 5%   115MB/s ± 0%     ~     (p=0.310 n=5+5)
puffs_flate_decode_10k/clang    145MB/s ± 0%   139MB/s ± 0%   -4.18%  (p=0.016 n=4+5)
puffs_flate_decode_100k/clang   164MB/s ± 5%   158MB/s ± 1%     ~     (p=0.151 n=5+5)
puffs_zlib_decode_10k/clang     135MB/s ± 2%   131MB/s ± 0%   -2.84%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    154MB/s ± 1%   148MB/s ± 2%   -4.09%  (p=0.016 n=4+5)

puffs_adler32_10k/gcc          3.13GB/s ± 4%  3.19GB/s ± 0%   +1.94%  (p=0.032 n=5+5)
puffs_adler32_100k/gcc         3.14GB/s ± 3%  3.20GB/s ± 3%     ~     (p=0.056 n=5+5)
puffs_flate_decode_1k/gcc       122MB/s ± 1%    94MB/s ± 1%  -22.84%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      143MB/s ± 0%   110MB/s ± 0%  -23.24%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     158MB/s ± 0%   118MB/s ± 0%  -24.98%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc       136MB/s ± 0%   119MB/s ± 1%  -12.63%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      150MB/s ± 1%   124MB/s ± 2%  -17.17%  (p=0.008 n=5+5)
2017-11-04 14:45:11 +11:00
Nigel Tao ded044da41 Add a flate end_of_block field. 2017-11-04 14:12:38 +11:00
Nigel Tao 4810db3994 Rename decode_huffman to decode_huffman_slow. 2017-11-04 13:38:24 +11:00
Nigel Tao c3420dd138 Refactor std/flate/*.puffs code. 2017-11-04 13:31:39 +11:00
Nigel Tao c0c023e1cf Remove the writer1.length method. 2017-10-26 13:15:24 +11:00
Nigel Tao 5052b16f2d Rename writer1.slice to writer1.since_mark. 2017-10-26 13:03:19 +11:00
Nigel Tao 474a0d2ed7 Make mark a method, not a keyword. 2017-10-26 12:31:27 +11:00
Nigel Tao 36f5ae9bf4 Move the "mark in.dst" into the flate decode loop. 2017-10-26 11:20:42 +11:00
Nigel Tao ac793d33bc Generate placeholder code for "mark in.dst". 2017-10-22 13:57:37 +11:00
Nigel Tao 76f7621221 Re-order some decode_huffman checks.
name                           old speed     new speed     delta
puffs_flate_decode_1k/clang    112MB/s ± 1%  123MB/s ± 0%  +10.03%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang   135MB/s ± 0%  146MB/s ± 0%   +7.81%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang  154MB/s ± 0%  166MB/s ± 0%   +7.61%  (p=0.016 n=5+4)
puffs_zlib_decode_10k/clang    128MB/s ± 0%  138MB/s ± 0%   +7.79%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang   145MB/s ± 0%  156MB/s ± 0%   +7.33%  (p=0.016 n=5+4)
puffs_flate_decode_1k/gcc      119MB/s ± 0%  128MB/s ± 0%   +7.49%  (p=0.029 n=4+4)
puffs_flate_decode_10k/gcc     138MB/s ± 1%  146MB/s ± 0%   +6.18%  (p=0.016 n=5+4)
puffs_flate_decode_100k/gcc    153MB/s ± 0%  164MB/s ± 0%   +6.92%  (p=0.029 n=4+4)
puffs_zlib_decode_10k/gcc      132MB/s ± 0%  140MB/s ± 0%   +6.13%  (p=0.016 n=5+4)
puffs_zlib_decode_100k/gcc     147MB/s ± 0%  156MB/s ± 0%   +6.48%  (p=0.016 n=5+4)
2017-10-21 17:19:43 +11:00
Nigel Tao 2639f8f46a Rename std/flate's decoder to flate_decoder. 2017-10-21 13:05:19 +11:00
Nigel Tao 1c75edb32e Calculate the zlib checksum. 2017-10-21 12:38:23 +11:00
Nigel Tao 6492c52156 Add a ~+ operator. 2017-10-19 16:50:05 +11:00
Nigel Tao e7d01e7b2a Fix flate decoding across multiple I/O calls. 2017-10-14 16:27:53 +11:00
Nigel Tao c1789e0065 Rename some variables for clarity. 2017-10-14 11:24:40 +11:00
Nigel Tao b402429eee Remove some redundant inequalities. 2017-10-13 14:55:15 +11:00
Nigel Tao c99fdaf63d Actually copy from the flate decoder's history. 2017-10-13 14:50:34 +11:00
Nigel Tao 0384c5e4a8 Rename the copy_from_xxx methods for consistency. 2017-10-13 10:59:47 +11:00
Nigel Tao 66f712039b Prepare for introducing copy_from_slice. 2017-10-13 10:30:22 +11:00
Nigel Tao 36ba4b866c Calculate the length-distance for a history copy. 2017-10-12 16:06:28 +11:00
Nigel Tao d4372cb5b8 Change license to Apache 2.
Also remove explicit PATENTS file. The new LICENSE file already
discusses patents.

Note that the Puffs project has not yet been publicly released.
2017-10-12 11:17:41 +11:00
Nigel Tao c3ae0534df Add a writer1.available method. 2017-10-07 16:15:17 +11:00
Nigel Tao d275b379a3 Remove the idea of limited reads and writes. 2017-10-07 15:32:00 +11:00
Nigel Tao 585ea2024d Drop the "?" from "copy_from32?".
Also add a PUFFS_COROUTINE_SUSPENSION_POINT_MAYBE_SUSPEND macro.

Also add a loop to decoder.decode, as the code generator was previously
(incorrectly) not generating a coro_susp_point at the end of the
function.
2017-10-07 14:34:31 +11:00
Nigel Tao 0e09aa8c10 Call copy_from32 in a trival 1-iteration loop.
Follow-up commits will re-try copy_from32's across I/O boundaries.
2017-10-07 11:50:50 +11:00
Nigel Tao 010c4db54f Allow explicit returns of built-in status codes. 2017-10-06 17:34:58 +11:00
Nigel Tao 2e883fcc23 Drop the "?" from "copy_history32?".
This makes the caller, not the implementation, responsible for detecting
short reads and writes. This (the lack of "?") is consistent with the
slice.copy_from method.

name                           old speed     new speed     delta
puffs_flate_decode_1k/clang    117MB/s ± 6%  120MB/s ± 0%   +2.31%  (p=0.016 n=5+5)
puffs_flate_decode_10k/clang   153MB/s ± 1%  155MB/s ± 0%   +1.16%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang  168MB/s ± 1%  177MB/s ± 0%   +5.41%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc      127MB/s ± 1%  143MB/s ± 0%  +12.15%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc     145MB/s ± 0%  180MB/s ± 1%  +24.00%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc    163MB/s ± 0%  212MB/s ± 1%  +29.90%  (p=0.008 n=5+5)
2017-10-06 17:02:09 +11:00
Nigel Tao a1271222a4 Call copy_history32 in a trival 1-iteration loop.
Follow-up commits will re-try copy_history32's across I/O boundaries.
2017-10-06 14:53:45 +11:00
Nigel Tao d30d4c3dad Add a writer1.length method. 2017-10-06 14:17:01 +11:00
Nigel Tao e9df25d599 Remove comment links to file format specs.
The specifications are already linked to from the README.md files.
2017-10-06 13:26:26 +11:00
Nigel Tao e831eecca3 Update TODO on generating suspension points. 2017-10-06 13:22:16 +11:00
Nigel Tao cf6b1be5b5 Re-organize flate Huffman decoder table bits.
Benchmarks are mixed, but it seems conceptually cleaner to arrange the
bits in the order that they're examined.

name                           old speed     new speed     delta
puffs_flate_decode_1k/clang    125MB/s ± 0%  123MB/s ± 1%  -1.91%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang   163MB/s ± 1%  157MB/s ± 0%  -3.55%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang  175MB/s ± 0%  173MB/s ± 0%  -0.75%  (p=0.016 n=4+5)
puffs_flate_decode_1k/gcc      127MB/s ± 0%  130MB/s ± 0%  +2.14%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc     142MB/s ± 1%  149MB/s ± 0%  +4.99%  (p=0.016 n=5+4)
puffs_flate_decode_100k/gcc    162MB/s ± 2%  168MB/s ± 0%  +3.66%  (p=0.016 n=5+4)
2017-10-06 13:07:49 +11:00
Nigel Tao 4aa9fce311 Make writer1.slice's args implicitly (start, ptr). 2017-10-02 13:52:34 +11:00
Nigel Tao 04e8a73d10 Update std/flate's decoder.history_index. 2017-09-30 11:56:30 +10:00
Nigel Tao 3b57548b0d Generate C code for a non-trivial slice-of-slice. 2017-09-29 17:07:41 +10:00
Nigel Tao f1643be221 Have copy_from return the number of bytes copied. 2017-09-28 17:27:34 +10:00
Nigel Tao a9bdeee7c1 Generate C code for a[i:j] with explicit i or j. 2017-09-28 15:57:25 +10:00
Nigel Tao d5c8e20268 Have writer1.slice take mark arguments. 2017-09-23 13:57:48 +10:00
Nigel Tao fd5d44b3fc Add a mark method and type. 2017-09-23 13:17:37 +10:00
Nigel Tao a9f12c23a4 Generate C code for an_array[:]. 2017-09-23 10:51:04 +10:00
Nigel Tao ed8a91ef51 Add an array.copy_from method. 2017-09-22 16:32:11 +10:00
Nigel Tao 2fb9972bb9 Add a slice.suffix method. 2017-09-22 14:12:54 +10:00
Nigel Tao 51f2b183a2 Add a slice.length method. 2017-09-22 12:37:07 +10:00
Nigel Tao 18e32d61e5 Add a writer1.slice method. 2017-09-22 11:54:24 +10:00
Nigel Tao 519ec373f2 First cut at a "[] u8" slice type. 2017-09-08 16:53:59 +10:00
Nigel Tao 0f86add17e Add a status.is_suspension method. 2017-09-02 09:40:39 +10:00