Nigel Tao
906bca4e39
Drop volatile facts after a yield statement
2017-12-01 16:24:54 +11:00
Nigel Tao
65dcf6a5b9
Add a yield keyword
2017-12-01 15:24:48 +11:00
Nigel Tao
3c708dfe59
Rename PUFFS to WUFFS, part 7 of N
2017-11-30 18:02:59 +11:00
Nigel Tao
79a94558be
Rename PUFFS to WUFFS, part 5 of N
2017-11-30 16:37:20 +11:00
Nigel Tao
456e620d02
Rename PUFFS to WUFFS, part 4 of N
2017-11-30 16:28:28 +11:00
Nigel Tao
03acc15782
Add some more length and distance checks.
2017-11-09 13:21:19 +11:00
Nigel Tao
30b54616a8
Check copy_from_history32's distance.
2017-11-09 12:53:19 +11:00
Nigel Tao
3bdd515e47
Allow "assert foo", not just "assert foo < bar".
2017-11-09 10:53:37 +11:00
Nigel Tao
e2ce9f1b1d
Add a writer1.is_marked method.
2017-11-09 10:38:24 +11:00
Nigel Tao
545f043d94
Don't read extra bits if there's no extra bits.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.45GB/s ± 0% 2.45GB/s ± 0% ~ (p=0.548 n=5+5)
puffs_adler32_100k/clang 2.45GB/s ± 0% 2.45GB/s ± 0% ~ (p=0.056 n=5+5)
puffs_flate_decode_1k/clang 142MB/s ± 0% 143MB/s ± 0% +0.63% (p=0.008 n=5+5)
puffs_flate_decode_10k/clang 190MB/s ± 0% 201MB/s ± 0% +5.54% (p=0.008 n=5+5)
puffs_flate_decode_100k/clang 225MB/s ± 0% 235MB/s ± 0% +4.27% (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang 176MB/s ± 0% 186MB/s ± 0% +5.16% (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang 207MB/s ± 1% 214MB/s ± 0% +3.56% (p=0.008 n=5+5)
puffs_adler32_10k/gcc 3.21GB/s ± 1% 3.26GB/s ± 0% +1.55% (p=0.008 n=5+5)
puffs_adler32_100k/gcc 3.21GB/s ± 2% 3.27GB/s ± 0% +1.66% (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc 139MB/s ± 1% 146MB/s ± 0% +5.09% (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc 232MB/s ± 0% 244MB/s ± 0% +5.42% (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc 257MB/s ± 1% 280MB/s ± 0% +9.10% (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc 215MB/s ± 1% 227MB/s ± 0% +5.82% (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc 235MB/s ± 1% 257MB/s ± 0% +9.67% (p=0.008 n=5+5)
2017-11-08 17:19:58 +11:00
Nigel Tao
989614df88
Remove some redundant decode_huffman_xxx code.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.40GB/s ± 1% 2.45GB/s ± 0% +2.08% (p=0.008 n=5+5)
puffs_adler32_100k/clang 2.41GB/s ± 1% 2.45GB/s ± 0% +1.54% (p=0.008 n=5+5)
puffs_flate_decode_1k/clang 140MB/s ± 0% 142MB/s ± 0% +1.64% (p=0.016 n=4+5)
puffs_flate_decode_10k/clang 186MB/s ± 1% 190MB/s ± 0% +2.32% (p=0.008 n=5+5)
puffs_flate_decode_100k/clang 209MB/s ± 1% 225MB/s ± 0% +7.60% (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang 173MB/s ± 1% 176MB/s ± 0% +2.04% (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang 193MB/s ± 0% 207MB/s ± 1% +7.43% (p=0.008 n=5+5)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.21GB/s ± 1% -1.48% (p=0.008 n=5+5)
puffs_adler32_100k/gcc 3.25GB/s ± 0% 3.21GB/s ± 2% -1.24% (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc 142MB/s ± 0% 139MB/s ± 1% -2.27% (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc 232MB/s ± 1% 232MB/s ± 0% ~ (p=0.548 n=5+5)
puffs_flate_decode_100k/gcc 259MB/s ± 2% 257MB/s ± 1% ~ (p=0.151 n=5+5)
puffs_zlib_decode_10k/gcc 216MB/s ± 2% 215MB/s ± 1% ~ (p=0.222 n=5+5)
puffs_zlib_decode_100k/gcc 241MB/s ± 1% 235MB/s ± 1% -2.50% (p=0.008 n=5+5)
2017-11-08 17:08:36 +11:00
Nigel Tao
848d66ffdf
Tighten the Huffman n_bits invariant.
2017-11-07 09:30:16 +11:00
Nigel Tao
ccdd74a17f
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.45GB/s ± 0% 2.45GB/s ± 0% -0.08% (p=0.006 n=10+9)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.45GB/s ± 0% -0.12% (p=0.000 n=10+9)
puffs_flate_decode_1k/clang 137MB/s ± 0% 133MB/s ± 0% -2.71% (p=0.000 n=9+9)
puffs_flate_decode_10k/clang 177MB/s ± 0% 181MB/s ± 0% +2.22% (p=0.000 n=10+9)
puffs_flate_decode_100k/clang 198MB/s ± 0% 204MB/s ± 0% +3.04% (p=0.000 n=10+10)
puffs_zlib_decode_10k/clang 163MB/s ± 0% 168MB/s ± 0% +3.23% (p=0.000 n=9+10)
puffs_zlib_decode_100k/clang 182MB/s ± 0% 189MB/s ± 0% +3.56% (p=0.000 n=9+10)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.26GB/s ± 0% ~ (p=0.280 n=10+10)
puffs_adler32_100k/gcc 3.27GB/s ± 0% 3.27GB/s ± 0% ~ (p=0.075 n=10+10)
puffs_flate_decode_1k/gcc 111MB/s ± 1% 130MB/s ± 0% +17.19% (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc 142MB/s ± 0% 203MB/s ± 0% +43.11% (p=0.000 n=10+9)
puffs_flate_decode_100k/gcc 153MB/s ± 0% 241MB/s ± 0% +57.62% (p=0.000 n=9+8)
puffs_zlib_decode_10k/gcc 142MB/s ± 0% 188MB/s ± 0% +32.47% (p=0.000 n=9+9)
puffs_zlib_decode_100k/gcc 149MB/s ± 0% 223MB/s ± 0% +50.03% (p=0.000 n=8+9)
2017-11-06 14:03:11 +11:00
Nigel Tao
bf50d268ae
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.40GB/s ± 3% 2.45GB/s ± 0% +2.21% (p=0.000 n=10+10)
puffs_adler32_100k/clang 2.41GB/s ± 1% 2.46GB/s ± 0% +2.05% (p=0.000 n=9+10)
puffs_flate_decode_1k/clang 127MB/s ± 1% 137MB/s ± 0% +7.94% (p=0.000 n=9+9)
puffs_flate_decode_10k/clang 177MB/s ± 1% 177MB/s ± 0% ~ (p=0.234 n=9+10)
puffs_flate_decode_100k/clang 205MB/s ± 1% 198MB/s ± 0% -3.06% (p=0.000 n=9+10)
puffs_zlib_decode_10k/clang 165MB/s ± 1% 163MB/s ± 0% -1.12% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 189MB/s ± 0% 182MB/s ± 0% -3.42% (p=0.000 n=9+9)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.26GB/s ± 0% ~ (p=0.065 n=9+10)
puffs_adler32_100k/gcc 3.27GB/s ± 0% 3.27GB/s ± 0% ~ (p=0.173 n=8+10)
puffs_flate_decode_1k/gcc 111MB/s ± 0% 111MB/s ± 1% ~ (p=0.971 n=10+10)
puffs_flate_decode_10k/gcc 149MB/s ± 0% 142MB/s ± 0% -4.67% (p=0.000 n=9+10)
puffs_flate_decode_100k/gcc 160MB/s ± 0% 153MB/s ± 0% -4.46% (p=0.000 n=9+9)
puffs_zlib_decode_10k/gcc 128MB/s ± 0% 142MB/s ± 0% +11.21% (p=0.000 n=9+9)
puffs_zlib_decode_100k/gcc 137MB/s ± 0% 149MB/s ± 0% +8.47% (p=0.000 n=8+8)
2017-11-06 08:31:03 +11:00
Nigel Tao
5520340d7c
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.45GB/s ± 2% 2.40GB/s ± 3% -1.87% (p=0.001 n=9+10)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.41GB/s ± 1% -2.08% (p=0.000 n=8+9)
puffs_flate_decode_1k/clang 125MB/s ± 0% 127MB/s ± 1% +1.53% (p=0.000 n=9+9)
puffs_flate_decode_10k/clang 168MB/s ± 0% 177MB/s ± 1% +5.59% (p=0.000 n=10+9)
puffs_flate_decode_100k/clang 193MB/s ± 0% 205MB/s ± 1% +6.20% (p=0.000 n=9+9)
puffs_zlib_decode_10k/clang 157MB/s ± 0% 165MB/s ± 1% +5.00% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 179MB/s ± 0% 189MB/s ± 0% +5.69% (p=0.000 n=8+9)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.26GB/s ± 0% -0.14% (p=0.000 n=10+9)
puffs_adler32_100k/gcc 3.27GB/s ± 0% 3.27GB/s ± 0% -0.09% (p=0.000 n=9+8)
puffs_flate_decode_1k/gcc 122MB/s ± 0% 111MB/s ± 0% -9.40% (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc 176MB/s ± 0% 149MB/s ± 0% -15.45% (p=0.000 n=10+9)
puffs_flate_decode_100k/gcc 199MB/s ± 0% 160MB/s ± 0% -19.51% (p=0.000 n=10+9)
puffs_zlib_decode_10k/gcc 168MB/s ± 0% 128MB/s ± 0% -24.01% (p=0.000 n=10+9)
puffs_zlib_decode_100k/gcc 187MB/s ± 0% 137MB/s ± 0% -26.84% (p=0.000 n=9+8)
2017-11-05 23:02:19 +11:00
Nigel Tao
e7c14dfe63
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.46GB/s ± 0% 2.45GB/s ± 2% ~ (p=0.352 n=9+9)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.46GB/s ± 0% ~ (p=0.673 n=9+8)
puffs_flate_decode_1k/clang 124MB/s ± 0% 125MB/s ± 0% +0.39% (p=0.000 n=8+9)
puffs_flate_decode_10k/clang 165MB/s ± 0% 168MB/s ± 0% +1.81% (p=0.000 n=8+10)
puffs_flate_decode_100k/clang 195MB/s ± 0% 193MB/s ± 0% -1.30% (p=0.000 n=9+9)
puffs_zlib_decode_10k/clang 154MB/s ± 1% 157MB/s ± 0% +1.96% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 181MB/s ± 0% 179MB/s ± 0% -1.19% (p=0.000 n=10+8)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.26GB/s ± 0% ~ (p=0.549 n=9+10)
puffs_adler32_100k/gcc 3.27GB/s ± 0% 3.27GB/s ± 0% ~ (p=0.450 n=9+9)
puffs_flate_decode_1k/gcc 112MB/s ± 0% 122MB/s ± 0% +9.10% (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc 155MB/s ± 0% 176MB/s ± 0% +13.63% (p=0.000 n=10+10)
puffs_flate_decode_100k/gcc 176MB/s ± 0% 199MB/s ± 0% +12.74% (p=0.000 n=9+10)
puffs_zlib_decode_10k/gcc 137MB/s ± 0% 168MB/s ± 0% +22.54% (p=0.000 n=9+10)
puffs_zlib_decode_100k/gcc 158MB/s ± 0% 187MB/s ± 0% +18.87% (p=0.000 n=9+9)
2017-11-05 22:40:18 +11:00
Nigel Tao
934705a6e1
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.46GB/s ± 0% 2.46GB/s ± 0% ~ (p=0.243 n=10+9)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.46GB/s ± 0% +0.07% (p=0.002 n=10+9)
puffs_flate_decode_1k/clang 125MB/s ± 0% 124MB/s ± 0% -0.58% (p=0.000 n=10+8)
puffs_flate_decode_10k/clang 168MB/s ± 0% 165MB/s ± 0% -2.07% (p=0.000 n=9+8)
puffs_flate_decode_100k/clang 203MB/s ± 0% 195MB/s ± 0% -3.85% (p=0.000 n=9+9)
puffs_zlib_decode_10k/clang 157MB/s ± 0% 154MB/s ± 1% -2.07% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 187MB/s ± 0% 181MB/s ± 0% -3.50% (p=0.000 n=10+10)
puffs_adler32_10k/gcc 3.20GB/s ± 1% 3.26GB/s ± 0% +2.07% (p=0.000 n=10+9)
puffs_adler32_100k/gcc 3.21GB/s ± 1% 3.27GB/s ± 0% +1.71% (p=0.000 n=9+9)
puffs_flate_decode_1k/gcc 128MB/s ± 2% 112MB/s ± 0% -12.35% (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc 181MB/s ± 1% 155MB/s ± 0% -14.07% (p=0.000 n=10+10)
puffs_flate_decode_100k/gcc 208MB/s ± 0% 176MB/s ± 0% -15.23% (p=0.000 n=9+9)
puffs_zlib_decode_10k/gcc 172MB/s ± 1% 137MB/s ± 0% -20.14% (p=0.000 n=10+9)
puffs_zlib_decode_100k/gcc 195MB/s ± 1% 158MB/s ± 0% -18.97% (p=0.000 n=10+9)
2017-11-05 21:59:59 +11:00
Nigel Tao
44323f95ad
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.46GB/s ± 0% 2.46GB/s ± 0% ~ (p=0.968 n=9+10)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.46GB/s ± 0% ~ (p=0.579 n=10+10)
puffs_flate_decode_1k/clang 132MB/s ± 0% 125MB/s ± 0% -5.22% (p=0.000 n=10+10)
puffs_flate_decode_10k/clang 167MB/s ± 0% 168MB/s ± 0% +0.80% (p=0.000 n=8+9)
puffs_flate_decode_100k/clang 205MB/s ± 0% 203MB/s ± 0% -0.91% (p=0.000 n=9+9)
puffs_zlib_decode_10k/clang 156MB/s ± 0% 157MB/s ± 0% +0.91% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 189MB/s ± 0% 187MB/s ± 0% -0.92% (p=0.000 n=8+10)
puffs_adler32_10k/gcc 3.18GB/s ± 3% 3.20GB/s ± 1% ~ (p=0.796 n=10+10)
puffs_adler32_100k/gcc 3.22GB/s ± 1% 3.21GB/s ± 1% ~ (p=0.730 n=9+9)
puffs_flate_decode_1k/gcc 125MB/s ± 1% 128MB/s ± 2% +2.20% (p=0.000 n=9+10)
puffs_flate_decode_10k/gcc 177MB/s ± 1% 181MB/s ± 1% +1.82% (p=0.000 n=9+10)
puffs_flate_decode_100k/gcc 203MB/s ± 1% 208MB/s ± 0% +2.67% (p=0.000 n=10+9)
puffs_zlib_decode_10k/gcc 168MB/s ± 0% 172MB/s ± 1% +2.11% (p=0.000 n=10+10)
puffs_zlib_decode_100k/gcc 190MB/s ± 1% 195MB/s ± 1% +2.36% (p=0.000 n=9+10)
2017-11-05 21:33:44 +11:00
Nigel Tao
7e33a2cc14
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.39GB/s ± 1% 2.46GB/s ± 0% +2.88% (p=0.000 n=8+9)
puffs_adler32_100k/clang 2.40GB/s ± 1% 2.46GB/s ± 0% +2.18% (p=0.000 n=9+10)
puffs_flate_decode_1k/clang 129MB/s ± 4% 132MB/s ± 0% +2.31% (p=0.000 n=10+10)
puffs_flate_decode_10k/clang 164MB/s ± 1% 167MB/s ± 0% +1.89% (p=0.000 n=10+8)
puffs_flate_decode_100k/clang 194MB/s ± 1% 205MB/s ± 0% +5.49% (p=0.000 n=9+9)
puffs_zlib_decode_10k/clang 153MB/s ± 1% 156MB/s ± 0% +1.73% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 180MB/s ± 1% 189MB/s ± 0% +5.09% (p=0.000 n=8+8)
puffs_adler32_10k/gcc 3.21GB/s ± 1% 3.18GB/s ± 3% ~ (p=0.203 n=8+10)
puffs_adler32_100k/gcc 3.22GB/s ± 0% 3.22GB/s ± 1% ~ (p=0.931 n=9+9)
puffs_flate_decode_1k/gcc 124MB/s ± 1% 125MB/s ± 1% +1.41% (p=0.001 n=9+9)
puffs_flate_decode_10k/gcc 179MB/s ± 1% 177MB/s ± 1% -0.77% (p=0.006 n=10+9)
puffs_flate_decode_100k/gcc 192MB/s ± 0% 203MB/s ± 1% +5.57% (p=0.000 n=10+10)
puffs_zlib_decode_10k/gcc 169MB/s ± 1% 168MB/s ± 0% -0.45% (p=0.011 n=10+10)
puffs_zlib_decode_100k/gcc 180MB/s ± 1% 190MB/s ± 1% +5.37% (p=0.000 n=10+9)
2017-11-05 21:11:24 +11:00
Nigel Tao
465b4e1815
Remove some suspensions from decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.45GB/s ± 0% 2.39GB/s ± 1% -2.74% (p=0.000 n=10+8)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.40GB/s ± 1% -2.13% (p=0.000 n=10+9)
puffs_flate_decode_1k/clang 132MB/s ± 0% 129MB/s ± 4% -2.25% (p=0.000 n=10+10)
puffs_flate_decode_10k/clang 174MB/s ± 0% 164MB/s ± 1% -5.78% (p=0.000 n=10+10)
puffs_flate_decode_100k/clang 208MB/s ± 0% 194MB/s ± 1% -6.45% (p=0.000 n=10+9)
puffs_zlib_decode_10k/clang 162MB/s ± 0% 153MB/s ± 1% -5.46% (p=0.000 n=9+9)
puffs_zlib_decode_100k/clang 192MB/s ± 0% 180MB/s ± 1% -6.02% (p=0.000 n=9+8)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.21GB/s ± 1% -1.58% (p=0.000 n=10+8)
puffs_adler32_100k/gcc 3.27GB/s ± 0% 3.22GB/s ± 0% -1.42% (p=0.000 n=8+9)
puffs_flate_decode_1k/gcc 106MB/s ± 0% 124MB/s ± 1% +17.14% (p=0.000 n=10+9)
puffs_flate_decode_10k/gcc 140MB/s ± 0% 179MB/s ± 1% +27.45% (p=0.000 n=9+10)
puffs_flate_decode_100k/gcc 150MB/s ± 0% 192MB/s ± 0% +27.77% (p=0.000 n=10+10)
puffs_zlib_decode_10k/gcc 120MB/s ± 0% 169MB/s ± 1% +40.32% (p=0.000 n=9+10)
puffs_zlib_decode_100k/gcc 134MB/s ± 0% 180MB/s ± 1% +34.56% (p=0.000 n=8+10)
2017-11-05 20:50:58 +11:00
Nigel Tao
13731f989f
Add a reader1.unread_u8 method.
...
Also re-enable a number of std/flate tests and benchmarks.
It's not an optimization per se, but as a data point, here are some
benchmark numbers between 36a93fa and this commit. 36a93fa is "36a93fa
Add a TODO about impure functions", which is one commit before "f968950
Read bits up front in decode_huffman_fast", and f968950 was the commit
that made decode_huffman_fast read more than one byte at a time.
name old speed new speed delta
puffs_adler32_10k/clang 2.45GB/s ± 0% 2.45GB/s ± 0% ~ (p=0.684 n=10+10)
puffs_adler32_100k/clang 2.45GB/s ± 0% 2.46GB/s ± 0% +0.07% (p=0.019 n=10+10)
puffs_flate_decode_1k/clang 124MB/s ± 0% 132MB/s ± 0% +6.06% (p=0.000 n=10+10)
puffs_flate_decode_10k/clang 145MB/s ± 0% 174MB/s ± 0% +20.19% (p=0.000 n=9+10)
puffs_flate_decode_100k/clang 168MB/s ± 0% 208MB/s ± 0% +23.31% (p=0.000 n=10+10)
puffs_zlib_decode_10k/clang 136MB/s ± 0% 162MB/s ± 0% +18.94% (p=0.000 n=10+9)
puffs_zlib_decode_100k/clang 158MB/s ± 0% 192MB/s ± 0% +21.58% (p=0.000 n=10+9)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.26GB/s ± 0% ~ (p=0.631 n=10+10)
puffs_adler32_100k/gcc 3.27GB/s ± 0% 3.27GB/s ± 0% ~ (p=0.237 n=10+8)
puffs_flate_decode_1k/gcc 95.3MB/s ± 0% 105.5MB/s ± 0% +10.67% (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc 110MB/s ± 0% 140MB/s ± 0% +27.32% (p=0.000 n=9+9)
puffs_flate_decode_100k/gcc 121MB/s ± 0% 150MB/s ± 0% +24.02% (p=0.000 n=8+10)
puffs_zlib_decode_10k/gcc 112MB/s ± 0% 120MB/s ± 0% +6.96% (p=0.000 n=10+9)
puffs_zlib_decode_100k/gcc 123MB/s ± 0% 134MB/s ± 0% +8.93% (p=0.000 n=9+8)
2017-11-05 15:59:02 +11:00
Nigel Tao
325c36314a
Prepare decode_huffman_fast to rewind in.src.
2017-11-05 14:13:27 +11:00
Nigel Tao
b6a079fd3e
Tweak the decode_huffman_fast loop condition more.
2017-11-05 13:47:28 +11:00
Nigel Tao
f6e072fe77
Add some more "inconsistent n_bits" checks.
...
This uncovered a bug in the decode_huffman_fast function. A follow up commit
will actually fix the bug.
For what it's worth, some benchmark numbers are below, but they're
possibly bogus, as we might be decoding incorrect (and truncated) output
for some inputs. Everything since "f968950 Read bits up front in
decode_huffman_fast" landed possibly has bogus numbers too.
name old speed new speed delta
puffs_flate_decode_100k/clang 194MB/s ± 0% 204MB/s ± 1% +5.02% (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc 180MB/s ± 3% 202MB/s ± 1% +12.09% (p=0.008 n=5+5)
2017-11-05 09:23:49 +11:00
Nigel Tao
db57d8b707
Bump decode_huffman_fast's src available hurdle.
...
We will need this later, to prove that the other read_u8 calls in
decode_huffman_fast will not suspend.
It's not obvious why the clang benchmarks don't change but the gcc ones
(including the adler numbers, which are superficially unrelated) look
worse. If the change from 6 to 12 bytes is a genuine performance
regression, then a future commit can tighten the bound back to 6,
although it would probably make the decode_huffman_fast assertions and
proof requirements considerably more complicated.
name old speed new speed delta
puffs_adler32_10k/clang 2.40GB/s ± 1% 2.41GB/s ± 0% ~ (p=0.690 n=5+5)
puffs_adler32_100k/clang 2.39GB/s ± 2% 2.40GB/s ± 1% ~ (p=1.000 n=5+5)
puffs_flate_decode_1k/clang 128MB/s ± 0% 128MB/s ± 0% ~ (p=1.000 n=5+5)
puffs_flate_decode_10k/clang 167MB/s ± 2% 168MB/s ± 0% ~ (p=0.548 n=5+5)
puffs_flate_decode_100k/clang 193MB/s ± 2% 194MB/s ± 0% ~ (p=0.310 n=5+5)
puffs_zlib_decode_10k/clang 157MB/s ± 0% 155MB/s ± 4% ~ (p=0.421 n=5+5)
puffs_zlib_decode_100k/clang 180MB/s ± 1% 177MB/s ± 3% ~ (p=0.222 n=5+5)
puffs_adler32_10k/gcc 3.26GB/s ± 0% 3.20GB/s ± 1% -1.81% (p=0.008 n=5+5)
puffs_adler32_100k/gcc 3.26GB/s ± 0% 3.21GB/s ± 0% -1.63% (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc 129MB/s ± 0% 126MB/s ± 1% -2.30% (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc 164MB/s ± 0% 161MB/s ± 0% -1.86% (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc 185MB/s ± 0% 180MB/s ± 3% -2.81% (p=0.016 n=4+5)
puffs_zlib_decode_10k/gcc 157MB/s ± 0% 151MB/s ± 2% -3.49% (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc 175MB/s ± 0% 170MB/s ± 2% -2.97% (p=0.016 n=4+5)
2017-11-05 08:56:55 +11:00
Nigel Tao
fe5e9c68b3
Remove a superfluous while loop.
...
It's not obvious why the adler benchmark numbers also change (for the
better), but it seems superficially repeatable for fresh before/after
measurements. I'll take it for now, but perhaps the adler benchmarks
need to run for longer.
name old speed new speed delta
puffs_adler32_10k/clang 2.38GB/s ± 2% 2.45GB/s ± 0% +2.87% (p=0.008 n=5+5)
puffs_adler32_100k/clang 2.39GB/s ± 1% 2.44GB/s ± 0% +2.42% (p=0.008 n=5+5)
puffs_flate_decode_1k/clang 129MB/s ± 2% 133MB/s ± 0% +3.41% (p=0.008 n=5+5)
puffs_flate_decode_10k/clang 161MB/s ± 1% 174MB/s ± 0% +8.46% (p=0.008 n=5+5)
puffs_flate_decode_100k/clang 187MB/s ± 3% 205MB/s ± 0% +9.51% (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang 150MB/s ± 1% 162MB/s ± 0% +8.09% (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang 174MB/s ± 1% 188MB/s ± 0% +8.13% (p=0.008 n=5+5)
puffs_adler32_10k/gcc 3.12GB/s ± 3% 3.25GB/s ± 0% +4.30% (p=0.016 n=5+4)
puffs_adler32_100k/gcc 3.12GB/s ± 3% 3.25GB/s ± 0% +4.15% (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc 128MB/s ± 3% 132MB/s ± 0% +3.11% (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc 172MB/s ± 4% 170MB/s ± 0% ~ (p=0.151 n=5+5)
puffs_flate_decode_100k/gcc 196MB/s ± 2% 207MB/s ± 0% +5.46% (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc 164MB/s ± 1% 161MB/s ± 1% -1.34% (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc 186MB/s ± 0% 194MB/s ± 0% +4.12% (p=0.016 n=4+5)
2017-11-05 06:57:10 +11:00
Nigel Tao
f968950345
Read bits up front in decode_huffman_fast.
...
name old speed new speed delta
puffs_adler32_10k/clang 2.36GB/s ± 4% 2.38GB/s ± 2% ~ (p=1.000 n=5+5)
puffs_adler32_100k/clang 2.39GB/s ± 4% 2.39GB/s ± 1% ~ (p=0.841 n=5+5)
puffs_flate_decode_1k/clang 121MB/s ± 1% 129MB/s ± 2% +5.95% (p=0.008 n=5+5)
puffs_flate_decode_10k/clang 138MB/s ± 3% 161MB/s ± 1% +16.52% (p=0.008 n=5+5)
puffs_flate_decode_100k/clang 163MB/s ± 4% 187MB/s ± 3% +14.50% (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang 132MB/s ± 2% 150MB/s ± 1% +13.92% (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang 152MB/s ± 6% 174MB/s ± 1% +14.60% (p=0.008 n=5+5)
puffs_adler32_10k/gcc 3.25GB/s ± 0% 3.12GB/s ± 3% -4.06% (p=0.008 n=5+5)
puffs_adler32_100k/gcc 3.25GB/s ± 0% 3.12GB/s ± 3% -3.99% (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc 95.1MB/s ± 0% 127.7MB/s ± 3% +34.25% (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc 110MB/s ± 0% 172MB/s ± 4% +55.66% (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc 121MB/s ± 0% 196MB/s ± 2% +61.45% (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc 112MB/s ± 0% 164MB/s ± 1% +46.14% (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc 123MB/s ± 0% 186MB/s ± 0% +51.22% (p=0.016 n=5+4)
2017-11-04 17:37:54 +11:00
Nigel Tao
36a93fa6b7
Add a TODO about impure functions.
2017-11-04 16:04:28 +11:00
Nigel Tao
1c7a6792de
Tweak the decode_huffman_fast loop condition.
2017-11-04 15:19:40 +11:00
Nigel Tao
8fafcbcb31
Tweak the flate end_of_block check.
2017-11-04 14:54:56 +11:00
Nigel Tao
aa1f0078db
Add decode_huffman_fast.
...
It's not fast yet, and the immediate impact is indeed a significant
performance loss, but follow-up commits should make it faster.
name old speed new speed delta
puffs_adler32_10k/clang 2.41GB/s ± 0% 2.40GB/s ± 1% ~ (p=0.222 n=5+5)
puffs_adler32_100k/clang 2.41GB/s ± 1% 2.39GB/s ± 1% -0.97% (p=0.016 n=5+5)
puffs_flate_decode_1k/clang 116MB/s ± 5% 115MB/s ± 0% ~ (p=0.310 n=5+5)
puffs_flate_decode_10k/clang 145MB/s ± 0% 139MB/s ± 0% -4.18% (p=0.016 n=4+5)
puffs_flate_decode_100k/clang 164MB/s ± 5% 158MB/s ± 1% ~ (p=0.151 n=5+5)
puffs_zlib_decode_10k/clang 135MB/s ± 2% 131MB/s ± 0% -2.84% (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang 154MB/s ± 1% 148MB/s ± 2% -4.09% (p=0.016 n=4+5)
puffs_adler32_10k/gcc 3.13GB/s ± 4% 3.19GB/s ± 0% +1.94% (p=0.032 n=5+5)
puffs_adler32_100k/gcc 3.14GB/s ± 3% 3.20GB/s ± 3% ~ (p=0.056 n=5+5)
puffs_flate_decode_1k/gcc 122MB/s ± 1% 94MB/s ± 1% -22.84% (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc 143MB/s ± 0% 110MB/s ± 0% -23.24% (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc 158MB/s ± 0% 118MB/s ± 0% -24.98% (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc 136MB/s ± 0% 119MB/s ± 1% -12.63% (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc 150MB/s ± 1% 124MB/s ± 2% -17.17% (p=0.008 n=5+5)
2017-11-04 14:45:11 +11:00
Nigel Tao
c550ad9bda
Add redundant but clearer continue/break labels.
2017-11-04 14:14:07 +11:00
Nigel Tao
ded044da41
Add a flate end_of_block field.
2017-11-04 14:12:38 +11:00
Nigel Tao
4810db3994
Rename decode_huffman to decode_huffman_slow.
2017-11-04 13:38:24 +11:00
Nigel Tao
c3420dd138
Refactor std/flate/*.puffs code.
2017-11-04 13:31:39 +11:00
Nigel Tao
e3822f9951
Re-introduce puffs_base__limit1.
...
It's not immediately obvious why this data structure performs differently, but
on net, the benchmark numbers seem better. It also won't require any
PUFFS_USE_NO_OP_PERFORMANCE_HACKS or "redundant but mysteriously performant"
use_limit fields.
name old speed new speed delta
puffs_adler32_10k/clang 2.46GB/s ± 0% 2.43GB/s ± 3% ~ (p=0.513 n=5+10)
puffs_adler32_100k/clang 2.46GB/s ± 0% 2.44GB/s ± 2% ~ (p=0.241 n=5+10)
puffs_flate_decode_1k/clang 122MB/s ± 1% 119MB/s ± 2% -1.86% (p=0.013 n=5+10)
puffs_flate_decode_10k/clang 147MB/s ± 0% 142MB/s ± 2% -3.47% (p=0.001 n=5+10)
puffs_flate_decode_100k/clang 161MB/s ± 0% 161MB/s ± 4% ~ (p=0.635 n=4+10)
puffs_zlib_decode_10k/clang 139MB/s ± 0% 135MB/s ± 1% -2.69% (p=0.001 n=5+10)
puffs_zlib_decode_100k/clang 151MB/s ± 0% 152MB/s ± 3% ~ (p=1.000 n=5+10)
puffs_adler32_10k/gcc 3.21GB/s ± 1% 3.18GB/s ± 2% ~ (p=0.310 n=5+10)
puffs_adler32_100k/gcc 3.22GB/s ± 0% 3.19GB/s ± 2% ~ (p=0.075 n=5+10)
puffs_flate_decode_1k/gcc 121MB/s ± 4% 126MB/s ± 1% +4.54% (p=0.002 n=5+8)
puffs_flate_decode_10k/gcc 144MB/s ± 1% 141MB/s ± 1% -2.52% (p=0.001 n=5+9)
puffs_flate_decode_100k/gcc 154MB/s ± 1% 158MB/s ± 0% +2.39% (p=0.001 n=5+9)
puffs_zlib_decode_10k/gcc 137MB/s ± 2% 135MB/s ± 1% ~ (p=0.055 n=5+10)
puffs_zlib_decode_100k/gcc 146MB/s ± 2% 150MB/s ± 0% +2.87% (p=0.001 n=5+10)
puffs_gif_lzw_decode_20k/clang 132MB/s ± 0% 125MB/s ± 0% -5.24% (p=0.001 n=5+10)
puffs_gif_lzw_decode_100k/clang 176MB/s ± 0% 164MB/s ± 0% -6.82% (p=0.001 n=5+9)
puffs_gif_decode_1k/clang 363MB/s ± 0% 339MB/s ± 1% -6.58% (p=0.002 n=4+10)
puffs_gif_decode_10k/clang 138MB/s ± 0% 133MB/s ± 1% -3.77% (p=0.001 n=5+10)
puffs_gif_decode_100k/clang 125MB/s ± 0% 119MB/s ± 0% -4.79% (p=0.001 n=5+10)
puffs_gif_decode_1000k/clang 127MB/s ± 0% 121MB/s ± 0% -5.04% (p=0.001 n=5+10)
puffs_gif_lzw_decode_20k/gcc 141MB/s ± 0% 140MB/s ± 2% ~ (p=1.000 n=5+10)
puffs_gif_lzw_decode_100k/gcc 182MB/s ± 0% 180MB/s ± 2% -1.56% (p=0.001 n=5+10)
puffs_gif_decode_1k/gcc 363MB/s ± 0% 409MB/s ± 3% +12.71% (p=0.001 n=5+10)
puffs_gif_decode_10k/gcc 127MB/s ± 0% 161MB/s ± 3% +26.15% (p=0.001 n=5+10)
puffs_gif_decode_100k/gcc 112MB/s ± 0% 136MB/s ± 2% +21.95% (p=0.001 n=5+10)
puffs_gif_decode_1000k/gcc 114MB/s ± 0% 140MB/s ± 2% +22.78% (p=0.001 n=5+10)
2017-11-03 10:09:57 +11:00
Nigel Tao
7cefcccc98
Make error "foo" an expression.
2017-10-27 13:00:13 +11:00
Nigel Tao
9a8508857f
Fix the "limitt" typo.
2017-10-27 11:10:25 +11:00
Nigel Tao
8ff453c752
Re-do how limits work.
2017-10-26 16:59:03 +11:00
Nigel Tao
a382101a9c
Remove an obsolete TODO.
2017-10-26 15:43:46 +11:00
Nigel Tao
a9ba7e85ac
Add reader1.limitt and writer1.limitt methods.
...
The "limitt" typo will be renamed to "limit" once we remove the keyword
named "limit".
2017-10-26 15:06:59 +11:00
Nigel Tao
b886e3a1ea
Add reader1.mark and reader1.since_mark methods.
2017-10-26 14:39:38 +11:00
Nigel Tao
15ded0a6d0
Add while/break in anticipation of adding try.
2017-10-26 14:09:31 +11:00
Nigel Tao
51012a0cca
Change flate block_size from u8 to u64.
2017-10-26 14:05:02 +11:00
Nigel Tao
c0c023e1cf
Remove the writer1.length method.
2017-10-26 13:15:24 +11:00
Nigel Tao
5052b16f2d
Rename writer1.slice to writer1.since_mark.
2017-10-26 13:03:19 +11:00
Nigel Tao
0d32b6cb47
Add a mark call to zlib_decoder.decode.
2017-10-26 12:34:01 +11:00
Nigel Tao
474a0d2ed7
Make mark a method, not a keyword.
2017-10-26 12:31:27 +11:00
Nigel Tao
36f5ae9bf4
Move the "mark in.dst" into the flate decode loop.
2017-10-26 11:20:42 +11:00
Nigel Tao
21bbbd422f
Generate code for "mark in.dst".
...
The generated code is ugly and the language design is not finalized, but
the flate_backref_crosses_blocks test (testing a correctness bug) now
passes. We can fix the ugliness in subsequent commits.
2017-10-22 14:44:53 +11:00