Commit Graph
549 Commits
Author SHA1 Message Date
Nigel Tao abaab57cfd Remove image_config.background_color 2019-06-01 09:07:19 +10:00
Nigel Tao cf26b93f2f Re-assign GIF quirk numbers 2019-06-01 08:40:07 +10:00
Nigel Tao fd72372312 Add wuffs_gif__quirk_first_frame_local_palette_etc 2019-06-01 08:38:30 +10:00
Nigel Tao bb07118422 Re-assign GIF quirk numbers 2019-05-26 17:45:06 +10:00
Nigel Tao 73fcd7e502 Rename wuffs_gif__quirk_background_is_opaque 2019-05-26 17:43:58 +10:00
Nigel Tao 5cdf3197bd Add frame_config.background_color 2019-05-26 16:54:37 +10:00
Nigel Tao 08dd41aa93 Tweak wuffs_gif__quirk_reject_empty_frame 2019-05-26 16:25:01 +10:00
Nigel Tao d41430c4f5 Allow an LZW literal width of 0 2019-05-26 15:52:07 +10:00
Nigel Tao af4e327a8f Have set_quirk_enabled check call_sequence == 0 2019-05-26 15:08:45 +10:00
Nigel Tao 143b19c564 Add wuffs_gif__quirk_reject_empty_frame 2019-05-26 13:12:22 +10:00
Nigel Tao fc9c2916f5 Add more commentary about quirks 2019-05-26 09:27:17 +10:00
Nigel Tao ded9ffb0c0 Add wuffs_gif__quirk_delay_num_decoded_frames 2019-05-26 09:01:20 +10:00
Nigel Tao 5780b406dc Fix ignore_too_much_pixel_data infinite loop 2019-05-25 12:31:43 +10:00
Nigel Tao 74a591ab2b Reject bad LZW widths when skipping GIF frames 2019-05-25 10:56:46 +10:00
Nigel Tao 31a2bc918e Let GIF decode an opaque but non-black background 2019-05-21 08:53:35 +10:00
Nigel Tao b1ff27fded Decode multiple graphic controls in a GIF 2019-05-12 22:02:39 +10:00
Nigel Tao 5bea867f72 Allow an LZW literal width of 1 2019-05-12 21:32:30 +10:00
Nigel Tao 24a2f12c30 Add wuffs_gif__quirk_ignore_too_much_pixel_data 2019-05-04 14:04:28 +10:00
Nigel Tao a1f777b16e Clean up std/gif which_palette variable 2019-05-04 13:54:39 +10:00
Nigel Tao 746681ea68 Add wuffs_gif__quirk_reject_empty_palette 2019-05-04 13:49:22 +10:00
Nigel Tao 1311445408 Add wuffs_gif__quirk_initial_background_is_opaque 2019-05-04 12:35:37 +10:00
Nigel Tao 941cecca8c Add wuffs_gif__quirk_image_bounds_are_strict 2019-05-04 12:19:52 +10:00
Nigel Tao ed8741b384 Prepare to add gif quirks 2019-05-04 11:58:18 +10:00
Nigel Tao a1a5b40178 Simplify std/gif decoding re warnings 2019-04-21 21:49:20 +10:00
Nigel Tao 842500d51c Report ICCP metadata 2019-04-20 16:48:18 +10:00
Nigel Tao 21f2890217 Report image metadata such as ICCP and XMP 2019-04-20 16:33:11 +10:00
Nigel Tao abaaee3cac Re-number gif call-sequence values 2019-04-20 13:18:28 +10:00
Nigel Tao 02dc564596 Eliminate a branch in std/deflate decoding
name                                             old speed      new speed      delta

wuffs_deflate_decode_1k_full_init/clang5          139MB/s ± 1%   151MB/s ± 1%   +9.19%  (p=0.000 n=28+30)
wuffs_deflate_decode_1k_part_init/clang5          169MB/s ± 1%   187MB/s ± 1%  +11.15%  (p=0.000 n=28+28)
wuffs_deflate_decode_10k_full_init/clang5         200MB/s ± 0%   242MB/s ± 1%  +20.99%  (p=0.000 n=28+28)
wuffs_deflate_decode_10k_part_init/clang5         205MB/s ± 1%   249MB/s ± 1%  +21.51%  (p=0.000 n=29+29)
wuffs_deflate_decode_100k_just_one_read/clang5    255MB/s ± 1%   280MB/s ± 1%   +9.86%  (p=0.000 n=29+30)
wuffs_deflate_decode_100k_many_big_reads/clang5   218MB/s ± 0%   241MB/s ± 1%  +10.58%  (p=0.000 n=27+24)

wuffs_deflate_decode_1k_full_init/gcc7            155MB/s ± 1%   155MB/s ± 2%     ~     (p=0.521 n=28+29)
wuffs_deflate_decode_1k_part_init/gcc7            190MB/s ± 1%   191MB/s ± 1%   +0.51%  (p=0.000 n=27+28)
wuffs_deflate_decode_10k_full_init/gcc7           265MB/s ± 1%   266MB/s ± 1%   +0.54%  (p=0.000 n=29+30)
wuffs_deflate_decode_10k_part_init/gcc7           272MB/s ± 1%   274MB/s ± 1%   +0.73%  (p=0.000 n=29+30)
wuffs_deflate_decode_100k_just_one_read/gcc7      317MB/s ± 0%   318MB/s ± 0%   +0.58%  (p=0.000 n=28+28)
wuffs_deflate_decode_100k_many_big_reads/gcc7     252MB/s ± 1%   253MB/s ± 0%   +0.64%  (p=0.000 n=29+27)
2019-03-16 14:02:15 +11:00
Nigel Tao a7e2fc86d2 Add commentary about the Adler-32 algorithm 2019-03-09 11:20:30 +11:00
Nigel Tao ef7aa0d980 Rename "!=" to "<>"; "!" now only shows impurity 2019-03-02 14:51:32 +11:00
Nigel Tao f8d02cfb16 Change the warning message prefix from "~" to "@" 2019-03-02 14:42:50 +11:00
Nigel Tao 5aeb98c701 Restore deflate.decoder.n_huffs_bits's refinement 2019-02-24 09:15:31 +11:00
Nigel Tao 931fdce475 Rename "yield foo" to "yield? foo" 2019-02-23 17:15:57 +11:00
Nigel Tao 045f180a6c Rename errors from "?msg" to "#msg" 2019-02-23 17:06:24 +11:00
Nigel Tao 8b41881ba7 Rename gif's "too much pixel data" 2019-02-23 14:34:06 +11:00
Nigel Tao d7f434c6e4 Have the GIF decoder check for "not enough data"
Fixes #20
2019-02-23 14:29:16 +11:00
Nigel Tao 6974c4d629 Refine the lzw.decoder.prefixes element type
name                                             old speed      new speed      delta

wuffs_gif_decode_1k_bw/clang5                     445MB/s ± 1%   413MB/s ± 1%  -7.11%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang5                  192MB/s ± 0%   185MB/s ± 0%  -3.82%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5                  748MB/s ± 1%   742MB/s ± 0%    ~     (p=0.151 n=5+5)
wuffs_gif_decode_10k_indexed/clang5               202MB/s ± 1%   198MB/s ± 1%  -1.69%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5                       251MB/s ± 0%   251MB/s ± 1%    ~     (p=1.000 n=4+5)
wuffs_gif_decode_100k_artificial/clang5           545MB/s ± 1%   563MB/s ± 1%  +3.21%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5            226MB/s ± 1%   228MB/s ± 0%  +0.96%  (p=0.016 n=5+5)
wuffs_gif_decode_1000k/clang5                     230MB/s ± 1%   232MB/s ± 0%  +1.25%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5           1.07GB/s ± 1%  1.11GB/s ± 1%  +3.52%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7                       467MB/s ± 0%   486MB/s ± 1%  +4.11%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7                    196MB/s ± 0%   186MB/s ± 1%  -4.69%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7                    639MB/s ± 1%   629MB/s ± 1%  -1.69%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7                 202MB/s ± 1%   199MB/s ± 0%  -1.13%  (p=0.016 n=5+5)
wuffs_gif_decode_20k/gcc7                         243MB/s ± 1%   243MB/s ± 0%    ~     (p=0.730 n=5+4)
wuffs_gif_decode_100k_artificial/gcc7             510MB/s ± 0%   510MB/s ± 1%    ~     (p=1.000 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7              211MB/s ± 0%   212MB/s ± 0%  +0.55%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc7                       214MB/s ± 0%   215MB/s ± 0%    ~     (p=0.056 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7             1.03GB/s ± 1%  1.05GB/s ± 3%    ~     (p=0.151 n=5+5)

wuffs_lzw_decode_20k/clang5                       267MB/s ± 2%   272MB/s ± 0%  +1.79%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5                      451MB/s ± 2%   469MB/s ± 1%  +3.99%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                         268MB/s ± 0%   269MB/s ± 0%  +0.40%  (p=0.032 n=5+5)
wuffs_lzw_decode_100k/gcc7                        483MB/s ± 1%   483MB/s ± 0%    ~     (p=1.000 n=5+5)
2019-02-23 13:13:26 +11:00
Nigel Tao 92959fb81f Check that extra-field types aren't refined 2019-02-16 15:40:02 +11:00
Nigel Tao 72f99800ca Tweak wuffsfmt's struct field type indentation 2019-02-16 12:43:04 +11:00
Nigel Tao 33eae7ae40 Set decoder_workbuf_len_max_incl_worst_case to 1 2019-02-16 12:31:23 +11:00
Nigel Tao 438fc10597 Move some struct fields to private_data
This means that they are not zero'ed by the initialize methods, which
improves some benchmark numbers. There is a trade-off here, as bugs in
the *.wuffs code could then mean that we are potentially reading
uninitialized memory (bulk data fields). Nonetheless, on some
micro-benchmarks, the relative performance gain on skipping this fixed
cost is stark, up to +96% throughput, or equivalently, -49% in time per
operation.

Callers of the Wuffs libraries have the option to zero-initialize the
entire state (and then pass WUFFS_INITIALIZE__ALREADY_ZEROED) or to
zero-initialize private_impl state but not private_data state (i.e. skip
the bulk data fields).

The numbers below are in two sections: throughput (e.g. MB/s) and time
per operation. Relatively large gains in throughput (e.g. +96%) can
correspond to small absolute gains (e.g. it's the difference between an
operation taking 2.02µs instead of 3.98µs).

--------

name                                             old speed      new speed      delta

wuffs_adler32_10k/clang5                         2.43GB/s ± 0%  2.44GB/s ± 0%   +0.13%  (p=0.000 n=47+48)
wuffs_adler32_100k/clang5                        2.44GB/s ± 0%  2.44GB/s ± 1%   +0.10%  (p=0.001 n=45+47)

wuffs_adler32_10k/gcc7                           3.24GB/s ± 0%  3.24GB/s ± 0%     ~     (p=0.933 n=47+46)
wuffs_adler32_100k/gcc7                          3.25GB/s ± 0%  3.25GB/s ± 1%     ~     (p=0.551 n=42+47)

wuffs_crc32_ieee_10k/clang5                      2.87GB/s ± 0%  2.87GB/s ± 0%     ~     (p=0.519 n=45+46)
wuffs_crc32_ieee_100k/clang5                     2.89GB/s ± 0%  2.89GB/s ± 1%     ~     (p=0.479 n=45+45)

wuffs_crc32_ieee_10k/gcc7                        3.35GB/s ± 0%  3.38GB/s ± 0%   +0.95%  (p=0.000 n=44+49)
wuffs_crc32_ieee_100k/gcc7                       3.39GB/s ± 1%  3.42GB/s ± 0%   +0.96%  (p=0.000 n=47+47)

wuffs_deflate_decode_1k/clang5                    139MB/s ± 1%   170MB/s ± 1%  +22.72%  (p=0.000 n=48+47)
wuffs_deflate_decode_10k/clang5                   232MB/s ± 1%   241MB/s ± 1%   +4.13%  (p=0.000 n=48+45)
wuffs_deflate_decode_100k_just_one_read/clang5    274MB/s ± 0%   277MB/s ± 1%   +1.14%  (p=0.000 n=47+45)
wuffs_deflate_decode_100k_many_big_reads/clang5   226MB/s ± 0%   226MB/s ± 1%     ~     (p=0.057 n=48+47)

wuffs_deflate_decode_1k/gcc7                      157MB/s ± 1%   198MB/s ± 1%  +25.61%  (p=0.000 n=45+45)
wuffs_deflate_decode_10k/gcc7                     265MB/s ± 0%   272MB/s ± 1%   +2.62%  (p=0.000 n=47+47)
wuffs_deflate_decode_100k_just_one_read/gcc7      322MB/s ± 0%   323MB/s ± 1%   +0.40%  (p=0.000 n=46+45)
wuffs_deflate_decode_100k_many_big_reads/gcc7     254MB/s ± 0%   254MB/s ± 0%   +0.23%  (p=0.000 n=43+46)

wuffs_gif_decode_1k_bw/clang5                     246MB/s ± 1%   448MB/s ± 0%  +82.21%  (p=0.000 n=48+44)
wuffs_gif_decode_1k_color/clang5                  145MB/s ± 0%   194MB/s ± 1%  +33.70%  (p=0.000 n=48+48)
wuffs_gif_decode_10k_bgra/clang5                  740MB/s ± 1%   747MB/s ± 0%   +0.97%  (p=0.000 n=49+45)
wuffs_gif_decode_10k_indexed/clang5               199MB/s ± 1%   201MB/s ± 0%   +1.30%  (p=0.000 n=46+45)
wuffs_gif_decode_20k/clang5                       251MB/s ± 0%   251MB/s ± 0%   +0.23%  (p=0.000 n=44+44)
wuffs_gif_decode_100k_artificial/clang5           557MB/s ± 1%   557MB/s ± 1%     ~     (p=0.653 n=45+47)
wuffs_gif_decode_100k_realistic/clang5            230MB/s ± 0%   229MB/s ± 0%   -0.45%  (p=0.000 n=45+46)
wuffs_gif_decode_1000k/clang5                     236MB/s ± 0%   233MB/s ± 0%   -0.91%  (p=0.000 n=46+48)
wuffs_gif_decode_anim_screencap/clang5           1.12GB/s ± 1%  1.11GB/s ± 0%   -0.74%  (p=0.000 n=47+45)

wuffs_gif_decode_1k_bw/gcc7                       257MB/s ± 1%   506MB/s ± 0%  +96.52%  (p=0.000 n=50+46)
wuffs_gif_decode_1k_color/gcc7                    146MB/s ± 1%   199MB/s ± 1%  +36.35%  (p=0.000 n=48+47)
wuffs_gif_decode_10k_bgra/gcc7                    632MB/s ± 1%   649MB/s ± 0%   +2.80%  (p=0.000 n=47+47)
wuffs_gif_decode_10k_indexed/gcc7                 198MB/s ± 1%   204MB/s ± 1%   +3.32%  (p=0.000 n=48+47)
wuffs_gif_decode_20k/gcc7                         242MB/s ± 0%   246MB/s ± 0%   +1.59%  (p=0.000 n=47+48)
wuffs_gif_decode_100k_artificial/gcc7             517MB/s ± 1%   521MB/s ± 0%   +0.71%  (p=0.000 n=46+46)
wuffs_gif_decode_100k_realistic/gcc7              214MB/s ± 0%   215MB/s ± 0%   +0.34%  (p=0.000 n=48+44)
wuffs_gif_decode_1000k/gcc7                       218MB/s ± 1%   218MB/s ± 0%     ~     (p=0.238 n=44+49)
wuffs_gif_decode_anim_screencap/gcc7             1.08GB/s ± 0%  1.07GB/s ± 1%   -0.27%  (p=0.000 n=45+45)

wuffs_gzip_decode_10k/clang5                      213MB/s ± 0%   222MB/s ± 0%   +4.08%  (p=0.000 n=43+46)
wuffs_gzip_decode_100k/clang5                     249MB/s ± 1%   253MB/s ± 0%   +1.50%  (p=0.000 n=47+46)

wuffs_gzip_decode_10k/gcc7                        246MB/s ± 1%   258MB/s ± 0%   +4.76%  (p=0.000 n=48+47)
wuffs_gzip_decode_100k/gcc7                       291MB/s ± 0%   291MB/s ± 0%     ~     (p=0.679 n=48+48)

wuffs_lzw_decode_20k/clang5                       274MB/s ± 0%   280MB/s ± 0%   +2.51%  (p=0.000 n=46+47)
wuffs_lzw_decode_100k/clang5                      484MB/s ± 0%   487MB/s ± 0%   +0.58%  (p=0.000 n=46+49)

wuffs_lzw_decode_20k/gcc7                         267MB/s ± 0%   274MB/s ± 2%   +2.31%  (p=0.000 n=41+43)
wuffs_lzw_decode_100k/gcc7                        489MB/s ± 1%   486MB/s ± 2%   -0.67%  (p=0.000 n=47+42)

wuffs_zlib_decode_10k/clang5                      212MB/s ± 1%   219MB/s ± 0%   +3.66%  (p=0.000 n=47+47)
wuffs_zlib_decode_100k/clang5                     246MB/s ± 1%   248MB/s ± 0%   +0.69%  (p=0.000 n=47+46)

wuffs_zlib_decode_10k/gcc7                        251MB/s ± 0%   255MB/s ± 0%   +1.83%  (p=0.000 n=45+44)
wuffs_zlib_decode_100k/gcc7                       294MB/s ± 1%   290MB/s ± 0%   -1.33%  (p=0.000 n=43+42)

--------

name                                             old time/op    new time/op    delta

wuffs_adler32_10k/clang5                           4.54µs ± 1%    4.54µs ± 0%   -0.15%  (p=0.000 n=48+48)
wuffs_adler32_100k/clang5                          41.0µs ± 0%    41.0µs ± 1%   -0.10%  (p=0.001 n=45+47)

wuffs_adler32_10k/gcc7                             3.41µs ± 0%    3.41µs ± 0%     ~     (p=0.890 n=47+46)
wuffs_adler32_100k/gcc7                            30.8µs ± 0%    30.8µs ± 1%     ~     (p=0.557 n=42+47)

wuffs_crc32_ieee_10k/clang5                        3.86µs ± 0%    3.86µs ± 0%     ~     (p=0.602 n=45+46)
wuffs_crc32_ieee_100k/clang5                       34.6µs ± 0%    34.6µs ± 1%     ~     (p=0.475 n=45+45)

wuffs_crc32_ieee_10k/gcc7                          3.30µs ± 0%    3.27µs ± 0%   -0.94%  (p=0.000 n=45+49)
wuffs_crc32_ieee_100k/gcc7                         29.5µs ± 1%    29.3µs ± 0%   -0.95%  (p=0.000 n=47+47)

wuffs_deflate_decode_1k/clang5                     6.79µs ± 1%    5.54µs ± 1%  -18.52%  (p=0.000 n=48+47)
wuffs_deflate_decode_10k/clang5                    47.8µs ± 1%    45.9µs ± 1%   -3.96%  (p=0.000 n=48+45)
wuffs_deflate_decode_100k_just_one_read/clang5      365µs ± 0%     361µs ± 1%   -1.12%  (p=0.000 n=47+45)
wuffs_deflate_decode_100k_many_big_reads/clang5     442µs ± 0%     443µs ± 1%     ~     (p=0.057 n=48+47)

wuffs_deflate_decode_1k/gcc7                       5.99µs ± 1%    4.77µs ± 1%  -20.39%  (p=0.000 n=45+45)
wuffs_deflate_decode_10k/gcc7                      41.7µs ± 0%    40.6µs ± 1%   -2.56%  (p=0.000 n=47+47)
wuffs_deflate_decode_100k_just_one_read/gcc7        311µs ± 0%     310µs ± 1%   -0.40%  (p=0.000 n=46+45)
wuffs_deflate_decode_100k_many_big_reads/gcc7       394µs ± 0%     393µs ± 0%   -0.23%  (p=0.000 n=43+46)

wuffs_gif_decode_1k_bw/clang5                      4.17µs ± 1%    2.29µs ± 0%  -45.12%  (p=0.000 n=46+44)
wuffs_gif_decode_1k_color/clang5                   6.95µs ± 0%    5.20µs ± 1%  -25.21%  (p=0.000 n=48+48)
wuffs_gif_decode_10k_bgra/clang5                   54.5µs ± 1%    54.0µs ± 0%   -0.96%  (p=0.000 n=49+45)
wuffs_gif_decode_10k_indexed/clang5                50.7µs ± 1%    50.1µs ± 0%   -1.28%  (p=0.000 n=46+45)
wuffs_gif_decode_20k/clang5                        76.6µs ± 0%    76.4µs ± 0%   -0.23%  (p=0.000 n=44+44)
wuffs_gif_decode_100k_artificial/clang5             248µs ± 1%     248µs ± 1%     ~     (p=0.653 n=45+47)
wuffs_gif_decode_100k_realistic/clang5              599µs ± 0%     602µs ± 0%   +0.45%  (p=0.000 n=45+46)
wuffs_gif_decode_1000k/clang5                      4.25ms ± 0%    4.29ms ± 0%   +0.92%  (p=0.000 n=46+48)
wuffs_gif_decode_anim_screencap/clang5             4.17ms ± 1%    4.20ms ± 0%   +0.74%  (p=0.000 n=47+45)

wuffs_gif_decode_1k_bw/gcc7                        3.98µs ± 1%    2.02µs ± 0%  -49.12%  (p=0.000 n=50+46)
wuffs_gif_decode_1k_color/gcc7                     6.90µs ± 1%    5.06µs ± 0%  -26.67%  (p=0.000 n=48+46)
wuffs_gif_decode_10k_bgra/gcc7                     63.8µs ± 1%    62.1µs ± 0%   -2.73%  (p=0.000 n=47+47)
wuffs_gif_decode_10k_indexed/gcc7                  50.9µs ± 1%    49.3µs ± 1%   -3.22%  (p=0.000 n=48+47)
wuffs_gif_decode_20k/gcc7                          79.3µs ± 0%    78.1µs ± 0%   -1.57%  (p=0.000 n=47+48)
wuffs_gif_decode_100k_artificial/gcc7               267µs ± 0%     265µs ± 0%   -0.69%  (p=0.000 n=45+46)
wuffs_gif_decode_100k_realistic/gcc7                643µs ± 0%     641µs ± 0%   -0.34%  (p=0.000 n=48+44)
wuffs_gif_decode_1000k/gcc7                        4.59ms ± 1%    4.58ms ± 0%     ~     (p=0.238 n=44+49)
wuffs_gif_decode_anim_screencap/gcc7               4.32ms ± 0%    4.33ms ± 1%   +0.27%  (p=0.000 n=45+45)

wuffs_gzip_decode_10k/clang5                       51.9µs ± 0%    49.8µs ± 0%   -3.92%  (p=0.000 n=43+46)
wuffs_gzip_decode_100k/clang5                       401µs ± 1%     395µs ± 0%   -1.48%  (p=0.000 n=47+46)

wuffs_gzip_decode_10k/gcc7                         44.9µs ± 1%    42.9µs ± 0%   -4.54%  (p=0.000 n=48+47)
wuffs_gzip_decode_100k/gcc7                         343µs ± 0%     343µs ± 0%     ~     (p=0.679 n=48+48)

wuffs_lzw_decode_20k/clang5                        70.2µs ± 0%    68.5µs ± 0%   -2.45%  (p=0.000 n=46+47)
wuffs_lzw_decode_100k/clang5                        207µs ± 0%     206µs ± 0%   -0.58%  (p=0.000 n=46+49)

wuffs_lzw_decode_20k/gcc7                          71.8µs ± 0%    70.2µs ± 2%   -2.25%  (p=0.000 n=41+43)
wuffs_lzw_decode_100k/gcc7                          204µs ± 1%     206µs ± 2%   +0.67%  (p=0.000 n=47+42)

wuffs_zlib_decode_10k/clang5                       52.3µs ± 1%    50.4µs ± 0%   -3.53%  (p=0.000 n=47+47)
wuffs_zlib_decode_100k/clang5                       406µs ± 1%     404µs ± 0%   -0.68%  (p=0.000 n=47+46)

wuffs_zlib_decode_10k/gcc7                         44.2µs ± 0%    43.4µs ± 0%   -1.79%  (p=0.000 n=45+44)
wuffs_zlib_decode_100k/gcc7                         340µs ± 1%     345µs ± 0%   +1.35%  (p=0.000 n=43+42)

--------
2019-02-13 11:54:46 +11:00
Nigel Tao f792ce7bc3 Rename the lzw.decoder.lw field 2019-02-09 14:03:53 +11:00
Nigel Tao 0842bc7115 Make the GIF dirty_rect be in the frame_rect
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11823
2019-02-09 13:56:24 +11:00
Nigel Tao 2928806ab6 Re-arrange struct fields so bulk data is last
name                                             old speed      new speed      delta

wuffs_adler32_10k/clang5                         2.42GB/s ± 1%  2.43GB/s ± 1%  +0.15%  (p=0.014 n=46+45)
wuffs_adler32_100k/clang5                        2.43GB/s ± 1%  2.43GB/s ± 1%    ~     (p=0.532 n=43+46)

wuffs_adler32_10k/gcc7                           3.22GB/s ± 0%  3.23GB/s ± 1%  +0.17%  (p=0.000 n=47+48)
wuffs_adler32_100k/gcc7                          3.23GB/s ± 0%  3.23GB/s ± 0%  +0.20%  (p=0.000 n=45+48)

wuffs_crc32_ieee_10k/clang5                      2.86GB/s ± 0%  2.86GB/s ± 0%  +0.22%  (p=0.000 n=47+46)
wuffs_crc32_ieee_100k/clang5                     2.88GB/s ± 0%  2.88GB/s ± 1%  +0.11%  (p=0.006 n=48+47)

wuffs_crc32_ieee_10k/gcc7                        3.37GB/s ± 1%  3.37GB/s ± 1%    ~     (p=0.050 n=49+48)
wuffs_crc32_ieee_100k/gcc7                       3.40GB/s ± 0%  3.40GB/s ± 1%  +0.15%  (p=0.001 n=46+48)

wuffs_deflate_decode_1k/clang5                    139MB/s ± 0%   138MB/s ± 0%  -0.44%  (p=0.000 n=45+47)
wuffs_deflate_decode_10k/clang5                   222MB/s ± 0%   233MB/s ± 1%  +4.81%  (p=0.000 n=45+47)
wuffs_deflate_decode_100k_just_one_read/clang5    260MB/s ± 1%   274MB/s ± 0%  +5.34%  (p=0.000 n=46+45)
wuffs_deflate_decode_100k_many_big_reads/clang5   218MB/s ± 0%   224MB/s ± 1%  +2.36%  (p=0.000 n=44+46)

wuffs_deflate_decode_1k/gcc7                      158MB/s ± 1%   157MB/s ± 1%  -0.23%  (p=0.000 n=44+48)
wuffs_deflate_decode_10k/gcc7                     266MB/s ± 1%   265MB/s ± 1%  -0.48%  (p=0.000 n=45+47)
wuffs_deflate_decode_100k_just_one_read/gcc7      323MB/s ± 1%   320MB/s ± 0%  -0.87%  (p=0.000 n=46+46)
wuffs_deflate_decode_100k_many_big_reads/gcc7     255MB/s ± 0%   252MB/s ± 0%  -1.04%  (p=0.000 n=42+44)

wuffs_gif_decode_1k_bw/clang5                     243MB/s ± 1%   238MB/s ± 1%  -1.74%  (p=0.000 n=49+48)
wuffs_gif_decode_1k_color/clang5                  142MB/s ± 1%   140MB/s ± 1%  -1.17%  (p=0.000 n=45+49)
wuffs_gif_decode_10k_bgra/clang5                  723MB/s ± 1%   720MB/s ± 1%  -0.37%  (p=0.000 n=48+49)
wuffs_gif_decode_10k_indexed/clang5               193MB/s ± 1%   194MB/s ± 1%  +0.23%  (p=0.002 n=49+48)
wuffs_gif_decode_20k/clang5                       245MB/s ± 1%   246MB/s ± 1%  +0.20%  (p=0.002 n=49+46)
wuffs_gif_decode_100k_artificial/clang5           542MB/s ± 1%   543MB/s ± 1%  +0.16%  (p=0.012 n=48+47)
wuffs_gif_decode_100k_realistic/clang5            227MB/s ± 1%   226MB/s ± 1%  -0.31%  (p=0.000 n=48+45)
wuffs_gif_decode_1000k/clang5                     232MB/s ± 0%   231MB/s ± 1%  -0.40%  (p=0.000 n=48+42)
wuffs_gif_decode_anim_screencap/clang5           1.08GB/s ± 1%  1.07GB/s ± 1%  -1.09%  (p=0.000 n=46+46)

wuffs_gif_decode_1k_bw/gcc7                       264MB/s ± 1%   262MB/s ± 1%  -0.81%  (p=0.000 n=50+49)
wuffs_gif_decode_1k_color/gcc7                    148MB/s ± 0%   146MB/s ± 1%  -1.60%  (p=0.000 n=47+49)
wuffs_gif_decode_10k_bgra/gcc7                    621MB/s ± 1%   618MB/s ± 1%  -0.47%  (p=0.000 n=49+49)
wuffs_gif_decode_10k_indexed/gcc7                 194MB/s ± 1%   194MB/s ± 3%    ~     (p=0.222 n=49+50)
wuffs_gif_decode_20k/gcc7                         236MB/s ± 1%   237MB/s ± 1%  +0.52%  (p=0.000 n=49+45)
wuffs_gif_decode_100k_artificial/gcc7             505MB/s ± 1%   507MB/s ± 1%  +0.36%  (p=0.000 n=46+47)
wuffs_gif_decode_100k_realistic/gcc7              210MB/s ± 1%   210MB/s ± 1%    ~     (p=0.081 n=49+42)
wuffs_gif_decode_1000k/gcc7                       213MB/s ± 1%   213MB/s ± 1%  -0.19%  (p=0.001 n=49+47)
wuffs_gif_decode_anim_screencap/gcc7             1.06GB/s ± 0%  1.05GB/s ± 1%  -1.02%  (p=0.000 n=48+47)

wuffs_gzip_decode_10k/clang5                      206MB/s ± 0%   215MB/s ± 0%  +4.52%  (p=0.000 n=49+44)
wuffs_gzip_decode_100k/clang5                     239MB/s ± 0%   250MB/s ± 0%  +4.71%  (p=0.000 n=47+46)

wuffs_gzip_decode_10k/gcc7                        250MB/s ± 1%   249MB/s ± 0%  -0.38%  (p=0.000 n=47+50)
wuffs_gzip_decode_100k/gcc7                       293MB/s ± 0%   289MB/s ± 0%  -1.28%  (p=0.000 n=45+44)

wuffs_lzw_decode_20k/clang5                       265MB/s ± 1%   265MB/s ± 0%    ~     (p=0.331 n=47+44)
wuffs_lzw_decode_100k/clang5                      452MB/s ± 1%   450MB/s ± 1%  -0.31%  (p=0.001 n=48+46)

wuffs_lzw_decode_20k/gcc7                         264MB/s ± 1%   263MB/s ± 1%  -0.49%  (p=0.000 n=48+47)
wuffs_lzw_decode_100k/gcc7                        481MB/s ± 1%   475MB/s ± 1%  -1.22%  (p=0.000 n=48+50)

wuffs_zlib_decode_10k/clang5                      202MB/s ± 0%   212MB/s ± 0%  +5.18%  (p=0.000 n=46+46)
wuffs_zlib_decode_100k/clang5                     235MB/s ± 0%   247MB/s ± 0%  +4.92%  (p=0.000 n=46+45)

wuffs_zlib_decode_10k/gcc7                        246MB/s ± 0%   246MB/s ± 0%  -0.13%  (p=0.001 n=45+47)
wuffs_zlib_decode_100k/gcc7                       289MB/s ± 0%   291MB/s ± 0%  +0.67%  (p=0.000 n=47+46)
2019-02-09 10:35:48 +11:00
Nigel Tao fc4abafbe7 Rename decoder_max_incl_workbuf_len constants 2019-02-03 15:44:25 +11:00
Nigel Tao d9c36922db Add comment on lzw.decoder.suffixes performance 2019-02-03 15:32:40 +11:00
Nigel Tao 3056a84393 Roll back 3 recent lzw.decoder.suffixes commits
Specifically:
49627b4 Flatten the lzw.decoder.suffixes array
f877fb2 Use the workbuf instead of lzw.decoder.suffixes
85be5b9 Delete the obsolete lzw.decoder.suffixes array

name                                     old speed      new speed      delta

wuffs_lzw_decode_20k/clang5               247MB/s ± 0%   265MB/s ± 0%   +7.31%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5              407MB/s ± 0%   452MB/s ± 1%  +11.21%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                 238MB/s ± 1%   263MB/s ± 1%  +10.81%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc7                384MB/s ± 0%   482MB/s ± 2%  +25.54%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/clang5             318MB/s ± 0%   241MB/s ± 1%  -24.15%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang5          154MB/s ± 0%   141MB/s ± 1%   -8.58%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5          697MB/s ± 1%   721MB/s ± 0%   +3.53%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5       186MB/s ± 0%   194MB/s ± 1%   +4.20%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5               226MB/s ± 1%   246MB/s ± 1%   +8.85%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang5   508MB/s ± 1%   551MB/s ± 0%   +8.33%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5    203MB/s ± 0%   227MB/s ± 0%  +11.88%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang5             206MB/s ± 0%   231MB/s ± 0%  +12.46%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5   1.03GB/s ± 0%  1.10GB/s ± 0%   +5.85%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7               398MB/s ± 0%   265MB/s ± 1%  -33.35%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7            161MB/s ± 0%   145MB/s ± 1%   -9.74%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7            604MB/s ± 1%   622MB/s ± 1%   +2.94%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7         187MB/s ± 1%   194MB/s ± 0%   +3.83%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                 227MB/s ± 0%   234MB/s ± 1%   +3.09%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7     492MB/s ± 0%   506MB/s ± 1%   +2.91%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7      201MB/s ± 0%   210MB/s ± 1%   +4.42%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc7               203MB/s ± 0%   213MB/s ± 0%   +4.97%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7     1.04GB/s ± 0%  1.06GB/s ± 0%   +2.61%  (p=0.008 n=5+5)
2019-02-03 15:25:53 +11:00
Nigel Tao 85be5b9f8a Delete the obsolete lzw.decoder.suffixes array
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.

Avoiding the zero-initialization of the 32768-byte array avoids a fixed
cost, regardless of e.g. the size of the decoded GIF image. A fixed
absolute improvement is a bigger relative improvement for smaller GIFs.

Compared to the previous commit:

name                                     old speed      new speed      delta

wuffs_lzw_decode_20k/clang5               241MB/s ± 0%   247MB/s ± 0%   +2.71%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5              401MB/s ± 1%   407MB/s ± 0%   +1.42%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                 235MB/s ± 0%   238MB/s ± 1%   +1.21%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc7                382MB/s ± 0%   384MB/s ± 0%     ~     (p=0.095 n=5+5)

wuffs_gif_decode_1k_bw/clang5             235MB/s ± 1%   318MB/s ± 0%  +35.34%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang5          132MB/s ± 0%   154MB/s ± 0%  +16.47%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5          678MB/s ± 0%   697MB/s ± 1%   +2.75%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5       181MB/s ± 0%   186MB/s ± 0%   +2.65%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5               226MB/s ± 0%   226MB/s ± 1%     ~     (p=0.690 n=5+5)
wuffs_gif_decode_100k_artificial/clang5   506MB/s ± 0%   508MB/s ± 1%     ~     (p=0.222 n=5+5)
wuffs_gif_decode_100k_realistic/clang5    203MB/s ± 1%   203MB/s ± 0%     ~     (p=0.310 n=5+5)
wuffs_gif_decode_1000k/clang5             206MB/s ± 0%   206MB/s ± 0%   -0.26%  (p=0.032 n=5+5)
wuffs_gif_decode_anim_screencap/clang5   1.04GB/s ± 1%  1.03GB/s ± 0%     ~     (p=0.151 n=5+5)

wuffs_gif_decode_1k_bw/gcc7               255MB/s ± 1%   398MB/s ± 0%  +56.43%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7            137MB/s ± 1%   161MB/s ± 0%  +17.63%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7            593MB/s ± 0%   604MB/s ± 1%   +1.83%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7         182MB/s ± 2%   187MB/s ± 1%   +2.85%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                 226MB/s ± 0%   227MB/s ± 0%   +0.56%  (p=0.032 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7     488MB/s ± 0%   492MB/s ± 0%   +0.80%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7      203MB/s ± 0%   201MB/s ± 0%   -1.29%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc7               207MB/s ± 0%   203MB/s ± 0%   -2.17%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7     1.03GB/s ± 0%  1.04GB/s ± 0%   +0.67%  (p=0.008 n=5+5)
2019-02-03 15:02:16 +11:00
Nigel Tao f877fb2c59 Use the workbuf instead of lzw.decoder.suffixes
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.

name                                     old speed      new speed      delta

wuffs_lzw_decode_20k/clang5               255MB/s ± 0%   241MB/s ± 0%   -5.63%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5              418MB/s ± 1%   401MB/s ± 1%   -4.02%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                 255MB/s ± 1%   235MB/s ± 0%   -7.88%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc7                444MB/s ± 1%   382MB/s ± 0%  -13.90%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/clang5             239MB/s ± 2%   235MB/s ± 1%   -1.89%  (p=0.016 n=5+5)
wuffs_gif_decode_1k_color/clang5          135MB/s ± 0%   132MB/s ± 0%   -1.86%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5          692MB/s ± 1%   678MB/s ± 0%   -2.08%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5       186MB/s ± 0%   181MB/s ± 0%   -2.58%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5               237MB/s ± 1%   226MB/s ± 0%   -4.46%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang5   536MB/s ± 0%   506MB/s ± 0%   -5.53%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5    219MB/s ± 0%   203MB/s ± 1%   -7.11%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang5             222MB/s ± 0%   206MB/s ± 0%   -7.25%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5   1.07GB/s ± 0%  1.04GB/s ± 1%   -3.11%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7               262MB/s ± 0%   255MB/s ± 1%   -2.63%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7            142MB/s ± 1%   137MB/s ± 1%   -3.38%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7            596MB/s ± 1%   593MB/s ± 0%     ~     (p=0.151 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7         185MB/s ± 0%   182MB/s ± 2%   -1.63%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                 230MB/s ± 0%   226MB/s ± 0%   -1.78%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7     490MB/s ± 1%   488MB/s ± 0%     ~     (p=0.095 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7      203MB/s ± 1%   203MB/s ± 0%     ~     (p=0.421 n=5+5)
wuffs_gif_decode_1000k/gcc7               207MB/s ± 0%   207MB/s ± 0%     ~     (p=1.000 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7     1.04GB/s ± 0%  1.03GB/s ± 0%   -0.83%  (p=0.008 n=5+5)
2019-02-03 14:57:34 +11:00
Nigel Tao 49627b46f2 Flatten the lzw.decoder.suffixes array
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.

name                                     old speed      new speed      delta

wuffs_lzw_decode_20k/clang5               265MB/s ± 0%   255MB/s ± 0%  -3.85%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5              452MB/s ± 1%   418MB/s ± 1%  -7.62%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                 263MB/s ± 1%   255MB/s ± 1%  -3.21%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc7                482MB/s ± 2%   444MB/s ± 1%  -7.85%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/clang5             241MB/s ± 1%   239MB/s ± 2%    ~     (p=0.310 n=5+5)
wuffs_gif_decode_1k_color/clang5          141MB/s ± 1%   135MB/s ± 0%  -4.30%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5          721MB/s ± 0%   692MB/s ± 1%  -4.00%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5       194MB/s ± 1%   186MB/s ± 0%  -4.03%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5               246MB/s ± 1%   237MB/s ± 1%  -3.60%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang5   551MB/s ± 0%   536MB/s ± 0%  -2.73%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5    227MB/s ± 0%   219MB/s ± 0%  -3.74%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang5             231MB/s ± 0%   222MB/s ± 0%  -3.88%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5   1.10GB/s ± 0%  1.07GB/s ± 0%  -2.35%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7               265MB/s ± 1%   262MB/s ± 0%  -1.49%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7            145MB/s ± 1%   142MB/s ± 1%  -2.52%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7            622MB/s ± 1%   596MB/s ± 1%  -4.18%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7         194MB/s ± 0%   185MB/s ± 0%  -4.81%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                 234MB/s ± 1%   230MB/s ± 0%  -1.80%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7     506MB/s ± 1%   490MB/s ± 1%  -3.14%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7      210MB/s ± 1%   203MB/s ± 1%  -2.89%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc7               213MB/s ± 0%   207MB/s ± 0%  -2.66%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7     1.06GB/s ± 0%  1.04GB/s ± 0%  -2.38%  (p=0.008 n=5+5)
2019-02-03 13:39:43 +11:00