SPDX is an ISO standard for describing licenses in a computer readable
format, which is useful when applying license compliance tools and the
like to source code.
In addition to ensuring that the Wuffs C distribution is properly
annotated to the benefit of projects using Wuffs and SPDX-supporting
tools, add it everywhere else where there's a license in this repo for
consistency, too.
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.
name old speed new speed delta
wuffs_xxhash32_10k/clang11 7.81GB/s ± 0% 4.46GB/s ± 1% -42.86% (p=0.008 n=5+5)
wuffs_xxhash32_100k/clang11 7.96GB/s ± 0% 4.67GB/s ± 1% -41.34% (p=0.008 n=5+5)
wuffs_xxhash32_10k/gcc10 7.83GB/s ± 0% 4.48GB/s ± 2% -42.81% (p=0.008 n=5+5)
wuffs_xxhash32_100k/gcc10 7.95GB/s ± 0% 4.69GB/s ± 2% -41.04% (p=0.008 n=5+5)
mimic_xxhash32_10k 7.70GB/s ± 1% 7.73GB/s ± 1% ~ (p=0.421 n=5+5)
mimic_xxhash32_100k 7.79GB/s ± 0% 7.84GB/s ± 1% ~ (p=0.730 n=4+5)
The LICENSE has changed from a single license (Apache2) to a dual
license (Apache2 or MIT, at your option).
If you've previously used Wuffs under the Apache2 license, you are able
to keep doing so. No further action required by you.
The two files listed below (previous releases) are exceptions, as they
are older snapshots, frozen in time. Their license has not changed:
release/c/wuffs-v0.2.c
release/c/wuffs-v0.3.c
Every name in the AUTHORS file, other than Google Inc., has signed
Google's CLA (Contributor License Agreement).
This only affects truncated (malformed) JPEGs. It moves Wuffs' std/jpeg
decoder closer to libjpeg-turbo, as seen by the "hash of the decoded
output" for test/data/peacock.default.truncated.jpeg now matching
test/data/peacock.default.truncated.decoded-by-djpeg.png instead of
test/data/peacock.default.truncated.decoded-by-wuffs.png
The decoding of test/data/peacock.progressive.truncated.jpeg is not yet
affected, requiring further investigation, but a future commit could
similarly make that match djpeg.
The two libraries don't use exactly the same algorithm because, for
performance, Wuffs' decoder reads from the bitstream 8 bytes at a time
where libjpeg-turbo reads only 1 byte at a time.
While this change moves Wuffs' output closer to libjpeg-turbo (to
repeat, only for truncated JPEGs; well-formed JPEGs are unaffected), the
benchmarks below show a negative performance impact, and visual
inspection of test/data/peacock.*.truncated.decoded-by-*.png shows that
matching libjpeg-turbo *exactly* on truncated JPEGs doesn't actually
always look better.
On balance, it doesn't seem worth it to keep this change (and spend more
time on that further investigation).
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 378MB/s ± 0% 364MB/s ± 0% -3.53% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 325MB/s ± 0% 340MB/s ± 0% +4.62% (p=0.016 n=5+4)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.02GB/s ± 0% 0.99GB/s ± 0% -2.64% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 842MB/s ± 0% 815MB/s ± 0% -3.16% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 916MB/s ± 0% 887MB/s ± 0% -3.08% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.10GB/s ± 0% 1.07GB/s ± 2% -3.39% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 919MB/s ± 0% 892MB/s ± 0% -2.95% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 360MB/s ± 0% 348MB/s ± 0% -3.34% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 290MB/s ± 0% 283MB/s ± 0% -2.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 925MB/s ± 0% 909MB/s ± 0% -1.70% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 758MB/s ± 0% 732MB/s ± 0% -3.43% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 829MB/s ± 0% 799MB/s ± 0% -3.54% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 981MB/s ± 0% 964MB/s ± 0% -1.72% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 835MB/s ± 0% 811MB/s ± 0% -2.89% (p=0.008 n=5+5)