Nigel Tao
|
19f56ebfd2
|
lang: allow "slice_var as ptr array[etc] etc"
|
2023-06-13 22:38:25 +10:00 |
|
Nigel Tao
|
8ac22ceab2
|
cgen: allow "var x : nptr array[etc] etc"
|
2023-06-13 10:49:37 +10:00 |
|
Nigel Tao
|
3705e0d93a
|
cgen: io_reader.is_closed doesn't need derived var
|
2023-01-31 23:33:02 +11:00 |
|
Nigel Tao
|
b0e9efff3f
|
Avoid (NULL + 0) in derived io_buffer variables
This addresses a "runtime error: applying zero offset to null pointer"
UBSAN (Undefined Behavior Sanitizer) warning using clang 15.0.1:
https://logs.chromium.org/logs/skia/5e005cc1b1981011/+/steps/dm/0/stdout
The offending line of code was "io1_a_dst = io0_a_dst + a_dst->meta.wi"
in wuffs_lzw__decoder__write_to and "io1_a_dst = NULL + 0" was Undefined
Behavior even though io1_a_dst was never dereferenced.
This commit avoids initializing io1_a_dst to (NULL + 0) when io0_a_dst
is NULL, falling back to initializing it with just NULL.
As discussed in https://reviews.llvm.org/D67122 while (nullptr + 0) is
Defined Behavior according to the C++ spec, (NULL + 0) is Undefined
Behavior (by omission) in C11 6.5.6/8: "If both the pointer operand and
the result point to elements of the same array object, or one past the
last element of the array object, the evaluation shall not produce an
overflow; otherwise, the behavior is undefined."
The benchmarks (an excerpt of the full suite is below) seem quite
sensitive to this simple change that's outside of hot loops, sometimes
much better and sometimes much worse. I don't know why.
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 63.1MB/s ± 0% 58.4MB/s ± 0% -7.43% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 49.4MB/s ± 0% 46.2MB/s ± 0% -6.35% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 60.9MB/s ± 0% 56.3MB/s ± 0% -7.59% (p=0.016 n=5+4)
wuffs_bzip2_decode_100k/gcc10 49.6MB/s ± 0% 47.0MB/s ± 0% -5.15% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/clang11 196MB/s ± 0% 195MB/s ± 1% -0.63% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/clang11 226MB/s ± 0% 224MB/s ± 0% -0.95% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/clang11 409MB/s ± 0% 420MB/s ± 0% +2.84% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/clang11 418MB/s ± 0% 431MB/s ± 0% +2.97% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/clang11 517MB/s ± 1% 542MB/s ± 0% +4.78% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/clang11 330MB/s ± 0% 338MB/s ± 0% +2.45% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/gcc10 188MB/s ± 0% 177MB/s ± 0% -5.38% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/gcc10 218MB/s ± 0% 209MB/s ± 0% -4.11% (p=0.016 n=4+5)
wuffs_deflate_decode_10k_full_init/gcc10 402MB/s ± 0% 407MB/s ± 1% +1.19% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/gcc10 413MB/s ± 0% 419MB/s ± 1% +1.64% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/gcc10 520MB/s ± 0% 532MB/s ± 0% +2.25% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/gcc10 330MB/s ± 0% 335MB/s ± 0% +1.56% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/clang11 781MB/s ± 0% 645MB/s ± 0% -17.46% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/clang11 176MB/s ± 0% 181MB/s ± 0% +3.11% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/clang11 215MB/s ± 0% 223MB/s ± 0% +3.46% (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang11 786MB/s ± 0% 801MB/s ± 0% +1.94% (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang11 208MB/s ± 0% 211MB/s ± 0% +1.44% (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang11 261MB/s ± 0% 252MB/s ± 0% -3.43% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang11 578MB/s ± 0% 583MB/s ± 0% +0.86% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang11 224MB/s ± 0% 223MB/s ± 0% -0.79% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/clang11 229MB/s ± 0% 225MB/s ± 0% -1.73% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/clang11 229MB/s ± 0% 225MB/s ± 0% -1.69% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang11 1.31GB/s ± 0% 1.29GB/s ± 0% -1.06% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/gcc10 650MB/s ± 0% 631MB/s ± 0% -3.03% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/gcc10 169MB/s ± 0% 168MB/s ± 0% -0.51% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/gcc10 202MB/s ± 0% 202MB/s ± 0% -0.18% (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc10 766MB/s ± 0% 790MB/s ± 0% +3.08% (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc10 202MB/s ± 0% 208MB/s ± 0% +3.16% (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc10 250MB/s ± 0% 258MB/s ± 0% +3.20% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc10 563MB/s ± 0% 566MB/s ± 0% +0.57% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc10 217MB/s ± 0% 220MB/s ± 0% +1.49% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/gcc10 220MB/s ± 0% 224MB/s ± 0% +1.49% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/gcc10 220MB/s ± 0% 224MB/s ± 0% +1.43% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc10 1.30GB/s ± 0% 1.30GB/s ± 0% +0.34% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/clang11 293MB/s ± 0% 292MB/s ± 0% -0.41% (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang11 486MB/s ± 0% 537MB/s ± 0% +10.49% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/gcc10 258MB/s ± 0% 276MB/s ± 0% +7.19% (p=0.016 n=4+5)
wuffs_lzw_decode_100k/gcc10 512MB/s ± 0% 527MB/s ± 0% +3.08% (p=0.016 n=4+5)
|
2022-10-20 11:18:09 +11:00 |
|
Nigel Tao
|
f73f95b698
|
Rename from ast.IOBind to ast.IOManip
|
2021-08-15 08:40:05 +10:00 |
|
Nigel Tao
|
decb64e5ea
|
Add ast.ExprOperatorEtc constants
|
2021-03-29 19:54:51 +11:00 |
|
Nigel Tao
|
41e407a774
|
Add some ast.Expr.IsEtc methods
|
2021-03-28 23:07:21 +11:00 |
|
Nigel Tao
|
492068f3dc
|
Prepare to add cpu_arch_utility types
|
2021-02-18 16:16:48 +11:00 |
|
Nigel Tao
|
84f3592dbe
|
Add base.arm_crc32_u32 type
On a Raspberry Pi 4 (32-bit armv7l) with -march=native and -mfpu=neon
("native" means "armv8-a+crc+simd"):
wuffs_crc32_ieee_10k/clang9 825MB/s ± 0% 6802MB/s ± 0% +724.00% (p=0.008 n=5+5)
wuffs_crc32_ieee_100k/clang9 837MB/s ± 0% 6199MB/s ± 0% +640.25% (p=0.008 n=5+5)
wuffs_crc32_ieee_10k/gcc8 960MB/s ± 0% 4495MB/s ± 0% +368.35% (p=0.016 n=4+5)
wuffs_crc32_ieee_100k/gcc8 961MB/s ± 0% 4447MB/s ± 0% +363.01% (p=0.016 n=5+4)
mimic_crc32_ieee_10k 638MB/s ± 0% 631MB/s ± 0% -1.17% (p=0.008 n=5+5)
mimic_crc32_ieee_100k 639MB/s ± 0% 639MB/s ± 0% +0.02% (p=0.008 n=5+5)
wuffs_gzip_decode_10k/clang9 83.0MB/s ± 0% 90.7MB/s ± 0% +9.26% (p=0.008 n=5+5)
wuffs_gzip_decode_100k/clang9 100MB/s ± 0% 112MB/s ± 0% +11.91% (p=0.008 n=5+5)
wuffs_gzip_decode_10k/gcc8 86.1MB/s ± 0% 91.9MB/s ± 0% +6.72% (p=0.008 n=5+5)
wuffs_gzip_decode_100k/gcc8 102MB/s ± 0% 112MB/s ± 0% +9.34% (p=0.008 n=5+5)
mimic_gzip_decode_10k 98.8MB/s ± 0% 98.2MB/s ± 0% -0.60% (p=0.008 n=5+5)
mimic_gzip_decode_100k 128MB/s ± 0% 128MB/s ± 0% -0.08% (p=0.008 n=5+5)
wuffs_png_decode_image_19k_8bpp/clang9 67.6MB/s ± 0% 70.8MB/s ± 0% +4.72% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/clang9 92.8MB/s ± 0% 98.8MB/s ± 0% +6.49% (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/clang9 255MB/s ± 0% 269MB/s ± 0% +5.44% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang9 123MB/s ± 0% 123MB/s ± 0% +0.13% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang9 110MB/s ± 0% 112MB/s ± 0% +1.46% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/clang9 88.4MB/s ± 0% 92.8MB/s ± 0% +4.90% (p=0.008 n=5+5)
wuffs_png_decode_image_19k_8bpp/gcc8 67.2MB/s ± 0% 70.8MB/s ± 0% +5.37% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/gcc8 94.0MB/s ± 0% 98.2MB/s ± 0% +4.45% (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/gcc8 236MB/s ± 0% 248MB/s ± 0% +4.84% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc8 114MB/s ± 0% 115MB/s ± 0% +1.11% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc8 102MB/s ± 0% 104MB/s ± 0% +2.17% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/gcc8 88.8MB/s ± 0% 94.3MB/s ± 0% +6.21% (p=0.008 n=5+5)
mimic_png_decode_image_19k_8bpp 43.7MB/s ± 1% 43.4MB/s ± 1% ~ (p=0.095 n=5+5)
mimic_png_decode_image_40k_24bpp 54.6MB/s ± 0% 53.9MB/s ± 0% -1.25% (p=0.008 n=5+5)
mimic_png_decode_image_77k_8bpp 125MB/s ± 0% 124MB/s ± 0% -0.73% (p=0.008 n=5+5)
mimic_png_decode_image_552k_32bpp_ignore_checksum skipped
mimic_png_decode_image_552k_32bpp_verify_checksum 102MB/s ± 0% 101MB/s ± 0% -0.95% (p=0.008 n=5+5)
mimic_png_decode_image_4002k_24bpp 81.3MB/s ± 0% 81.0MB/s ± 0% -0.46% (p=0.016 n=4+5)
|
2021-02-13 22:54:47 +11:00 |
|
Nigel Tao
|
78c7087eee
|
Implement io_limit
|
2020-12-24 14:01:48 +11:00 |
|
Nigel Tao
|
332fb46b5c
|
Remove std/nie decoder.swizzle derived var hack
|
2020-12-23 15:34:42 +11:00 |
|
Nigel Tao
|
f6d11c78da
|
Add ast.Expr IsArgsDotFoo and IsMethodCall methods
|
2020-12-23 15:13:14 +11:00 |
|
Nigel Tao
|
42d569f5db
|
Refactor cgen's write{Load,Save}DerivedVar
|
2020-11-13 22:42:41 +11:00 |
|
Nigel Tao
|
b2dc84105a
|
Clean up more wuffs-c output (before clang-format)
|
2020-06-04 23:26:15 +10:00 |
|
Nigel Tao
|
055e944584
|
Make cgen io_reader pointers' elements const
|
2020-05-27 14:28:31 +10:00 |
|
Nigel Tao
|
2f2ccdb696
|
Add token_writer.write_token
|
2020-02-11 13:31:13 +11:00 |
|
Nigel Tao
|
737e31ff3a
|
Add tokens
|
2020-02-11 12:02:58 +11:00 |
|
Nigel Tao
|
fb54ba452f
|
Add wuffs_base__make_status
|
2020-01-02 20:44:23 +11:00 |
|
Nigel Tao
|
74614a2921
|
Fix calls to the deprecated null_io_buffer
|
2019-09-14 12:06:27 +10:00 |
|
Nigel Tao
|
a36bf4be4c
|
Tweak the order of generated C's u_r and v_r vars
|
2019-07-07 17:43:57 +10:00 |
|
Nigel Tao
|
daeec2bc1e
|
Have io_{reader,writer}.mark use io0_etc
|
2019-07-07 16:55:25 +10:00 |
|
Nigel Tao
|
00134fe7f5
|
Shuffle initialization of io1_etc and io2_etc
|
2019-07-06 22:01:34 +10:00 |
|
Nigel Tao
|
a842746807
|
Add generated C's io0_etc pointers
|
2019-07-06 21:55:37 +10:00 |
|
Nigel Tao
|
e08a4dfa3b
|
Rename some cgen internal variables
|
2019-07-06 21:50:29 +10:00 |
|
Nigel Tao
|
cc9fb5224a
|
Rename the generated C's io0_etc to io1_etc
|
2019-07-06 21:45:55 +10:00 |
|
Nigel Tao
|
7c6a88882e
|
Rename the generated C's io1_etc to io2_etc
|
2019-07-06 21:42:53 +10:00 |
|
Nigel Tao
|
f34d189236
|
Collapse trivial io_{reader,writer} buffer field
|
2019-07-06 16:47:47 +10:00 |
|
Nigel Tao
|
9e34b2bd2f
|
Remove checks for obsolete limit/mark I/O fields
name old speed new speed delta
wuffs_deflate_decode_1k_full_init/clang5 137MB/s ± 0% 146MB/s ± 0% +6.53% (p=0.000 n=10+9)
wuffs_deflate_decode_1k_part_init/clang5 165MB/s ± 0% 180MB/s ± 0% +9.03% (p=0.000 n=10+10)
wuffs_deflate_decode_10k_full_init/clang5 226MB/s ± 0% 229MB/s ± 0% +1.52% (p=0.000 n=9+9)
wuffs_deflate_decode_10k_part_init/clang5 232MB/s ± 1% 236MB/s ± 1% +1.86% (p=0.000 n=9+10)
wuffs_deflate_decode_100k_just_one_read/clang5 265MB/s ± 0% 266MB/s ± 0% +0.27% (p=0.008 n=10+9)
wuffs_deflate_decode_100k_many_big_reads/clang5 223MB/s ± 0% 224MB/s ± 0% +0.84% (p=0.000 n=9+10)
wuffs_deflate_decode_1k_full_init/gcc7 151MB/s ± 0% 151MB/s ± 2% ~ (p=1.000 n=8+10)
wuffs_deflate_decode_1k_part_init/gcc7 186MB/s ± 0% 187MB/s ± 1% +0.52% (p=0.003 n=8+10)
wuffs_deflate_decode_10k_full_init/gcc7 253MB/s ± 1% 261MB/s ± 1% +3.10% (p=0.000 n=9+10)
wuffs_deflate_decode_10k_part_init/gcc7 261MB/s ± 0% 269MB/s ± 0% +3.02% (p=0.000 n=9+10)
wuffs_deflate_decode_100k_just_one_read/gcc7 312MB/s ± 0% 314MB/s ± 0% +0.66% (p=0.000 n=9+10)
wuffs_deflate_decode_100k_many_big_reads/gcc7 251MB/s ± 0% 249MB/s ± 0% -0.59% (p=0.000 n=9+10)
|
2019-07-06 11:56:49 +10:00 |
|
Nigel Tao
|
3c86337cac
|
Fix some more -Wconversion warnings
|
2019-04-07 16:04:30 +10:00 |
|
Nigel Tao
|
5a98f06cab
|
Add some make_foo and null_foo constructors
|
2019-03-09 14:50:32 +11:00 |
|
Nigel Tao
|
6826f2f748
|
Move internal/cgen up a couple of directories
|
2019-03-09 13:28:59 +11:00 |
|