Commit Graph
326 Commits
Author SHA1 Message Date
Nigel Tao 5badfef313 Remove unused base.io_writer arg 2018-05-29 08:41:42 +10:00
Nigel Tao c5362d6413 Remove the write_to_ib_instead_of_w hack 2018-05-29 08:26:27 +10:00
Nigel Tao c723329263 Delete image_buffer linearization optimization
It helps at small image sizes, but it doesn't help at all for larger
images. The extra code is probably not worth it. Numbers below, old is
with the optimization, new is without.

name                             old speed      new speed      delta

wuffs_gif_decode_1k_bw/clang      307MB/s ± 2%   286MB/s ± 0%  -6.84%  (p=0.000 n=48+42)
wuffs_gif_decode_1k_color/clang   137MB/s ± 1%   134MB/s ± 0%  -2.36%  (p=0.000 n=46+44)
wuffs_gif_decode_10k/clang        125MB/s ± 2%   125MB/s ± 0%    ~     (p=0.617 n=46+45)
wuffs_gif_decode_100k/clang       119MB/s ± 1%   119MB/s ± 0%    ~     (p=0.827 n=47+43)
wuffs_gif_decode_1000k/clang      121MB/s ± 1%   121MB/s ± 1%  +0.31%  (p=0.022 n=49+46)

wuffs_gif_decode_1k_bw/gcc        320MB/s ± 1%   304MB/s ± 1%  -4.77%  (p=0.000 n=48+46)
wuffs_gif_decode_1k_color/gcc     156MB/s ± 1%   153MB/s ± 1%  -2.08%  (p=0.000 n=46+49)
wuffs_gif_decode_10k/gcc          141MB/s ± 1%   141MB/s ± 0%  -0.06%  (p=0.012 n=44+46)
wuffs_gif_decode_100k/gcc         126MB/s ± 1%   127MB/s ± 0%  +0.76%  (p=0.000 n=45+42)
wuffs_gif_decode_1000k/gcc        129MB/s ± 1%   130MB/s ± 1%  +0.89%  (p=0.000 n=46+44)
2018-05-29 08:15:19 +10:00
Nigel Tao 3c3e6fc2fa Decode std/gif to an image_buffer, not io_buffer
This is about correctness, not performance, as an image_buffer supports
decoding to a frame_rect whose top-left corner isn't (0, 0). For the
record, though:

name                             old speed      new speed      delta

wuffs_gif_decode_1k_bw/clang      318MB/s ± 1%   307MB/s ± 2%  -3.37%  (p=0.000 n=48+48)
wuffs_gif_decode_1k_color/clang   140MB/s ± 0%   137MB/s ± 1%  -2.18%  (p=0.000 n=46+46)
wuffs_gif_decode_10k/clang        128MB/s ± 0%   125MB/s ± 2%  -1.95%  (p=0.000 n=39+46)
wuffs_gif_decode_100k/clang       120MB/s ± 0%   119MB/s ± 1%  -1.36%  (p=0.000 n=45+47)
wuffs_gif_decode_1000k/clang      122MB/s ± 0%   121MB/s ± 1%  -1.35%  (p=0.000 n=44+49)

wuffs_gif_decode_1k_bw/gcc        329MB/s ± 2%   320MB/s ± 1%  -2.97%  (p=0.000 n=48+48)
wuffs_gif_decode_1k_color/gcc     160MB/s ± 1%   156MB/s ± 1%  -2.50%  (p=0.000 n=44+46)
wuffs_gif_decode_10k/gcc          144MB/s ± 1%   141MB/s ± 1%  -2.30%  (p=0.000 n=45+44)
wuffs_gif_decode_100k/gcc         128MB/s ± 1%   126MB/s ± 1%  -1.43%  (p=0.000 n=46+45)
wuffs_gif_decode_1000k/gcc        131MB/s ± 1%   129MB/s ± 1%  -1.44%  (p=0.000 n=48+46)
2018-05-28 19:58:15 +10:00
Nigel Tao e1293c2522 Fix decoding GIFs to an image (not IO) buffer 2018-05-28 14:06:58 +10:00
Nigel Tao 3df370e82c Fill more of std/gif's copy_to_image_buffer 2018-05-28 09:20:43 +10:00
Nigel Tao 11a8ebf1ee Add commentary about std/gif's decode_id parts 2018-05-27 19:31:19 +10:00
Nigel Tao ac8ac17c65 Fill in std/gif's decoder.copy_to_image_buffer 2018-05-27 19:29:10 +10:00
Nigel Tao 00203e564f Let ? methods return OK even without suspending 2018-05-27 19:09:58 +10:00
Nigel Tao 865275db75 Make std/gif's copy_to_image_buffer a ? method 2018-05-27 18:53:32 +10:00
Nigel Tao f43afd8236 Add a (table T).row method 2018-05-26 11:32:54 +10:00
Nigel Tao 79d3fd64e6 Set GIF implicit palette entries to transparent 2018-05-25 17:17:57 +10:00
Nigel Tao ae0de1d35a Factor out a std/gif copy_to_image_buffer func 2018-05-25 17:07:16 +10:00
Nigel Tao 1948d1d0b6 Decode the std/gif graphic control extension 2018-05-24 17:48:00 +10:00
Nigel Tao 4466267063 Make image_buffer__update's dirty_palette implicit 2018-05-24 13:09:02 +10:00
Nigel Tao 414d6e1f48 Fix std/gif setting the dirty_palette bit 2018-05-24 12:10:17 +10:00
Nigel Tao 30e48093fc Bounds check the components of a s[i:j] expr 2018-05-24 11:44:16 +10:00
Nigel Tao 5e856540bd Have std/gif update an image_buffer's dirty_rect 2018-05-24 11:29:16 +10:00
Nigel Tao 34cfc3f863 Have std/gif's palettes be BGRA, not RGB 2018-05-24 10:33:02 +10:00
Nigel Tao 9d524be60d Add write_to_ib_instead_of_w transition support 2018-05-24 09:54:26 +10:00
Nigel Tao a66f8201cf Remove an obsolete TODO 2018-05-23 16:01:53 +10:00
Nigel Tao 66bcaf380d Handle GIF frame out of bounds same as Chromium 2018-05-23 15:59:41 +10:00
Nigel Tao aa4029d29d Factor std/gif's decode_id into two parts 2018-05-23 12:41:47 +10:00
Nigel Tao 0aeb589033 Add some base.rect_ie_u32 methods 2018-05-18 22:08:44 +10:00
Nigel Tao 4a1b349cb8 Add a base.rect_ie_u32 type 2018-05-18 20:22:56 +10:00
Nigel Tao 85256c7a45 Add a (table T).linearize method 2018-05-18 13:54:07 +10:00
Nigel Tao e4320c3c6d Add built-in table T methods 2018-05-18 12:50:53 +10:00
Nigel Tao 2301c763c3 Add a base.image_buffer arg to decode_frame 2018-05-18 09:42:24 +10:00
Nigel Tao e0478b1d91 Guard against the LZW literal_width changing 2018-05-13 15:55:24 +10:00
Nigel Tao f10ff8c896 Have std/gif pass through an intermediary 2018-05-13 15:50:51 +10:00
Nigel Tao ed1a8b4057 Update std/gif's pass-through uncompressed_wi 2018-05-13 13:09:58 +10:00
Nigel Tao 043ba870f5 Prepare std/gif to pass through an intermediary 2018-05-13 12:24:58 +10:00
Nigel Tao 0d54356b5c Add an io_writer.set method 2018-05-13 11:42:28 +10:00
Nigel Tao 2d3b3b1dae Add an io_writer var to gif's decoder.decode_id 2018-05-13 10:40:44 +10:00
Nigel Tao 0f32650064 Move some std/gif code inside its io_bind 2018-05-12 21:55:19 +10:00
Nigel Tao 2df6ea4b7a Add a gif.decoder buffer for uncompressed data 2018-05-12 21:50:27 +10:00
Nigel Tao dfc8e14f4f Fix some hasher methods' effects 2018-05-12 18:01:24 +10:00
Nigel Tao 131732e7eb Fix some built-in methods' effects 2018-05-12 17:55:57 +10:00
Nigel Tao a8767f285b Simplify deflate's decoder.decode_uncompressed 2018-05-12 15:51:00 +10:00
Nigel Tao 84724a76a2 Add comment about set_limit subtleties 2018-05-12 15:49:19 +10:00
Nigel Tao daecfc08b1 Add comment about decoding malformed GIFs 2018-05-12 14:41:32 +10:00
Nigel Tao bd12c54ab5 Rename mark to set_mark, part 1 of N 2018-05-12 14:17:26 +10:00
Nigel Tao b65fdee306 Make the else-length-1 iterate tail explicit 2018-05-11 10:22:24 +10:00
Nigel Tao 8586cf8e3d Reset the GIF's LZW decoder if necessary 2018-05-10 14:42:10 +10:00
Nigel Tao 614ac408ae Note if GIF's previous LZW decode ended abruptly 2018-05-10 14:09:39 +10:00
Nigel Tao 282b9c4b20 Place iterate params after vars, not before 2018-05-10 09:38:14 +10:00
Nigel Tao 79aded4797 Introduce a =: operator 2018-05-10 09:31:58 +10:00
Nigel Tao 1702c1e303 Rename iterate's step to length 2018-05-05 08:25:23 +10:00
Nigel Tao 58cd282138 Unroll the std/crc32 loop
name                          old speed      new speed      delta
wuffs_crc32_ieee_10k/clang    2.30GB/s ± 1%  2.37GB/s ± 0%  +3.31%  (p=0.016 n=5+4)
wuffs_crc32_ieee_100k/clang   2.30GB/s ± 0%  2.35GB/s ± 0%  +2.39%  (p=0.008 n=5+5)
wuffs_crc32_ieee_10k/gcc      2.49GB/s ± 1%  2.72GB/s ± 0%  +9.19%  (p=0.008 n=5+5)
wuffs_crc32_ieee_100k/gcc     2.50GB/s ± 0%  2.70GB/s ± 1%  +8.18%  (p=0.008 n=5+5)
wuffs_gzip_decode_10k/clang    206MB/s ± 2%   207MB/s ± 0%    ~     (p=1.000 n=5+5)
wuffs_gzip_decode_100k/clang   231MB/s ± 2%   235MB/s ± 0%  +1.57%  (p=0.008 n=5+5)
wuffs_gzip_decode_10k/gcc      234MB/s ± 0%   235MB/s ± 1%    ~     (p=0.095 n=5+5)
wuffs_gzip_decode_100k/gcc     267MB/s ± 0%   266MB/s ± 2%    ~     (p=0.690 n=5+5)
2018-05-04 14:00:04 +10:00
Nigel Tao 81edda0413 Remove an obsolete TODO 2018-05-04 13:31:48 +10:00