Commit Graph
271 Commits
Author SHA1 Message Date
Nigel Tao bbc3d34e1b Check distance > 0 for decode_huffman_slow
decode_huffman_fast already does this. The slow flavor should too.

Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6524
2018-02-24 11:31:12 +11:00
Nigel Tao 5a927d6905 Roll back 'unconditionally resume local vars'
See the previous commit for the rationale.
2018-02-22 11:23:58 +11:00
Nigel Tao 2b6b0acb4f Unconditionally resume local vars
This commit will immediately be followed by a rollback, but it is
committed anyway so that we can refer to these numbers in the git log.

name                             old speed      new speed      delta
wuffs_deflate_decode_1k/clang     145MB/s ± 1%   141MB/s ± 1%   -2.28%  (p=0.000 n=19+19)
wuffs_deflate_decode_10k/clang    222MB/s ± 0%   202MB/s ± 1%   -9.39%  (p=0.000 n=16+18)
wuffs_deflate_decode_100k/clang   256MB/s ± 0%   237MB/s ± 1%   -7.64%  (p=0.000 n=20+20)
wuffs_deflate_decode_1k/gcc       157MB/s ± 2%   158MB/s ± 1%   +0.73%  (p=0.001 n=20+19)
wuffs_deflate_decode_10k/gcc      247MB/s ± 1%   251MB/s ± 0%   +1.72%  (p=0.000 n=19+18)
wuffs_deflate_decode_100k/gcc     289MB/s ± 0%   286MB/s ± 0%   -0.86%  (p=0.000 n=17+18)
wuffs_lzw_decode_20k/clang        121MB/s ± 1%   122MB/s ± 1%   +1.04%  (p=0.000 n=17+19)
wuffs_lzw_decode_100k/clang       163MB/s ± 1%   164MB/s ± 1%   +0.33%  (p=0.010 n=19+18)
wuffs_gif_decode_1k/clang         348MB/s ± 1%   361MB/s ± 2%   +3.62%  (p=0.000 n=20+20)
wuffs_gif_decode_10k/clang        132MB/s ± 1%   130MB/s ± 1%   -1.49%  (p=0.000 n=20+19)
wuffs_gif_decode_100k/clang       114MB/s ± 0%   116MB/s ± 1%   +1.24%  (p=0.000 n=19+20)
wuffs_gif_decode_1000k/clang      117MB/s ± 0%   118MB/s ± 1%   +1.16%  (p=0.000 n=17+20)
wuffs_lzw_decode_20k/gcc          153MB/s ± 1%   162MB/s ± 1%   +6.05%  (p=0.000 n=18+19)
wuffs_lzw_decode_100k/gcc         216MB/s ± 1%   228MB/s ± 0%   +5.29%  (p=0.000 n=20+19)
wuffs_gif_decode_1k/gcc           444MB/s ± 1%   388MB/s ± 1%  -12.62%  (p=0.000 n=19+18)
wuffs_gif_decode_10k/gcc          148MB/s ± 0%   126MB/s ± 0%  -14.50%  (p=0.000 n=19+19)
wuffs_gif_decode_100k/gcc         137MB/s ± 0%   114MB/s ± 1%  -16.69%  (p=0.000 n=19+18)
wuffs_gif_decode_1000k/gcc        139MB/s ± 1%   117MB/s ± 0%  -16.02%  (p=0.000 n=20+17)
wuffs_adler32_10k/clang          2.44GB/s ± 0%  2.44GB/s ± 1%     ~     (p=0.258 n=18+17)
wuffs_adler32_100k/clang         2.45GB/s ± 0%  2.44GB/s ± 0%   -0.11%  (p=0.005 n=17+16)
wuffs_zlib_decode_10k/clang       204MB/s ± 0%   188MB/s ± 0%   -7.82%  (p=0.000 n=17+18)
wuffs_zlib_decode_100k/clang      232MB/s ± 0%   218MB/s ± 0%   -5.90%  (p=0.000 n=19+17)
wuffs_adler32_10k/gcc            3.22GB/s ± 1%  3.25GB/s ± 0%   +1.01%  (p=0.000 n=19+20)
wuffs_adler32_100k/gcc           3.22GB/s ± 0%  3.25GB/s ± 0%   +0.95%  (p=0.000 n=16+18)
wuffs_zlib_decode_10k/gcc         229MB/s ± 1%   233MB/s ± 0%   +1.71%  (p=0.000 n=18+19)
wuffs_zlib_decode_100k/gcc        262MB/s ± 0%   265MB/s ± 0%   +1.04%  (p=0.000 n=17+18)
2018-02-22 11:18:16 +11:00
Nigel Tao 0ad23714c6 Fix read_uxxbe across an I/O short read
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6473
2018-02-21 16:14:19 +11:00
Nigel Tao 11ad47af86 Zero-initialize bool-typed coro local variables
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6470
2018-02-21 16:00:25 +11:00
Nigel Tao 446d4662db Let the zlib decoder ignore the checksum 2018-02-16 08:51:28 +11:00
Nigel Tao fdceee4bd0 Denote intentional fallthroughs 2018-02-15 20:36:20 +11:00
Nigel Tao 98ccfedc96 Avoid "goto exit" bypassing variable init'n 2018-02-15 16:18:50 +11:00
Nigel Tao f82c33db2f Recognize a GIF "ANIMEXTS1.0" extension 2018-02-15 14:35:01 +11:00
Nigel Tao fb2430e765 Add some GIF per-frame fields 2018-02-15 12:41:13 +11:00
Nigel Tao 0d33d3ef3a Decode a GIF local color table 2018-02-11 15:30:18 +11:00
Nigel Tao 584fc631a8 Decode a GIF's loop count 2018-02-10 17:14:49 +11:00
Nigel Tao d3770b9972 Add an end of data concept 2018-02-10 12:13:26 +11:00
Nigel Tao 7e90967717 Fill in a GIF image_config 2018-02-09 16:05:04 +11:00
Nigel Tao d750ea7653 Add an image_config concept 2018-02-09 14:46:37 +11:00
Nigel Tao de9000cc70 Add a call sequence concept 2018-02-08 09:06:19 +11:00
Nigel Tao f5c6204f09 Strip the prefix from base status messages 2017-12-27 14:45:54 +11:00
Nigel Tao 7e47f4cc7a Delegate etc__status__string to used packages 2017-12-27 13:49:05 +11:00
Nigel Tao fecd7b631c Re-organize some status codes 2017-12-27 13:15:37 +11:00
Nigel Tao d14b56ea39 Type check built-in functions more thoroughly 2017-12-16 13:25:26 +11:00
Nigel Tao 2e12a41414 Make std/gif's LZW decoder private 2017-12-08 16:18:35 +11:00
Nigel Tao 8e2255916e Drop the "flate_" in "deflate.flate_decoder" 2017-12-04 10:35:08 +11:00
Nigel Tao 2755a61ae9 Rename std/deflate's packageid 2017-12-04 10:29:17 +11:00
Nigel Tao 1388f84e5c Rename std/flate to std/deflate 2017-12-04 10:27:48 +11:00
Nigel Tao 530605a16b Delete std/flate's zlib code (moved to std/zlib) 2017-12-03 14:31:35 +11:00
Nigel Tao 7e73a5ac5f Call initializers for out-of-pkg struct fields 2017-12-03 14:22:49 +11:00
Nigel Tao 6913a1ff00 Copy/paste zlib code from std/flate to std/zlib 2017-12-03 13:32:42 +11:00
Nigel Tao 0a32c01014 Allow referring to types from used packages 2017-12-03 13:21:23 +11:00
Nigel Tao 9867cd5e3a Generate inline headers for use declarations 2017-12-02 14:54:58 +11:00
Nigel Tao c5b5efd7c8 Prepare for generating use declarations 2017-12-02 14:17:24 +11:00
Nigel Tao dd3f0b9ed4 Add a placeholder std/zlib package 2017-12-02 11:21:30 +11:00
Nigel Tao 849db0faa2 Make C hex constants' capitalization consistent 2017-12-01 15:35:41 +11:00
Nigel Tao 65dcf6a5b9 Add a yield keyword 2017-12-01 15:24:48 +11:00
Nigel Tao 7fd51d44a2 Rename PUFFS to WUFFS, part 8 of N 2017-11-30 18:05:19 +11:00
Nigel Tao 3c708dfe59 Rename PUFFS to WUFFS, part 7 of N 2017-11-30 18:02:59 +11:00
Nigel Tao eda3130628 Rename PUFFS to WUFFS, part 6 of N 2017-11-30 16:43:39 +11:00
Nigel Tao 9b4cc179c4 Use puffs_base__writer1__copy_from_history32__bco.
name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.45GB/s ± 0%  2.45GB/s ± 0%    ~     (p=0.063 n=5+5)
puffs_adler32_100k/clang       2.45GB/s ± 0%  2.45GB/s ± 0%    ~     (p=0.905 n=5+4)
puffs_flate_decode_1k/clang     144MB/s ± 1%   146MB/s ± 0%  +1.41%  (p=0.016 n=5+5)
puffs_flate_decode_10k/clang    186MB/s ± 0%   204MB/s ± 0%  +9.39%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   228MB/s ± 0%   240MB/s ± 0%  +5.24%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang     173MB/s ± 0%   188MB/s ± 0%  +8.69%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    209MB/s ± 0%   219MB/s ± 0%  +4.81%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.26GB/s ± 0%  3.26GB/s ± 0%    ~     (p=0.286 n=5+4)
puffs_adler32_100k/gcc         3.26GB/s ± 0%  3.26GB/s ± 0%    ~     (p=0.190 n=5+4)
puffs_flate_decode_1k/gcc       148MB/s ± 0%   148MB/s ± 0%  +0.27%  (p=0.016 n=5+4)
puffs_flate_decode_10k/gcc      245MB/s ± 0%   254MB/s ± 0%  +3.73%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     284MB/s ± 0%   298MB/s ± 0%  +4.90%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc       228MB/s ± 0%   236MB/s ± 0%  +3.33%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      261MB/s ± 0%   273MB/s ± 0%  +4.46%  (p=0.016 n=5+4)
2017-11-09 15:08:28 +11:00
Nigel Tao 744b5fcc31 Add puffs_base__writer1__copy_from_history32__bco. 2017-11-09 14:02:10 +11:00
Nigel Tao 82e5734778 Fix puffs_base__writer1__copy_from_history32. 2017-11-09 13:35:45 +11:00
Nigel Tao 03acc15782 Add some more length and distance checks. 2017-11-09 13:21:19 +11:00
Nigel Tao 30b54616a8 Check copy_from_history32's distance. 2017-11-09 12:53:19 +11:00
Nigel Tao 3bdd515e47 Allow "assert foo", not just "assert foo < bar". 2017-11-09 10:53:37 +11:00
Nigel Tao e2ce9f1b1d Add a writer1.is_marked method. 2017-11-09 10:38:24 +11:00
Nigel Tao 545f043d94 Don't read extra bits if there's no extra bits.
name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.45GB/s ± 0%  2.45GB/s ± 0%    ~     (p=0.548 n=5+5)
puffs_adler32_100k/clang       2.45GB/s ± 0%  2.45GB/s ± 0%    ~     (p=0.056 n=5+5)
puffs_flate_decode_1k/clang     142MB/s ± 0%   143MB/s ± 0%  +0.63%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang    190MB/s ± 0%   201MB/s ± 0%  +5.54%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   225MB/s ± 0%   235MB/s ± 0%  +4.27%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang     176MB/s ± 0%   186MB/s ± 0%  +5.16%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    207MB/s ± 1%   214MB/s ± 0%  +3.56%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.21GB/s ± 1%  3.26GB/s ± 0%  +1.55%  (p=0.008 n=5+5)
puffs_adler32_100k/gcc         3.21GB/s ± 2%  3.27GB/s ± 0%  +1.66%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc       139MB/s ± 1%   146MB/s ± 0%  +5.09%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      232MB/s ± 0%   244MB/s ± 0%  +5.42%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     257MB/s ± 1%   280MB/s ± 0%  +9.10%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc       215MB/s ± 1%   227MB/s ± 0%  +5.82%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      235MB/s ± 1%   257MB/s ± 0%  +9.67%  (p=0.008 n=5+5)
2017-11-08 17:19:58 +11:00
Nigel Tao 989614df88 Remove some redundant decode_huffman_xxx code.
name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.40GB/s ± 1%  2.45GB/s ± 0%  +2.08%  (p=0.008 n=5+5)
puffs_adler32_100k/clang       2.41GB/s ± 1%  2.45GB/s ± 0%  +1.54%  (p=0.008 n=5+5)
puffs_flate_decode_1k/clang     140MB/s ± 0%   142MB/s ± 0%  +1.64%  (p=0.016 n=4+5)
puffs_flate_decode_10k/clang    186MB/s ± 1%   190MB/s ± 0%  +2.32%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   209MB/s ± 1%   225MB/s ± 0%  +7.60%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang     173MB/s ± 1%   176MB/s ± 0%  +2.04%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    193MB/s ± 0%   207MB/s ± 1%  +7.43%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.26GB/s ± 0%  3.21GB/s ± 1%  -1.48%  (p=0.008 n=5+5)
puffs_adler32_100k/gcc         3.25GB/s ± 0%  3.21GB/s ± 2%  -1.24%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc       142MB/s ± 0%   139MB/s ± 1%  -2.27%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      232MB/s ± 1%   232MB/s ± 0%    ~     (p=0.548 n=5+5)
puffs_flate_decode_100k/gcc     259MB/s ± 2%   257MB/s ± 1%    ~     (p=0.151 n=5+5)
puffs_zlib_decode_10k/gcc       216MB/s ± 2%   215MB/s ± 1%    ~     (p=0.222 n=5+5)
puffs_zlib_decode_100k/gcc      241MB/s ± 1%   235MB/s ± 1%  -2.50%  (p=0.008 n=5+5)
2017-11-08 17:08:36 +11:00
Nigel Tao 39952faca1 Tweak the copy_from_history32 unroll count.
name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.42GB/s ± 1%  2.43GB/s ± 1%     ~     (p=0.720 n=10+9)
puffs_adler32_100k/clang       2.43GB/s ± 0%  2.42GB/s ± 1%   -0.41%  (p=0.004 n=8+10)
puffs_flate_decode_1k/clang     138MB/s ± 1%   139MB/s ± 1%   +1.20%  (p=0.000 n=10+10)
puffs_flate_decode_10k/clang    189MB/s ± 1%   187MB/s ± 1%   -1.27%  (p=0.000 n=9+9)
puffs_flate_decode_100k/clang   211MB/s ± 1%   210MB/s ± 1%   -0.72%  (p=0.001 n=10+9)
puffs_zlib_decode_10k/clang     175MB/s ± 1%   173MB/s ± 1%   -1.23%  (p=0.000 n=10+10)
puffs_zlib_decode_100k/clang    194MB/s ± 1%   193MB/s ± 0%   -0.50%  (p=0.018 n=10+9)

puffs_adler32_10k/gcc          3.26GB/s ± 0%  3.22GB/s ± 1%   -1.00%  (p=0.000 n=9+10)
puffs_adler32_100k/gcc         3.27GB/s ± 0%  3.23GB/s ± 1%   -1.05%  (p=0.000 n=8+9)
puffs_flate_decode_1k/gcc       139MB/s ± 0%   141MB/s ± 1%   +1.27%  (p=0.000 n=9+10)
puffs_flate_decode_10k/gcc      203MB/s ± 0%   231MB/s ± 0%  +13.87%  (p=0.000 n=10+9)
puffs_flate_decode_100k/gcc     229MB/s ± 0%   258MB/s ± 0%  +12.63%  (p=0.000 n=9+9)
puffs_zlib_decode_10k/gcc       201MB/s ± 0%   215MB/s ± 1%   +6.86%  (p=0.000 n=10+9)
puffs_zlib_decode_100k/gcc      224MB/s ± 0%   239MB/s ± 0%   +6.89%  (p=0.000 n=9+9)
2017-11-08 11:40:09 +11:00
Nigel Tao 848d66ffdf Tighten the Huffman n_bits invariant. 2017-11-07 09:30:16 +11:00
Nigel Tao 30ce73ad26 Remove some superfluous braces. 2017-11-06 17:01:34 +11:00
Nigel Tao 0bc6f792fb Remove some suspensions from decode_huffman_fast.
name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.41GB/s ± 1%  2.39GB/s ± 2%  -0.88%  (p=0.022 n=9+10)
puffs_adler32_100k/clang       2.41GB/s ± 1%  2.39GB/s ± 2%    ~     (p=0.095 n=10+9)
puffs_flate_decode_1k/clang     136MB/s ± 2%   134MB/s ± 1%  -0.86%  (p=0.036 n=9+8)
puffs_flate_decode_10k/clang    172MB/s ± 0%   175MB/s ± 0%  +1.96%  (p=0.000 n=8+9)
puffs_flate_decode_100k/clang   206MB/s ± 0%   209MB/s ± 1%  +1.38%  (p=0.000 n=8+9)
puffs_zlib_decode_10k/clang     160MB/s ± 1%   163MB/s ± 2%  +1.73%  (p=0.001 n=9+9)
puffs_zlib_decode_100k/clang    189MB/s ± 1%   188MB/s ± 6%    ~     (p=0.143 n=10+10)

puffs_adler32_10k/gcc          3.27GB/s ± 0%  3.20GB/s ± 2%  -2.03%  (p=0.000 n=8+10)
puffs_adler32_100k/gcc         3.27GB/s ± 0%  3.21GB/s ± 1%  -1.89%  (p=0.000 n=8+10)
puffs_flate_decode_1k/gcc       141MB/s ± 1%   139MB/s ± 1%  -1.66%  (p=0.000 n=9+10)
puffs_flate_decode_10k/gcc      200MB/s ± 0%   209MB/s ± 1%  +4.73%  (p=0.000 n=10+10)
puffs_flate_decode_100k/gcc     242MB/s ± 0%   237MB/s ± 0%  -2.19%  (p=0.000 n=9+10)
puffs_zlib_decode_10k/gcc       188MB/s ± 0%   195MB/s ± 1%  +3.71%  (p=0.000 n=10+10)
puffs_zlib_decode_100k/gcc      225MB/s ± 0%   221MB/s ± 0%  -1.84%  (p=0.000 n=8+9)
2017-11-06 16:59:27 +11:00
Nigel Tao 058938006a Remove some suspensions from decode_huffman_fast.
name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.45GB/s ± 0%  2.41GB/s ± 1%  -1.82%  (p=0.000 n=9+9)
puffs_adler32_100k/clang       2.45GB/s ± 0%  2.41GB/s ± 1%  -1.74%  (p=0.000 n=9+10)
puffs_flate_decode_1k/clang     133MB/s ± 0%   136MB/s ± 2%  +1.93%  (p=0.003 n=9+9)
puffs_flate_decode_10k/clang    181MB/s ± 0%   172MB/s ± 0%  -5.18%  (p=0.000 n=9+8)
puffs_flate_decode_100k/clang   204MB/s ± 0%   206MB/s ± 0%  +0.63%  (p=0.000 n=10+8)
puffs_zlib_decode_10k/clang     168MB/s ± 0%   160MB/s ± 1%  -4.82%  (p=0.000 n=10+9)
puffs_zlib_decode_100k/clang    189MB/s ± 0%   189MB/s ± 1%    ~     (p=0.143 n=10+10)

puffs_adler32_10k/gcc          3.26GB/s ± 0%  3.27GB/s ± 0%  +0.12%  (p=0.000 n=10+8)
puffs_adler32_100k/gcc         3.27GB/s ± 0%  3.27GB/s ± 0%  +0.18%  (p=0.000 n=10+8)
puffs_flate_decode_1k/gcc       130MB/s ± 0%   141MB/s ± 1%  +8.71%  (p=0.000 n=10+9)
puffs_flate_decode_10k/gcc      203MB/s ± 0%   200MB/s ± 0%  -1.72%  (p=0.000 n=9+10)
puffs_flate_decode_100k/gcc     241MB/s ± 0%   242MB/s ± 0%  +0.54%  (p=0.000 n=8+9)
puffs_zlib_decode_10k/gcc       188MB/s ± 0%   188MB/s ± 0%  +0.26%  (p=0.000 n=9+10)
puffs_zlib_decode_100k/gcc      223MB/s ± 0%   225MB/s ± 0%  +0.93%  (p=0.000 n=9+8)
2017-11-06 15:25:19 +11:00