sarastro-nl
d46220ca00
optimize SDC
2022-11-21 22:10:19 +01:00
Nigel Tao
dee65c0e61
wuffs gen -version=0.3.0-rc.3
2022-10-28 17:29:05 +11:00
Nigel Tao
9445c8b9d0
Guard header declarations on the MODULE_ETC macros
2022-10-28 17:11:14 +11:00
Nigel Tao
b5ccd9e8e7
wuffs gen -version=0.3.0-rc.2
2022-10-20 11:23:06 +11:00
Nigel Tao
b0e9efff3f
Avoid (NULL + 0) in derived io_buffer variables
...
This addresses a "runtime error: applying zero offset to null pointer"
UBSAN (Undefined Behavior Sanitizer) warning using clang 15.0.1:
https://logs.chromium.org/logs/skia/5e005cc1b1981011/+/steps/dm/0/stdout
The offending line of code was "io1_a_dst = io0_a_dst + a_dst->meta.wi"
in wuffs_lzw__decoder__write_to and "io1_a_dst = NULL + 0" was Undefined
Behavior even though io1_a_dst was never dereferenced.
This commit avoids initializing io1_a_dst to (NULL + 0) when io0_a_dst
is NULL, falling back to initializing it with just NULL.
As discussed in https://reviews.llvm.org/D67122 while (nullptr + 0) is
Defined Behavior according to the C++ spec, (NULL + 0) is Undefined
Behavior (by omission) in C11 6.5.6/8: "If both the pointer operand and
the result point to elements of the same array object, or one past the
last element of the array object, the evaluation shall not produce an
overflow; otherwise, the behavior is undefined."
The benchmarks (an excerpt of the full suite is below) seem quite
sensitive to this simple change that's outside of hot loops, sometimes
much better and sometimes much worse. I don't know why.
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 63.1MB/s ± 0% 58.4MB/s ± 0% -7.43% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 49.4MB/s ± 0% 46.2MB/s ± 0% -6.35% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 60.9MB/s ± 0% 56.3MB/s ± 0% -7.59% (p=0.016 n=5+4)
wuffs_bzip2_decode_100k/gcc10 49.6MB/s ± 0% 47.0MB/s ± 0% -5.15% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/clang11 196MB/s ± 0% 195MB/s ± 1% -0.63% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/clang11 226MB/s ± 0% 224MB/s ± 0% -0.95% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/clang11 409MB/s ± 0% 420MB/s ± 0% +2.84% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/clang11 418MB/s ± 0% 431MB/s ± 0% +2.97% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/clang11 517MB/s ± 1% 542MB/s ± 0% +4.78% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/clang11 330MB/s ± 0% 338MB/s ± 0% +2.45% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/gcc10 188MB/s ± 0% 177MB/s ± 0% -5.38% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/gcc10 218MB/s ± 0% 209MB/s ± 0% -4.11% (p=0.016 n=4+5)
wuffs_deflate_decode_10k_full_init/gcc10 402MB/s ± 0% 407MB/s ± 1% +1.19% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/gcc10 413MB/s ± 0% 419MB/s ± 1% +1.64% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/gcc10 520MB/s ± 0% 532MB/s ± 0% +2.25% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/gcc10 330MB/s ± 0% 335MB/s ± 0% +1.56% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/clang11 781MB/s ± 0% 645MB/s ± 0% -17.46% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/clang11 176MB/s ± 0% 181MB/s ± 0% +3.11% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/clang11 215MB/s ± 0% 223MB/s ± 0% +3.46% (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang11 786MB/s ± 0% 801MB/s ± 0% +1.94% (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang11 208MB/s ± 0% 211MB/s ± 0% +1.44% (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang11 261MB/s ± 0% 252MB/s ± 0% -3.43% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang11 578MB/s ± 0% 583MB/s ± 0% +0.86% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang11 224MB/s ± 0% 223MB/s ± 0% -0.79% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/clang11 229MB/s ± 0% 225MB/s ± 0% -1.73% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/clang11 229MB/s ± 0% 225MB/s ± 0% -1.69% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang11 1.31GB/s ± 0% 1.29GB/s ± 0% -1.06% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/gcc10 650MB/s ± 0% 631MB/s ± 0% -3.03% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/gcc10 169MB/s ± 0% 168MB/s ± 0% -0.51% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/gcc10 202MB/s ± 0% 202MB/s ± 0% -0.18% (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc10 766MB/s ± 0% 790MB/s ± 0% +3.08% (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc10 202MB/s ± 0% 208MB/s ± 0% +3.16% (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc10 250MB/s ± 0% 258MB/s ± 0% +3.20% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc10 563MB/s ± 0% 566MB/s ± 0% +0.57% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc10 217MB/s ± 0% 220MB/s ± 0% +1.49% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/gcc10 220MB/s ± 0% 224MB/s ± 0% +1.49% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/gcc10 220MB/s ± 0% 224MB/s ± 0% +1.43% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc10 1.30GB/s ± 0% 1.30GB/s ± 0% +0.34% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/clang11 293MB/s ± 0% 292MB/s ± 0% -0.41% (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang11 486MB/s ± 0% 537MB/s ± 0% +10.49% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/gcc10 258MB/s ± 0% 276MB/s ± 0% +7.19% (p=0.016 n=4+5)
wuffs_lzw_decode_100k/gcc10 512MB/s ± 0% 527MB/s ± 0% +3.08% (p=0.016 n=4+5)
2022-10-20 11:18:09 +11:00
Nigel Tao
315b2e5262
wuffs gen -version=0.3.0-rc.1
2022-07-10 10:30:15 +10:00
Nigel Tao
c226ed60f5
Use memcpy-based peeks and pokes on Microsoft C
...
I don't have a Windows machine readily available, but according to
https://godbolt.org/z/q4MfjzTPh and the https://imgur.com/UD5a7MF
profile mentioned in #72 , this could improve inner loop performance.
Updates #72
2022-06-12 17:18:49 +10:00
Nigel Tao
45a79923e6
Tighten std/bzip2 Huffman leaf node bit packing
2022-06-10 14:31:53 +10:00
Nigel Tao
67aa63297c
Rename std/bzip2 num_nodes variable
2022-06-10 14:06:27 +10:00
Nigel Tao
8c33dd503b
Tighten std/bzip2 huffman_trees array size
2022-06-10 14:02:17 +10:00
Nigel Tao
9256fe5e54
Have std/bzip2 check the number of sections
...
Updates #79
2022-06-08 16:41:46 +10:00
Nigel Tao
5392d503e3
wuffs gen -version=0.3.0-beta.15
2022-06-03 14:16:18 +10:00
Nigel Tao
ebe080c9ec
Fix gif metadata when skipping decode_image_config
2022-06-03 11:43:05 +10:00
Nigel Tao
65afe919b5
Fix std/gif "@end of data" for 0-frame GIFs
...
This fixes a regression introduced by 8d03a67e "Re-do image decoders'
call sequence state machine".
build-all.sh's script/print-nia-checksums.sh test once again matches
test/nia-checksums-of-data.txt:
-4c6d02c3 test/data/artificial-gif/no-frames.gif
+ba6e48f8 test/data/artificial-gif/no-frames.gif
2022-06-02 16:48:06 +10:00
Nigel Tao
c5e41f0e65
Let std/png report metadata after the first frame
...
Fixes #58
2022-06-02 16:05:24 +10:00
Nigel Tao
8d03a67e6e
Re-do image decoders' call sequence state machine
2022-05-28 15:06:56 +10:00
Nigel Tao
f55274aaa7
Fix -Werror=conversion in decode_bzip2.wuffs
2022-05-24 13:58:48 +10:00
Nigel Tao
e6793fc501
Have std/bzip2 support QUIRK_IGNORE_CHECKSUM
2022-05-24 12:31:43 +10:00
Nigel Tao
09102fb1e8
Tweak std/bzip2 decoder.flush_fast applicability
2022-05-24 12:25:47 +10:00
Nigel Tao
6a3e43f495
Tweak std/bzip2 flush_* basic blocks
...
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 65.2MB/s ± 0% 65.2MB/s ± 0% ~ (p=0.056 n=5+5)
wuffs_bzip2_decode_100k/clang11 52.4MB/s ± 0% 51.5MB/s ± 0% -1.67% (p=0.016 n=5+4)
wuffs_bzip2_decode_10k/gcc10 60.6MB/s ± 0% 61.7MB/s ± 0% +1.81% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10 49.2MB/s ± 0% 49.6MB/s ± 0% +0.86% (p=0.008 n=5+5)
2022-05-24 12:01:30 +10:00
Nigel Tao
bed155bd6f
Optimize std/bzip2 flush_repeat_count checks
...
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 60.5MB/s ± 0% 65.2MB/s ± 0% +7.85% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 45.7MB/s ± 1% 52.4MB/s ± 0% +14.68% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 58.5MB/s ± 0% 60.6MB/s ± 0% +3.67% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10 46.3MB/s ± 0% 49.2MB/s ± 0% +6.31% (p=0.008 n=5+5)
2022-05-24 11:56:23 +10:00
Nigel Tao
66f194f7e0
Introduce std/bzip2 decoder.flush_fast method
...
Compared to the recent commit 623290ef "Cache std/bzip2 Huffman tree
lookup":
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 60.5MB/s ± 0% 60.5MB/s ± 0% ~ (p=1.000 n=5+5)
wuffs_bzip2_decode_100k/clang11 46.7MB/s ± 1% 45.7MB/s ± 1% -2.05% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 58.7MB/s ± 0% 58.5MB/s ± 0% ~ (p=0.222 n=5+5)
wuffs_bzip2_decode_100k/gcc10 46.9MB/s ± 0% 46.3MB/s ± 0% -1.46% (p=0.008 n=5+5)
2022-05-24 11:50:48 +10:00
Nigel Tao
ae1e075401
Rename std/bzip2 decode_block_* functions
2022-05-24 11:24:57 +10:00
Nigel Tao
fc0c5e465b
Rename std/bzip2/decode_block_*.wuffs
2022-05-24 11:24:15 +10:00
Nigel Tao
623290ef87
Cache std/bzip2 Huffman tree lookup
...
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 46.5MB/s ± 0% 60.5MB/s ± 0% +30.16% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 39.4MB/s ± 1% 46.7MB/s ± 1% +18.43% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 43.8MB/s ± 0% 58.7MB/s ± 0% +34.07% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10 35.9MB/s ± 0% 46.9MB/s ± 0% +30.92% (p=0.008 n=5+5)
2022-05-23 15:51:51 +10:00
Nigel Tao
fdad12d59f
Have std/bzip2 read 4 (not 1) bytes per inner loop
...
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 42.9MB/s ± 0% 46.5MB/s ± 0% +8.38% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 36.9MB/s ± 0% 39.4MB/s ± 1% +6.75% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 36.5MB/s ± 0% 43.8MB/s ± 0% +19.73% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10 30.8MB/s ± 0% 35.9MB/s ± 0% +16.37% (p=0.008 n=5+5)
2022-05-23 15:22:31 +10:00
Nigel Tao
94a2c704d4
Factor out std/bzip2/decode_block_slow.wuffs
2022-05-23 13:54:50 +10:00
Nigel Tao
27e9b81588
Optimize bzip2 invert_bwt letter counting
...
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 42.2MB/s ± 0% 42.9MB/s ± 0% +1.63% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 36.2MB/s ± 1% 36.9MB/s ± 0% +2.07% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 35.3MB/s ± 0% 36.5MB/s ± 0% +3.62% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10 29.5MB/s ± 0% 30.8MB/s ± 0% +4.59% (p=0.008 n=5+5)
2022-05-23 13:36:55 +10:00
Nigel Tao
be047533e1
Add bounds check to wuffs_base__make_slice_uNN_ij
2022-05-23 11:07:31 +10:00
Nigel Tao
84ef91dda8
Tweak cgen for an_array[i .. j]
2022-05-17 00:00:25 +10:00
Nigel Tao
f1350825cc
Fix cgen for an_array[i .. j]
2022-05-16 23:39:44 +10:00
Nigel Tao
68b76a8a56
Implement std/bzip2
2022-05-16 23:35:32 +10:00
Nigel Tao
787ff21cc7
Let magic_number_guess_fourcc sniff compression
2022-05-13 11:01:28 +10:00
Nigel Tao
ce8d08598d
Add std/bzip2 package
...
This is just a placeholder decoder implementation.
2022-05-12 23:52:12 +10:00
Nigel Tao
4c56f5bdb2
Fix png.DECODER_WORKBUF_LEN_MAX_INCL_WORST_CASE
2022-05-12 22:30:28 +10:00
Nigel Tao
03fd43cfcc
Add "#png: unsupported CgBI extension" status
2022-03-21 14:12:25 +11:00
Nigel Tao
dd9679b56e
Remove some redundant assignments after yields
2022-01-25 21:33:19 +11:00
Nigel Tao
7b51266642
Remove redundant json decode_comment "while true"
2022-01-25 21:26:27 +11:00
Nigel Tao
5a93c63f0a
Tweak json.decoder.decode_comment
2022-01-25 21:24:54 +11:00
Nigel Tao
656c0bdf92
Remove some redundant assignments after yields
2022-01-25 20:37:50 +11:00
Nigel Tao
b374b2b34f
Tweak json decode_trailer whitespace_length var
2022-01-25 20:36:10 +11:00
Nigel Tao
ad46513ded
Remove some redundant assignments after yields
2022-01-25 20:25:46 +11:00
Nigel Tao
97eb1290f5
Tweak liveness analysis for if-else chains
2022-01-25 19:40:22 +11:00
Nigel Tao
79ce1a7b0e
Clear livenesses after jumps and returns
2022-01-25 15:04:07 +11:00
Nigel Tao
5ecd84e0ed
Have std/png partially decode invalid images
2022-01-25 14:36:31 +11:00
Nigel Tao
a4b14a0f17
Simpify std/png "yield short read" loop
2022-01-25 14:29:18 +11:00
Nigel Tao
63d8564b3c
Tweak liveness analysis for "while true" loops
2022-01-25 14:21:49 +11:00
Nigel Tao
d53f37997f
Have std/png decode truncated images
...
Fixes #71
2022-01-23 22:59:06 +11:00
Nigel Tao
418847fe94
wuffs gen -version=0.3.0-beta.14
2022-01-19 11:04:21 +11:00
Nigel Tao
c203818556
Have std/tga ignore X-Origin and Y-Origin fields
...
Updates #67
2022-01-15 15:10:03 +11:00